From patchwork Thu May 20 09:22:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 443176 Delivered-To: patch@linaro.org Received: by 2002:a17:907:2b0d:0:0:0:0 with SMTP id gc13csp2432255ejc; Thu, 20 May 2021 02:33:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2uoBQicy/1PJkuut3LxggpqM0qcNOQpNagS18Qv0W+tVHWZbjRw0mm0E5GNluhizNJZ9V X-Received: by 2002:a5e:974d:: with SMTP id h13mr4282918ioq.150.1621503198622; Thu, 20 May 2021 02:33:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621503198; cv=none; d=google.com; s=arc-20160816; b=FZ0MOxCPq3DG+DkGt4n4vEtUJWyvG5zlODW3GTGveYHGZ9xEL68FtuO7zFiEx4VWcT G3ZXBHlhC04cr0kGGHse5VYqOgyNxyvvTazxbg1McLLq+tQKHLyG2MkkVgYyCF1oqVvs dc1J3zI4PFg9cBEhDX/lYlZtZfxri3nf22FVOs5sLRkOfXBzMKX4bbbt+zoUY1aGIE92 ONIpEJ1lWd1Oy9aKSjFZLEw7DlXWd92qYhEnXBQZ+qgs2krYKVA/bK4mDmJ5/23BVnSU Az1332RCwHmYNpfPlkAKB263cMizya+IdMc7/2WOHYwGTpYUF9g0j3hU4gWnika+CqZE UGSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8oeCbyb1cPeK0jWBOM10ccTp74es/gAColdRECiD2hM=; b=xSeaCJqBypoG7sV+XJVdARjW80wMHsOOYWmS7olbkOFxhjV8MhuxcriDLKmtnJGRP3 tM3SOjN8WKjPc2c+RnCoQEVXakAHzjRHfHcw5BijLvWvknETXAE1HljYObsaXsBITIuu oz/4t6eAis/UFUXhr8b+aY+VR2kBpOQmevqgLDcRVArMa6HYnae+VwU6VVqXK7LfNKeh Z2bMfG2oIIta1Zi/BYrIFzVcpPVHOR1Z+sUSKSeabcvdwh8JTEE0wIvwJmixFtJWfnfD za8NdohVjjmZFdFd89/Dg7BDjCA+lYU5H7aaMqyNrVKKW2MbUdr7gASLM8XBzfXnnI1L xfAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=y680I1zE; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w14si32036ilv.110.2021.05.20.02.33.18; Thu, 20 May 2021 02:33:18 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=y680I1zE; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232992AbhETJef (ORCPT + 12 others); Thu, 20 May 2021 05:34:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:60810 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231653AbhETJcF (ORCPT ); Thu, 20 May 2021 05:32:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4C645613DB; Thu, 20 May 2021 09:28:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621502898; bh=DsBOTJL5ir0zrcnF3XcMFfXwg59YIrtgqteA1mt4Cyk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y680I1zEQY7emCZRkNB9vKPnrevuyAAbB91u9J1uhabFs8veEuxwhB7Dvw+Jp8DHh 80CfCGngfbM0FJhNEfhqqIXtWbs3/K7HHElacBs8A2zXjyOEJVKetP2SV5vYSY+kKr 2p1fMFZNkiRpO8NPWaTLZ0xfYseDbVkEJbFE7GVs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann Subject: [PATCH 5.4 03/37] usb: sl811-hcd: improve misleading indentation Date: Thu, 20 May 2021 11:22:24 +0200 Message-Id: <20210520092052.382408379@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210520092052.265851579@linuxfoundation.org> References: <20210520092052.265851579@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann commit 8460f6003a1d2633737b89c4f69d6f4c0c7c65a3 upstream. gcc-11 now warns about a confusingly indented code block: drivers/usb/host/sl811-hcd.c: In function ‘sl811h_hub_control’: drivers/usb/host/sl811-hcd.c:1291:9: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation] 1291 | if (*(u16*)(buf+2)) /* only if wPortChange is interesting */ | ^~ drivers/usb/host/sl811-hcd.c:1295:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ 1295 | break; Rewrite this to use a single if() block with the __is_defined() macro. Signed-off-by: Arnd Bergmann Link: https://lore.kernel.org/r/20210322164244.827589-1-arnd@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/sl811-hcd.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) --- a/drivers/usb/host/sl811-hcd.c +++ b/drivers/usb/host/sl811-hcd.c @@ -1287,11 +1287,10 @@ sl811h_hub_control( goto error; put_unaligned_le32(sl811->port1, buf); -#ifndef VERBOSE - if (*(u16*)(buf+2)) /* only if wPortChange is interesting */ -#endif - dev_dbg(hcd->self.controller, "GetPortStatus %08x\n", - sl811->port1); + if (__is_defined(VERBOSE) || + *(u16*)(buf+2)) /* only if wPortChange is interesting */ + dev_dbg(hcd->self.controller, "GetPortStatus %08x\n", + sl811->port1); break; case SetPortFeature: if (wIndex != 1 || wLength != 0)