From patchwork Wed May 12 14:44:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 435595 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp5005029jao; Wed, 12 May 2021 09:52:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6PWvqG5cAX//F3bQmWNqeqWXPpgXMQJNf4k98eCofK1cmMvCTyz4w7zDyUeT+oRlk7aPB X-Received: by 2002:a92:d212:: with SMTP id y18mr541547ily.176.1620838350040; Wed, 12 May 2021 09:52:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620838350; cv=none; d=google.com; s=arc-20160816; b=q4P07+rz/7dM7ES5i/CJT9pefSUQ2xPJxlNsuSR2uoRQPcJfuMovgDvvlqheQG6mEQ hZ9ZdQaI/eqOGGOdmfbQDKK9GXCCaBjtf4ptET5qIcU1lgon62aZQARDjv4SjAydD2A5 PsbRkvLatducn7ya63h2FgZOTT/ErLODKkfVfCVvmES7yfaYFbK06xMOWeYbEGDYes7h qdqVlskNbQn+Sku+XvSoq5nQvII+iQ6UuW7QHCNn5QHSdYTHGzBVwRspYoBaSFmvU426 idCKBWOsat55xRJ4ROTaJtE46NecWg4Fu9LU35Tq36TYsxtZPEcyodwWLmtTWVwZmV/i jieg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=FB4yZ21EpiLGwkciapIb4Amlm7YqTNKnQjp0bCPpYYI=; b=YS9NnU0Ex/q4e68h1Arak6qcIRgR1txoNcQkalnHuL0SEgzf1/J0zbc8TETTdlPbQC JW3tz3z7IfvZ1Ve+Hvwtm8lWo00ryuCvEliyIsFxhXhGE7sJaBtcajHt9iIsTp+urw/J TteVgQ0PS2M9W3C9qX0FyutYiuYQ2j5+auu5fVz2wn8ugRZIu4BsCLQBaQHJ+HnO6m1y YGpqjQVwJcW61SSP+JQ9H8htmRS/XSud1OBbE0X/Pc/4mXKJ9v3foC/SpmhbnDnWXtX7 osQgfBdWG7sB4cWDmNE83MhtADxrYi5GbNvadk1avFNh8SOIuT0d0cFMAw6aeRMPo3AC VLXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=thDnY4ys; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q8si330223ior.12.2021.05.12.09.52.29; Wed, 12 May 2021 09:52:30 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=thDnY4ys; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233676AbhELQIM (ORCPT + 12 others); Wed, 12 May 2021 12:08:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:48634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236028AbhELQCA (ORCPT ); Wed, 12 May 2021 12:02:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4465961CD3; Wed, 12 May 2021 15:33:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620833602; bh=kJsvZrksRAsFNYglY0p35nqsilfIf/y3yRu5Ywmc8N8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=thDnY4ysp3rOYrZKIGkR731bxjCGgg/GFRiAtoN/ihv0woDKOQtyDi14Qcyo7SmP1 RERyD9YIQzV8Db1aMmKGbjEc4Dn+xIXNKWVaDc896CrCeose1GRHsfSzW3Ybm0JQuB i1zhWTRn5A4rcSsHMccOU8+CyOlZj5x5OTQe1Vgw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Srinivas Kandagatla , Pierre-Louis Bossart , Vinod Koul , Sasha Levin Subject: [PATCH 5.11 214/601] soundwire: bus: Fix device found flag correctly Date: Wed, 12 May 2021 16:44:51 +0200 Message-Id: <20210512144834.891719632@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144827.811958675@linuxfoundation.org> References: <20210512144827.811958675@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Srinivas Kandagatla [ Upstream commit f03690f4f6992225d05dbd1171212e5be5a370dd ] found flag is used to indicate SoundWire devices that are both enumerated on the bus and available in the device list. However this flag is not reset correctly after one iteration, This could miss some of the devices that are enumerated on the bus but not in device list. So reset this correctly to fix this issue! Fixes: d52d7a1be02c ("soundwire: Add Slave status handling helpers") Signed-off-by: Srinivas Kandagatla Reviewed-by: Pierre-Louis Bossart Link: https://lore.kernel.org/r/20210309104816.20350-1-srinivas.kandagatla@linaro.org Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/soundwire/bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.30.2 diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index 662b3b030246..03ed618ffc59 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -703,7 +703,7 @@ static int sdw_program_device_num(struct sdw_bus *bus) struct sdw_slave *slave, *_s; struct sdw_slave_id id; struct sdw_msg msg; - bool found = false; + bool found; int count = 0, ret; u64 addr; @@ -735,6 +735,7 @@ static int sdw_program_device_num(struct sdw_bus *bus) sdw_extract_slave_id(bus, addr, &id); + found = false; /* Now compare with entries */ list_for_each_entry_safe(slave, _s, &bus->slaves, node) { if (sdw_compare_devid(slave, id) == 0) {