From patchwork Wed May 12 14:47:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "gregkh@linuxfoundation.org" X-Patchwork-Id: 435545 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp4908038jao; Wed, 12 May 2021 08:01:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqfLwgn7qIGY0uhw0qwCcM769d7QaNxkey/TC0K3+D7EjCXEJNuMLgiGO7ZiIII5jFCrqb X-Received: by 2002:a05:6e02:118b:: with SMTP id y11mr31187490ili.163.1620831704624; Wed, 12 May 2021 08:01:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620831704; cv=none; d=google.com; s=arc-20160816; b=IBgvWbjRoLJoddg9674KEHBjyXT87EGLTn6aqaYSuBjAQQ3pVoEdM/EEd2dC05ftDQ UFBX6ld1+KuNJDh7Hj8X3/sOPmBdYbdATcp1vnvOkYZgE4Dze+9TVExefybdfeGE+Oeq umGMS6+v/JNCTWkKrd/7LwjgMOXdTaWTmnb7kDZEiCPWNkg158qxUX8HWhmBO/zcB8mc hPj5RtgdHEQSkgBkUqHdntuujkgqPVkciaPRPboM/J7ZHrkl43Spww3zLYlbCBk6i70S DrvL3i3K59TEJtReZmEcsiCefYWZ0nFYQikKmma4nedijyhGSarjvkKesDFhtXnmZfA/ Rw2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JD/OJSVOkAxdRWq6datypAJHO7a2mOauubOjDD8X1Cs=; b=xv7WtxJ62joxN9R5T89L7GPLhyxVTuvM15hNEk8UW2vf6iS2n+J5pUHC8pVmHDPG6P nbAsinh6kyOxRrupzIgrbam4ZE3VH/6ksS4Qv4bTjBV+B0FficFlaigj/HBL+UJJc5Kv NZxMHoSt7zQtiNfih+qF9nt84Bk0+pxUcS6Mqx3h9Ib2wVVPkiH/6c2IwoEmSgY9+oGs VJ1JD3vihnr9KL+iLRyX6K39brj8dMHz3yPZUPkKsEHRnB2RjAEfbFBoZRk4ghPmc+Wy mCfK1D4FsJj23Hwkyn2DuyQ3g16B3Qgd5N5D400J/26XhxrcwQ/abJps3ZofIddPY8ny qqgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eyodCjuC; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r139si177320jac.21.2021.05.12.08.01.44; Wed, 12 May 2021 08:01:44 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eyodCjuC; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232985AbhELPCt (ORCPT + 12 others); Wed, 12 May 2021 11:02:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:46036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231190AbhELO7u (ORCPT ); Wed, 12 May 2021 10:59:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A002F6143D; Wed, 12 May 2021 14:56:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620831405; bh=e3OOcQJpqFZGaR6u1gY8aZUXjS+i30BuumWbEPhDvuQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eyodCjuCVOTKEA0Sm9RN0gNjiQWmnoAmquA7HiqMXtmZ3eHgenYs8QjxDzRdGWclR TGuDki0Uo7eyIZFcSOGA03zNQ5qvd1CfKibOko6mebio6HBlCRRqAjwpzZXRhv2qSZ P85O5Xgs7/rtsXBSsN6OMgjypaYBtTRARYwdfEfg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Marc Zyngier , Sasha Levin Subject: [PATCH 5.4 106/244] irqchip/gic-v3: Fix OF_BAD_ADDR error handling Date: Wed, 12 May 2021 16:47:57 +0200 Message-Id: <20210512144746.419403229@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144743.039977287@linuxfoundation.org> References: <20210512144743.039977287@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 8e13d96670a4c050d4883e6743a9e9858e5cfe10 ] When building with extra warnings enabled, clang points out a mistake in the error handling: drivers/irqchip/irq-gic-v3-mbi.c:306:21: error: result of comparison of constant 18446744073709551615 with expression of type 'phys_addr_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare] if (mbi_phys_base == OF_BAD_ADDR) { Truncate the constant to the same type as the variable it gets compared to, to shut make the check work and void the warning. Fixes: 505287525c24 ("irqchip/gic-v3: Add support for Message Based Interrupts as an MSI controller") Signed-off-by: Arnd Bergmann Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20210323131842.2773094-1-arnd@kernel.org Signed-off-by: Sasha Levin --- drivers/irqchip/irq-gic-v3-mbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.2 diff --git a/drivers/irqchip/irq-gic-v3-mbi.c b/drivers/irqchip/irq-gic-v3-mbi.c index 563a9b366294..e81e89a81cb5 100644 --- a/drivers/irqchip/irq-gic-v3-mbi.c +++ b/drivers/irqchip/irq-gic-v3-mbi.c @@ -303,7 +303,7 @@ int __init mbi_init(struct fwnode_handle *fwnode, struct irq_domain *parent) reg = of_get_property(np, "mbi-alias", NULL); if (reg) { mbi_phys_base = of_translate_address(np, reg); - if (mbi_phys_base == OF_BAD_ADDR) { + if (mbi_phys_base == (phys_addr_t)OF_BAD_ADDR) { ret = -ENXIO; goto err_free_mbi; }