From patchwork Wed May 12 14:47:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "gregkh@linuxfoundation.org" X-Patchwork-Id: 435542 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp4905648jao; Wed, 12 May 2021 07:59:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyY7DtU+k3wLAxwjJgTiy6ifEIoJLoVuk1+bCT2ZP0RFr9PbqbGOwI231NKHz1TYHX6/a++ X-Received: by 2002:a92:4b06:: with SMTP id m6mr13583856ilg.54.1620831561171; Wed, 12 May 2021 07:59:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620831561; cv=none; d=google.com; s=arc-20160816; b=TdzqwTtkKBeo4Ddej4Gl1YaPbgnSt6SZJEDhVGAhog2wOqJ7sofheg+hh/4IjmHOO7 ISTzatf6Hv7uAdiuxuX23jKH3EM3mNCDATJtuPqSnk2x/EI4eJIQ8xoO5iHgGW5pXbCD CbSOH1/Bk5wCeAaIAe2PrPCNZJW+jmWp1x3d+ZWpTHkUNpRH+iuqmquBrIPzZu2l5aSv yUZK0522gb1lVo+FpIGoF+NTqtfWRBgLOSZrYbpQR9FhnxKlZFgW2DZ7tEVr0ngNS3AT Df9bYkG0h4Me/EOXsYJymRLiav2t4l0fprCanrzEenPUUBXO0VWRqBdDki4Je7VgbED9 Tanw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=eDHIm3FPzdnlVtvuXmmWs3+QMAKRrdPQwDbzA0l+hB8=; b=s6/EUoz3hZy6Xuj2Lh4KbectpArgJUnu3v10EBXIHULecDfqN6pGAtukWfPZnT2cAm IT6bt9rxtYXoJep6VGy7xVI/JQ0uy1YSIHLkMDVsJvcN0W3dSefMZhWFrrCypw6cTwVn BzSCx08xqPTqYb0W6YDetIr6InejPwPMP4FK9xHiWhS7UXUl8E5uVRXRYqTbH+awp3EP ifQtiGLc351+V9qCHrYfXFG912e0j2KNIL6fCnf2b5agTpFfPR5t0kZM5bvI/zfOSPgK EyvINZ1/q3eUF/8haCdA9Lng4AnTAKsaPXcri2WMmiUJ1ShEwbpS19sT2x2Zy84rxTEq EX9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=E55vbCkz; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w9si13586069ilv.15.2021.05.12.07.59.20; Wed, 12 May 2021 07:59:21 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=E55vbCkz; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232644AbhELPAZ (ORCPT + 12 others); Wed, 12 May 2021 11:00:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:45390 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232542AbhELO6e (ORCPT ); Wed, 12 May 2021 10:58:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7939461457; Wed, 12 May 2021 14:56:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620831379; bh=McKv5zayhYkzZStl74alSUDwa1OATj2/Bom+Jvxtntc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E55vbCkzHdq0tbGUZasIHrYnXYSGZ9YA5TyJloxrVQEOUGB0M63E0KuVQ1Hd+MnPo pTvyDeI0cXCc182zV251xNJJGFrvFK1AC3Nr/hpQ85+iIC+iAv20XXHque11Gw12sg lLV/VsQaXPEEcYbhcmtkUU2mQHrriAihtaTnH3f4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Srinivas Kandagatla , Pierre-Louis Bossart , Vinod Koul , Sasha Levin Subject: [PATCH 5.4 097/244] soundwire: bus: Fix device found flag correctly Date: Wed, 12 May 2021 16:47:48 +0200 Message-Id: <20210512144746.142748511@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210512144743.039977287@linuxfoundation.org> References: <20210512144743.039977287@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Srinivas Kandagatla [ Upstream commit f03690f4f6992225d05dbd1171212e5be5a370dd ] found flag is used to indicate SoundWire devices that are both enumerated on the bus and available in the device list. However this flag is not reset correctly after one iteration, This could miss some of the devices that are enumerated on the bus but not in device list. So reset this correctly to fix this issue! Fixes: d52d7a1be02c ("soundwire: Add Slave status handling helpers") Signed-off-by: Srinivas Kandagatla Reviewed-by: Pierre-Louis Bossart Link: https://lore.kernel.org/r/20210309104816.20350-1-srinivas.kandagatla@linaro.org Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/soundwire/bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.30.2 diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index a90963812357..d90f00d09257 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -525,7 +525,7 @@ static int sdw_program_device_num(struct sdw_bus *bus) struct sdw_slave *slave, *_s; struct sdw_slave_id id; struct sdw_msg msg; - bool found = false; + bool found; int count = 0, ret; u64 addr; @@ -557,6 +557,7 @@ static int sdw_program_device_num(struct sdw_bus *bus) sdw_extract_slave_id(bus, addr, &id); + found = false; /* Now compare with entries */ list_for_each_entry_safe(slave, _s, &bus->slaves, node) { if (sdw_compare_devid(slave, id) == 0) {