From patchwork Mon May 10 10:16:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 433075 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp2725283jao; Mon, 10 May 2021 04:02:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysSoyCzd+X3oJ4AwFrrGn7hHdW1LDERk5vXYP8AlZkULThPztTKCca5DBAEs8mnt83Dwdi X-Received: by 2002:a17:907:c13:: with SMTP id ga19mr24665267ejc.163.1620644579425; Mon, 10 May 2021 04:02:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620644579; cv=none; d=google.com; s=arc-20160816; b=JwBV2/KJIEh1YUjx2hTZpqQgpXkGTuZcU8kIqpFnNP5H9SZp86j9rtYCJi0yU3RIK7 AzRuTRQtDly6K/1tA0X56F/uAuxLz1xlVc0DqNs3z+eXvVhnoTHjudkMy8Eoi6rw65qa li+GwFN4nhARiJc39kjmxUcCP1zH3DHQCVYBpEYhsca387ua2IjWisufHSNbZu0fSIQE L3INKZnC8tlnRdauI1PRgrq4nr1/zTjYzcgxKz4OcyR9TCMnpxgcS6INgw4CfErlnRHr gpgQLobJVKdFx4Ct1SB5yrs85WxmBuiAPurD1xThhUcW8QgOCAX8F0QNFccyIt3sZJQt 0Liw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1oNOGEnTNixUzizr+oyRZPXOEyoS8lTTCYICWCYjV6s=; b=Y0cJLTD8C3mlY5hnMO6HMYd06Fs9bDA7ge9RNbAynMZkMR0EHtNAGwa43kExUH1Wks hsRpeHy7kVkXOBOQF5MW3MIp3XWkpm805immTlr4syaPdr/139ECaOzOpa/ODP3Iq20/ xTD4DmTocVSo6w67Bt1w/DpEosHc38sbjGcrvO2H3MuI/xKgx0lJcNS+XzLPR4958QqC v/+n+meMwsUDoPQqt0usNH/0rMcu8yhjHzhOEzPdQ/A6ShA+D07dg8FWGcWpjh8XLxLa 9clYm7tubsC71z7WAxOAMpQzzQ57smomO8oYWDKLq2fmfTraSfNK2IIrBwmVu4uPWf3v WaYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=vkAb0bBi; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r17si13500365edw.273.2021.05.10.04.02.59; Mon, 10 May 2021 04:02:59 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=vkAb0bBi; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235147AbhEJLAN (ORCPT + 12 others); Mon, 10 May 2021 07:00:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:52212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234130AbhEJKz5 (ORCPT ); Mon, 10 May 2021 06:55:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 734906192F; Mon, 10 May 2021 10:44:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620643449; bh=2ub5n051EsQOnH9xKRr0nIKieuG9JUyj2Fy7ivBWcgw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vkAb0bBiwF2y4wK9PzkyE4YDK63+qrXCk2Ies72iU3LwPlFlgV9CdlMAlBk7WLRsf W3ERuqIKxlVssmpytVWtbKOuB7k3tJBhOP4k3hC7B7l0tTO2LfxAVblfCEFFsAJoWS TadMABEhMVkNrlgZT3augspGX4OVvLQ6Dq1RFW6E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Loic Poulain , Bhaumik Bhatt , Manivannan Sadhasivam Subject: [PATCH 5.11 005/342] bus: mhi: pci_generic: Remove WQ_MEM_RECLAIM flag from state workqueue Date: Mon, 10 May 2021 12:16:35 +0200 Message-Id: <20210510102010.278312471@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210510102010.096403571@linuxfoundation.org> References: <20210510102010.096403571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Loic Poulain commit 0fccbf0a3b690b162f53b13ed8bc442ea33437dc upstream. A recent change created a dedicated workqueue for the state-change work with WQ_HIGHPRI (no strong reason for that) and WQ_MEM_RECLAIM flags, but the state-change work (mhi_pm_st_worker) does not guarantee forward progress under memory pressure, and will even wait on various memory allocations when e.g. creating devices, loading firmware, etc... The work is then not part of a memory reclaim path... Moreover, this causes a warning in check_flush_dependency() since we end up in code that flushes a non-reclaim workqueue: [ 40.969601] workqueue: WQ_MEM_RECLAIM mhi_hiprio_wq:mhi_pm_st_worker [mhi] is flushing !WQ_MEM_RECLAIM events_highpri:flush_backlog [ 40.969612] WARNING: CPU: 4 PID: 158 at kernel/workqueue.c:2607 check_flush_dependency+0x11c/0x140 [ 40.969733] Call Trace: [ 40.969740] __flush_work+0x97/0x1d0 [ 40.969745] ? wake_up_process+0x15/0x20 [ 40.969749] ? insert_work+0x70/0x80 [ 40.969750] ? __queue_work+0x14a/0x3e0 [ 40.969753] flush_work+0x10/0x20 [ 40.969756] rollback_registered_many+0x1c9/0x510 [ 40.969759] unregister_netdevice_queue+0x94/0x120 [ 40.969761] unregister_netdev+0x1d/0x30 [ 40.969765] mhi_net_remove+0x1a/0x40 [mhi_net] [ 40.969770] mhi_driver_remove+0x124/0x250 [mhi] [ 40.969776] device_release_driver_internal+0xf0/0x1d0 [ 40.969778] device_release_driver+0x12/0x20 [ 40.969782] bus_remove_device+0xe1/0x150 [ 40.969786] device_del+0x17b/0x3e0 [ 40.969791] mhi_destroy_device+0x9a/0x100 [mhi] [ 40.969796] ? mhi_unmap_single_use_bb+0x50/0x50 [mhi] [ 40.969799] device_for_each_child+0x5e/0xa0 [ 40.969804] mhi_pm_st_worker+0x921/0xf50 [mhi] Fixes: 8f7039787687 ("bus: mhi: core: Move to using high priority workqueue") Signed-off-by: Loic Poulain Reviewed-by: Bhaumik Bhatt Reviewed-by: Manivannan Sadhasivam Link: https://lore.kernel.org/r/1614161930-8513-1-git-send-email-loic.poulain@linaro.org Signed-off-by: Manivannan Sadhasivam Signed-off-by: Greg Kroah-Hartman --- drivers/bus/mhi/core/init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/bus/mhi/core/init.c +++ b/drivers/bus/mhi/core/init.c @@ -896,8 +896,7 @@ int mhi_register_controller(struct mhi_c INIT_WORK(&mhi_cntrl->st_worker, mhi_pm_st_worker); init_waitqueue_head(&mhi_cntrl->state_event); - mhi_cntrl->hiprio_wq = alloc_ordered_workqueue - ("mhi_hiprio_wq", WQ_MEM_RECLAIM | WQ_HIGHPRI); + mhi_cntrl->hiprio_wq = alloc_ordered_workqueue("mhi_hiprio_wq", WQ_HIGHPRI); if (!mhi_cntrl->hiprio_wq) { dev_err(mhi_cntrl->cntrl_dev, "Failed to allocate workqueue\n"); ret = -ENOMEM;