From patchwork Mon Apr 26 07:29:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 427522 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp3463170jao; Mon, 26 Apr 2021 00:41:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKhYNKOD6FnTUR2C4XEZQ4WptYZ0+qBC6KCDUQ/Gkr2pCJlS9tvSTDuypTR/eeAOhwdmvu X-Received: by 2002:a17:90a:ce8b:: with SMTP id g11mr7568662pju.173.1619422864041; Mon, 26 Apr 2021 00:41:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619422864; cv=none; d=google.com; s=arc-20160816; b=BfjgD4ImJpR17f5oUV1KVg86+hR+A0c6Kq3OqrndrpcKc2WTN580vNukCmWeq748+K Q3sKS0TH07OxgZbPOwWXmJEDZ8FRd5RRaIen2Rbexv84fikiMDzp6cQe4jFrD9B3Y2Za tOqEF0z37G4ee7YS9NzvPTwTmEvfaz4KPZKfTxRZpkGsIjdMxp9PTkpWsyCIKkahw98M M2C1ZEfxWPWbXDVI0HMMhZGvdMJ8yQ42C+EovgSpwextwN81TJScwB1h0mPuyA6ZI7P5 znlrM7YztmvHHXefAzs6mFWb78OJZSIyvfoi/575QPAsw8a0TZ/yJxUoCGk4P1zQeOfi 5Z5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0BPMkeRQuBphuD9QWLURL60mzeAamGiZT8Y7i4XsGzM=; b=nCyp/krKPH9j1kDXGU92fnzC4l2IRqwXvq1L/g6mE8nNSfZAt+FBEs6SynY6//3118 uAIOz6+y26UEGtRxrUcV08h+vDB0643L1uE8BFVTUGMREXR27EJUSE2AMPoUtRr9jMiV h76IIu8f3udZ0CaSA6oztDGXJ1tVt8AFrNOW/DN5wt8YZXzq11MCm3v0vRGyF5FNEWtm maEsG6/oI0iRq6iISrpk8w6qr9007nqmuewaufZM5OtG2TwSvz4BM8zfKSzVUQZC35mm 9+e8QvBOkhuGJrEucx06ta+G3ZnpiIQ2xSzBOeoljooLNpqNUmNF4jCJKoWCfjdogZNh gJDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="P/Rzwpjb"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u27si17120814pgl.205.2021.04.26.00.41.03; Mon, 26 Apr 2021 00:41:04 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="P/Rzwpjb"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232691AbhDZHln (ORCPT + 12 others); Mon, 26 Apr 2021 03:41:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:49184 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232837AbhDZHhs (ORCPT ); Mon, 26 Apr 2021 03:37:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6E03F613DD; Mon, 26 Apr 2021 07:35:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619422551; bh=uAAUyMljlcrTr7L/lCee6dkkMCsypVanYPJhHqDkpug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P/RzwpjbtokXHVeA0SiVtQFaPdvz1N58JYd1xVHI8mlpJkIMTx1YAmf40gc+loIG3 ZAWBicjGlPKlm0uQb3O+NJ99vgkS/BHkYWtoNtJMGjK6NDmulsSU5gAvzArJ0wQglr eAbLeiGvqBDglRcd9X91MrYHqYh/JIU/J71t004Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Nathan Chancellor , Santosh Shilimkar , Sasha Levin Subject: [PATCH 4.19 10/57] ARM: keystone: fix integer overflow warning Date: Mon, 26 Apr 2021 09:29:07 +0200 Message-Id: <20210426072820.917254331@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210426072820.568997499@linuxfoundation.org> References: <20210426072820.568997499@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 844b85dda2f569943e1e018fdd63b6f7d1d6f08e ] clang warns about an impossible condition when building with 32-bit phys_addr_t: arch/arm/mach-keystone/keystone.c:79:16: error: result of comparison of constant 51539607551 with expression of type 'phys_addr_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare] mem_end > KEYSTONE_HIGH_PHYS_END) { ~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~ arch/arm/mach-keystone/keystone.c:78:16: error: result of comparison of constant 34359738368 with expression of type 'phys_addr_t' (aka 'unsigned int') is always true [-Werror,-Wtautological-constant-out-of-range-compare] if (mem_start < KEYSTONE_HIGH_PHYS_START || ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~ Change the temporary variable to a fixed-size u64 to avoid the warning. Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor Acked-by: Santosh Shilimkar Link: https://lore.kernel.org/r/20210323131814.2751750-1-arnd@kernel.org' Signed-off-by: Arnd Bergmann Signed-off-by: Sasha Levin --- arch/arm/mach-keystone/keystone.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.30.2 diff --git a/arch/arm/mach-keystone/keystone.c b/arch/arm/mach-keystone/keystone.c index 84613abf35a3..79ff5b953431 100644 --- a/arch/arm/mach-keystone/keystone.c +++ b/arch/arm/mach-keystone/keystone.c @@ -65,7 +65,7 @@ static void __init keystone_init(void) static long long __init keystone_pv_fixup(void) { long long offset; - phys_addr_t mem_start, mem_end; + u64 mem_start, mem_end; mem_start = memblock_start_of_DRAM(); mem_end = memblock_end_of_DRAM(); @@ -78,7 +78,7 @@ static long long __init keystone_pv_fixup(void) if (mem_start < KEYSTONE_HIGH_PHYS_START || mem_end > KEYSTONE_HIGH_PHYS_END) { pr_crit("Invalid address space for memory (%08llx-%08llx)\n", - (u64)mem_start, (u64)mem_end); + mem_start, mem_end); return 0; }