From patchwork Mon Apr 19 13:05:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 423986 Delivered-To: patch@linaro.org Received: by 2002:a02:6a6f:0:0:0:0:0 with SMTP id m47csp2705501jaf; Mon, 19 Apr 2021 06:11:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1fSJcksUeqSYGxqvbweNgjuCSfW5no1htZTb2h6FtYGGuR+BGMBBTcPsbEtH48fmvOQvz X-Received: by 2002:a17:902:d112:b029:ec:9f20:3438 with SMTP id w18-20020a170902d112b02900ec9f203438mr7247556plw.7.1618837880301; Mon, 19 Apr 2021 06:11:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618837880; cv=none; d=google.com; s=arc-20160816; b=iKb2sOSkLf0NPiBRHnd1apJmIoZWTtfC1x/GsS3zyvHXyY5PG8DBBH0RSiIEKZupoa 81tpKvTJmUSL66L4g0JK0lFYf44kDL3Fwzd2fVQuETFOElr3rwpS1FHlArp/mBNVF7P1 19eUDv99oA7uDWLvKxCKpvWPJ+gH8UmqhSK4nwgMV9MqRRCYXIKQzH4ZCmJs4fFdKxap y8K+6nAUuehKIOvVXJN9dAbI9BsSm9bMS1ZPF31IoxPY7/cvf4YcQm5Hke03LZ1U5giM qp4yrAGNqmlGFzLIa4o+4yDSDushMdJp1hwLtPkFxJ6aTdsdIv0XgdU+WAdZHAYbYnBh 2sEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RaDl9JEIWgVAFZL3gEUyzg4YZfcDec31NPrL6udkmaM=; b=jOwBXpRf3tth4lMcJN1MNGxJNrMLs/scsrOqgQqBWWcBAEaSYLvAXg80CAM847cx6/ sB4s1Iq9RGml6z+yepM7o0NpBc+LnLETM+qYxX5cgpbPfVOhQUAp+fwPGJ+u0BwOWtEk 0QIkQ6LWYV/oo1RgG9iNdwoUfUmpz0comdqkWqWwfqzJgnB/WjqLqtkof04oH2DFqRfJ ZurMsuJ2o+MkdN0BXLCD2nlf/IyQwSIYfSC3Iv7CLf5hUlHjZslv0CfOTlg8PaWy8ZVz s48pUSns+8Kyr+Jn3T22ThM7HByoLS2tOWBzhmPveJ5BcM1VKQNzT/M7kRrNtTkNITq8 85Jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iOSprCLE; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y4si17809446pga.71.2021.04.19.06.11.20; Mon, 19 Apr 2021 06:11:20 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iOSprCLE; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239941AbhDSNLs (ORCPT + 12 others); Mon, 19 Apr 2021 09:11:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:46726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239478AbhDSNKy (ORCPT ); Mon, 19 Apr 2021 09:10:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 457D3613F7; Mon, 19 Apr 2021 13:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618837824; bh=hHIQYb42wdWozvUKH6R1Uzezj7+klWmXY0qSapeadp8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iOSprCLEbsH7gLjmd1jFsVgPgGYx2TTe4JBfkmnsM3Lft0j8qAAtKzUD1YQ3rQI+H 5q9oMbtfNElb5Il3/Vvg2XPW7o17RM5u8nPOfl+PMbTY6QD2kFaMzJJ7vgU1BJkYRX glHVyoy7KMoibKWXdVttffsKJIX5iS87psM9BwEQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Tony Lindgren , Sasha Levin Subject: [PATCH 5.11 032/122] ARM: omap1: fix building with clang IAS Date: Mon, 19 Apr 2021 15:05:12 +0200 Message-Id: <20210419130531.256164935@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210419130530.166331793@linuxfoundation.org> References: <20210419130530.166331793@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 28399a5a6d569c9bdb612345e4933046ca37cde5 ] The clang integrated assembler fails to build one file with a complex asm instruction: arch/arm/mach-omap1/ams-delta-fiq-handler.S:249:2: error: invalid instruction, any one of the following would fix this: mov r10, #(1 << (((NR_IRQS_LEGACY + 12) - NR_IRQS_LEGACY) % 32)) @ set deferred_fiq bit ^ arch/arm/mach-omap1/ams-delta-fiq-handler.S:249:2: note: instruction requires: armv6t2 mov r10, #(1 << (((NR_IRQS_LEGACY + 12) - NR_IRQS_LEGACY) % 32)) @ set deferred_fiq bit ^ arch/arm/mach-omap1/ams-delta-fiq-handler.S:249:2: note: instruction requires: thumb2 mov r10, #(1 << (((NR_IRQS_LEGACY + 12) - NR_IRQS_LEGACY) % 32)) @ set deferred_fiq bit ^ The problem is that 'NR_IRQS_LEGACY' is not defined here. Apparently gas does not care because we first add and then subtract this number, leading to the immediate value to be the same regardless of the specific definition of NR_IRQS_LEGACY. Neither the way that 'gas' just silently builds this file, nor the way that clang IAS makes nonsensical suggestions for how to fix it is great. Fortunately there is an easy fix, which is to #include the header that contains the definition. Signed-off-by: Arnd Bergmann Acked-by: Tony Lindgren Link: https://lore.kernel.org/r/20210308153430.2530616-1-arnd@kernel.org' Signed-off-by: Arnd Bergmann Signed-off-by: Sasha Levin --- arch/arm/mach-omap1/ams-delta-fiq-handler.S | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/arch/arm/mach-omap1/ams-delta-fiq-handler.S b/arch/arm/mach-omap1/ams-delta-fiq-handler.S index 14a6c3eb3298..f745a65d3bd7 100644 --- a/arch/arm/mach-omap1/ams-delta-fiq-handler.S +++ b/arch/arm/mach-omap1/ams-delta-fiq-handler.S @@ -15,6 +15,7 @@ #include #include +#include #include "ams-delta-fiq.h" #include "board-ams-delta.h"