From patchwork Mon Apr 19 13:05:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 423990 Delivered-To: patch@linaro.org Received: by 2002:a02:6a6f:0:0:0:0:0 with SMTP id m47csp2712105jaf; Mon, 19 Apr 2021 06:18:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfDBcfc1RFB8WAf4h9pytozATUBYPGgf6i3klxD8U43kSNfBN3jGgDxX3rXpGaC5UN6lR1 X-Received: by 2002:a17:90b:1d88:: with SMTP id pf8mr24678534pjb.114.1618838313062; Mon, 19 Apr 2021 06:18:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618838313; cv=none; d=google.com; s=arc-20160816; b=RMDpQjiC2J2hxzRBmKfxVLF+sqTeODPjlmalZ9vFvQNKPBjA16c8mvoiF+oMwcRTPx Orfzu7bAsUuPFIZdSge9TLIUTNDQjZSiBLqve4tc+iZL/04WZQoQle4nG00MLxjgWxOD iwDIgwVKLmsUCG/TPQ/+pHW4U3MEDDwysmQEqWQYoEgs5vd0KYRmpJcbQevv0lxjKGQR 3vAtEdqcRpeYHXUdcxadfpvxbBed1nmFFthaoZn0efgrG9PxJT8fzUrLuDxPvP1wFXQG U0uRFpQQHSYafNFTQz0GzFp7gVYjpUnV4BZJIoDFf+zmeiMjef5xp6qjNc7BFhZCAZ2Q RQCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RaDl9JEIWgVAFZL3gEUyzg4YZfcDec31NPrL6udkmaM=; b=gRY7KAHiPPpBAnTSMcQTI+TC/YkN3H1+4LnL7vNAFt9JuygplBNtw9bEQWsYV485FL i0kTss8vGb/DxH3+5FJ37I75oGpYAs/f2v9Q7SuI4WEv7DdMOn+ogjflE0K4/Se3biP1 CPQW33MfRfzGYAbevZtQIIORK6c+S8OSryTyJXhlkcVf0ETEJ7fwNG6+mppLNOI/J4pm NnMYucXiVjxV7TYRvlwn/BxtZ5RPOnmEA/aY9QNnH2katvjnOE18wlBh7frw/PKGs7t4 hHiQXl2k190l95372Zxom06k3WTSIlG62lowZi47oy5HddPR/uUrYBHolMFWeUAWvdYb M7tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=T5XOWI4N; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k1si5096119pgq.470.2021.04.19.06.18.32; Mon, 19 Apr 2021 06:18:33 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=T5XOWI4N; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239982AbhDSNTB (ORCPT + 12 others); Mon, 19 Apr 2021 09:19:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:55300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240387AbhDSNRJ (ORCPT ); Mon, 19 Apr 2021 09:17:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C852D613D3; Mon, 19 Apr 2021 13:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618838052; bh=hHIQYb42wdWozvUKH6R1Uzezj7+klWmXY0qSapeadp8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T5XOWI4NPnyTcQBthAATyVaEB0Iy34LlJ4QthFHHArofZK83raShCwL6ppYkmn98B L9S8ILykkdtenKSuS7mRLi/6L2qRaXDpNBz/qZqyk9ipB48YgMFyycNFvH76UT59D5 NjeWspqcScRfa4PBenUnZ+HezpZy6n1YDsZHC+bU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Tony Lindgren , Sasha Levin Subject: [PATCH 5.10 025/103] ARM: omap1: fix building with clang IAS Date: Mon, 19 Apr 2021 15:05:36 +0200 Message-Id: <20210419130528.663557263@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210419130527.791982064@linuxfoundation.org> References: <20210419130527.791982064@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 28399a5a6d569c9bdb612345e4933046ca37cde5 ] The clang integrated assembler fails to build one file with a complex asm instruction: arch/arm/mach-omap1/ams-delta-fiq-handler.S:249:2: error: invalid instruction, any one of the following would fix this: mov r10, #(1 << (((NR_IRQS_LEGACY + 12) - NR_IRQS_LEGACY) % 32)) @ set deferred_fiq bit ^ arch/arm/mach-omap1/ams-delta-fiq-handler.S:249:2: note: instruction requires: armv6t2 mov r10, #(1 << (((NR_IRQS_LEGACY + 12) - NR_IRQS_LEGACY) % 32)) @ set deferred_fiq bit ^ arch/arm/mach-omap1/ams-delta-fiq-handler.S:249:2: note: instruction requires: thumb2 mov r10, #(1 << (((NR_IRQS_LEGACY + 12) - NR_IRQS_LEGACY) % 32)) @ set deferred_fiq bit ^ The problem is that 'NR_IRQS_LEGACY' is not defined here. Apparently gas does not care because we first add and then subtract this number, leading to the immediate value to be the same regardless of the specific definition of NR_IRQS_LEGACY. Neither the way that 'gas' just silently builds this file, nor the way that clang IAS makes nonsensical suggestions for how to fix it is great. Fortunately there is an easy fix, which is to #include the header that contains the definition. Signed-off-by: Arnd Bergmann Acked-by: Tony Lindgren Link: https://lore.kernel.org/r/20210308153430.2530616-1-arnd@kernel.org' Signed-off-by: Arnd Bergmann Signed-off-by: Sasha Levin --- arch/arm/mach-omap1/ams-delta-fiq-handler.S | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/arch/arm/mach-omap1/ams-delta-fiq-handler.S b/arch/arm/mach-omap1/ams-delta-fiq-handler.S index 14a6c3eb3298..f745a65d3bd7 100644 --- a/arch/arm/mach-omap1/ams-delta-fiq-handler.S +++ b/arch/arm/mach-omap1/ams-delta-fiq-handler.S @@ -15,6 +15,7 @@ #include #include +#include #include "ams-delta-fiq.h" #include "board-ams-delta.h"