From patchwork Mon Apr 19 13:06:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 423995 Delivered-To: patch@linaro.org Received: by 2002:a02:6a6f:0:0:0:0:0 with SMTP id m47csp2719045jaf; Mon, 19 Apr 2021 06:26:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBBQdzVfKc4EXYphOkaLQYYl5lN85ilYM4czSjynBzz2BhlUD7o3QZhB9tjwZc+ZXz1FTu X-Received: by 2002:a05:6402:4a:: with SMTP id f10mr25586117edu.85.1618838802539; Mon, 19 Apr 2021 06:26:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618838802; cv=none; d=google.com; s=arc-20160816; b=jBW6f9s0Kt2AAr9Q1I6fmuSQpTvtjp2N7C5qjkTdJKw4wsGCrW5pxNvx1K22yy6y9j 5bSjKbKFN7Qhf7DFpsK865EZOicWMEVV3U0dS/PXgPcuwWWmPkCD+0G5uoLjV4yh8490 XaFIJRDzWnp/0ROBLlbAKB74fX82zP2g8+kUL1VbYmEdFMjt1BFRCLWwXZqCJiaMqnd9 un8XA8S96LQeODYJpym3WGQg1OyounoOCmX/5xhfi3w5bsbXhVnbg/W+YZyvmjH/aH+P tD6psXDUmk//fVQ/AZsxP1I/EBWn6CaWWLumJx2m+L3IyvN5BYs7MPsS8FP9v7mo7sRV Oxjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RaDl9JEIWgVAFZL3gEUyzg4YZfcDec31NPrL6udkmaM=; b=RWSWxF3uUNSaYVpVQdYSR/ahL39GLomtodUHZNsiYiaa6NEk2berRLKtifCqqVznrc qHIM3+VkaygwDWYlhI5BJrs2yVMX8RFuvoyVnQcTbQD0HhHhA5+MpFaVqiFmTUs2MgUg y+LFy+UtdLOi1Gtpg2fzjN7DrN0IMvB3W48Hqqnv0OhQPEOasgLAxGNDqYV8a+chjW05 WBEmGR71c1AF8sKQ+aJuQGzDf70xJsNj2OLwC4jMJ8Ln4RzOExdBi2D8OqSwYNrgPj9x Y6T99GJ7xInLxyrdOAN5KOaJ03EfbG6m8LTV4Tb0kh7Bw+7mQtDkBzFlOw7ttLNDaRw0 xJwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=adZEMN0a; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt19si12204115ejc.144.2021.04.19.06.26.42; Mon, 19 Apr 2021 06:26:42 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=adZEMN0a; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242160AbhDSNZZ (ORCPT + 12 others); Mon, 19 Apr 2021 09:25:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:34382 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241641AbhDSNXc (ORCPT ); Mon, 19 Apr 2021 09:23:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2B06561409; Mon, 19 Apr 2021 13:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618838327; bh=hHIQYb42wdWozvUKH6R1Uzezj7+klWmXY0qSapeadp8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=adZEMN0a/9T6OWVvuhOO6vRu50VMpNkBRtpMU6Ov9WOexCjuhr7TWWvUAJl3elBnw 5ztSIDIwu9VtVAn0RSfdpjVgJGoqduQZLyeKS9pP0Gy5y17q02eqKXB68OYU+wR3ph uit0GmS/sWhyzNWC5rOZvg2yb4QO/q17QvsKWVOg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Tony Lindgren , Sasha Levin Subject: [PATCH 5.4 20/73] ARM: omap1: fix building with clang IAS Date: Mon, 19 Apr 2021 15:06:11 +0200 Message-Id: <20210419130524.481205677@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210419130523.802169214@linuxfoundation.org> References: <20210419130523.802169214@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 28399a5a6d569c9bdb612345e4933046ca37cde5 ] The clang integrated assembler fails to build one file with a complex asm instruction: arch/arm/mach-omap1/ams-delta-fiq-handler.S:249:2: error: invalid instruction, any one of the following would fix this: mov r10, #(1 << (((NR_IRQS_LEGACY + 12) - NR_IRQS_LEGACY) % 32)) @ set deferred_fiq bit ^ arch/arm/mach-omap1/ams-delta-fiq-handler.S:249:2: note: instruction requires: armv6t2 mov r10, #(1 << (((NR_IRQS_LEGACY + 12) - NR_IRQS_LEGACY) % 32)) @ set deferred_fiq bit ^ arch/arm/mach-omap1/ams-delta-fiq-handler.S:249:2: note: instruction requires: thumb2 mov r10, #(1 << (((NR_IRQS_LEGACY + 12) - NR_IRQS_LEGACY) % 32)) @ set deferred_fiq bit ^ The problem is that 'NR_IRQS_LEGACY' is not defined here. Apparently gas does not care because we first add and then subtract this number, leading to the immediate value to be the same regardless of the specific definition of NR_IRQS_LEGACY. Neither the way that 'gas' just silently builds this file, nor the way that clang IAS makes nonsensical suggestions for how to fix it is great. Fortunately there is an easy fix, which is to #include the header that contains the definition. Signed-off-by: Arnd Bergmann Acked-by: Tony Lindgren Link: https://lore.kernel.org/r/20210308153430.2530616-1-arnd@kernel.org' Signed-off-by: Arnd Bergmann Signed-off-by: Sasha Levin --- arch/arm/mach-omap1/ams-delta-fiq-handler.S | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/arch/arm/mach-omap1/ams-delta-fiq-handler.S b/arch/arm/mach-omap1/ams-delta-fiq-handler.S index 14a6c3eb3298..f745a65d3bd7 100644 --- a/arch/arm/mach-omap1/ams-delta-fiq-handler.S +++ b/arch/arm/mach-omap1/ams-delta-fiq-handler.S @@ -15,6 +15,7 @@ #include #include +#include #include "ams-delta-fiq.h" #include "board-ams-delta.h"