diff mbox series

[5.10,077/126] drm/imx: fix memory leak when fails to init

Message ID	20210405085033.620798351@linuxfoundation.org
State	New
Headers	show Return-Path: <stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Pan Bian <bianpan2016@163.com>, Philipp Zabel <p.zabel@pengutronix.de> Subject: [PATCH 5.10 077/126] drm/imx: fix memory leak when fails to init Date: Mon, 5 Apr 2021 10:53:59 +0200 Message-Id: <20210405085033.620798351@linuxfoundation.org> In-Reply-To: <20210405085031.040238881@linuxfoundation.org> References: <20210405085031.040238881@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	None \| expand [5.10,002/126] bpf: Fix fexit trampoline. [5.10,005/126] ext4: fix bh ref count on error paths [5.10,007/126] rpc: fix NULL dereference on kmalloc failure [5.10,009/126] ASoC: rt1015: fix i2c communication error [5.10,010/126] ASoC: rt5640: Fix dac- and adc- vol-tlv values being off by a factor of 10 [5.10,013/126] ASoC: es8316: Simplify adc_pga_gain_tlv table [5.10,015/126] ASoC: cs42l42: Fix Bitclock polarity inversion [5.10,016/126] ASoC: cs42l42: Fix channel width support [5.10,018/126] ASoC: cs42l42: Always wait at least 3ms after reset [5.10,021/126] vhost: Fix vhost_vq_reset() [5.10,023/126] scsi: st: Fix a use after free in st_open() [5.10,025/126] staging: comedi: cb_pcidas: fix request_irq() warn [5.10,027/126] ASoC: rt5659: Update MCLK rate in set_sysclk() [5.10,029/126] thermal/core: Add NULL pointer check before using cooling device stats [5.10,030/126] locking/ww_mutex: Simplify use_ww_ctx & ww_ctx handling [5.10,032/126] nvmet-tcp: fix kmap leak when data digest in use [5.10,034/126] static_call: Align static_call_is_init() patching condition [5.10,036/126] io_uring: call req_set_fail_links() on short send[msg]()/recv[msg]() with MSG_WAITALL [5.10,037/126] net: mvpp2: fix interrupt mask/unmask skip condition [5.10,038/126] flow_dissector: fix TTL and TOS dissection on IPv4 fragments [5.10,039/126] can: dev: move driver related infrastructure into separate subdir [5.10,040/126] net: introduce CAN specific pointer in the struct net_device [5.10,044/126] rtw88: coex: 8821c: correct antenna switch function [5.10,046/126] iwlwifi: pcie: dont disable interrupts for reg_lock [5.10,049/126] appletalk: Fix skb allocation size in loopback case [5.10,050/126] net: ipa: remove two unused register definitions [5.10,051/126] net: ipa: fix register write command validation [5.10,052/126] net: wan/lmc: unregister device when no matching device is found [5.10,053/126] net: 9p: advance iov on empty read [5.10,054/126] bpf: Remove MTU check in __bpf_skb_max_len [5.10,057/126] ALSA: usb-audio: Apply sample rate quirk to Logitech Connect [5.10,059/126] ALSA: hda: Add missing sanity checks in PM prepare/complete callbacks [5.10,060/126] ALSA: hda/realtek: fix a determine_headset_type issue for a Dell AIO [5.10,064/126] xtensa: move coprocessor_flush to the .text section [5.10,066/126] KVM: SVM: ensure that EFER.SVME is set when running nested guest or on nested vmexit [5.10,067/126] PM: runtime: Fix race getting/putting suppliers at probe [5.10,068/126] PM: runtime: Fix ordering in pm_runtime_get_suppliers() [5.10,071/126] s390/vdso: fix tod_steering_delta type [5.10,075/126] drm/amdgpu: check alignment on CPU page for bo map [5.10,077/126] drm/imx: fix memory leak when fails to init [5.10,079/126] drm/tegra: sor: Grab runtime PM reference across reset [5.10,081/126] pinctrl: rockchip: fix restore error in resume [5.10,082/126] KVM: x86/mmu: change TDP MMU yield function returns to match cond_resched [5.10,084/126] KVM: x86/mmu: Rename goal_gfn to next_last_level_gfn [5.10,088/126] KVM: x86/mmu: Add lockdep when setting a TDP MMU SPTE [5.10,090/126] KVM: x86/mmu: Protect TDP MMU page table memory with RCU [5.10,092/126] KVM: x86/mmu: Add comment on __tdp_mmu_set_spte [5.10,093/126] KVM: x86/mmu: Dont redundantly clear TDP MMU pt memory [5.10,095/126] KVM: x86/mmu: Factor out functions to add/remove TDP MMU pages [5.10,097/126] KVM: x86: compile out TDP MMU on 32-bit systems [5.10,098/126] KVM: x86/mmu: Ensure TLBs are flushed for TDP MMU during NX zapping [5.10,102/126] usb: dwc3: pci: Enable dis_uX_susphy_quirk for Intel Merrifield [5.10,103/126] video: hyperv_fb: Fix a double free in hvfb_probe [5.10,104/126] firewire: nosy: Fix a use-after-free bug in nosy_ioctl() [5.10,109/126] cdc-acm: fix BREAK rx code path adding necessary calls [5.10,110/126] USB: cdc-acm: untangle a circular dependency between callback and softint [5.10,113/126] USB: cdc-acm: fix use-after-free after probe failure [5.10,114/126] usb: gadget: udc: amd5536udc_pci fix null-ptr-dereference [5.10,117/126] usb: dwc3: qcom: skip interconnect init for ACPI probe [5.10,118/126] usb: dwc3: gadget: Clear DEP flags after stop transfers in ep disable [5.10,119/126] soc: qcom-geni-se: Cleanup the code to remove proxy votes [5.10,121/126] staging: rtl8192e: Change state information from u16 to u8 [5.10,124/126] riscv: evaluate put_user() arg before enabling user access [5.10,126/126] bpf: Use NOP_ATOMIC5 instead of emit_nops(&prog, 5) for BPF_TRAMP_F_CALL_ORIG

Commit Message

Greg KH April 5, 2021, 8:53 a.m. UTC

From: Pan Bian <bianpan2016@163.com>

commit 69c3ed7282a143439bbc2d03dc00d49c68fcb629 upstream.

Put DRM device on initialization failure path rather than directly
return error code.

Fixes: a67d5088ceb8 ("drm/imx: drop explicit drm_mode_config_cleanup")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/gpu/drm/imx/imx-drm-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
index d1a9841adeed..e6a88c8cbd69 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -215,7 +215,7 @@  static int imx_drm_bind(struct device *dev)
 
 	ret = drmm_mode_config_init(drm);
 	if (ret)
-		return ret;
+		goto err_kms;
 
 	ret = drm_vblank_init(drm, MAX_CRTC);
 	if (ret)