From patchwork Mon Mar 15 13:57:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 400450 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp3454183jai; Mon, 15 Mar 2021 07:09:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMD5XJ4h21A6YpJdZtiv0DNQO9SRSQEVm9kF0tAuExoLBT2gSQ0Pu9W961Yuv6BfBEke2Q X-Received: by 2002:a17:906:af97:: with SMTP id mj23mr24387900ejb.419.1615817372675; Mon, 15 Mar 2021 07:09:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615817372; cv=none; d=google.com; s=arc-20160816; b=GEinHYtdg4v3hAhK/9WKYodj+WVOUz15IDu41+vFNl+JdX7eKy1g9O88wwb+LlHXS3 RegezdDVxs2MCIs8GnSXPDtB6+RcFtyrN+zP0IGRiNftf3svECRP8T/ap1snAHAQcDGm 3FG46Uk+FAunFR1l4+8TbF+y45Eci1PfFVQBAH72NohmhWNmN2p5NlLsEUzbURP3jI6J NOwMIO5wGdblTLGtRZF8z9CvEdy9TZjduP5/6HQ68MDRAeYZvd0PSDTEvES7gB5gBNKM clNZCqf/j6ehEOvyOuRrV7bLxdxcqgl9MIJ14m25585DKwwQ179+jdPO+gAi9Kx2EFbS 13DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7JKOHC6cjZp3il6kvC32N0y9ynggQLP35iI01auiJQI=; b=NQqOpV0SiGtWHCAwNpm7fAksas9CPrRi49AagUAxhMndUMyK526CzJno706pFSmL1J /QdDrme71GI3sLAkzgSvOmzzoG6532IZOgGLloja22ZHnFgTfmX8xNCntP1i/KZ6Jcxk N8nWvE1ie78wPtps6lC3JS3Ge+Tyc69VBSB897Km29FZoLhLwk2JVFRSc6H5E+4w7eKE gohbie876zVWZCWkrRJQdCNFRZh9JAlqmn60Wzx1a1jy/A2OLbIoBSBMjQAL2EOnS+px DZvR6SPIndwwkDC62eCZwJwrV+8yS9CIUJRS8C8EpHAMlNZlJdSjDoZFmUKmQzS80qEi Oxng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="OzGR/V/a"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h21si993553ede.37.2021.03.15.07.09.32; Mon, 15 Mar 2021 07:09:32 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="OzGR/V/a"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233939AbhCOOEI (ORCPT + 12 others); Mon, 15 Mar 2021 10:04:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:37670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233083AbhCOOAh (ORCPT ); Mon, 15 Mar 2021 10:00:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5544464F5B; Mon, 15 Mar 2021 14:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615816823; bh=F7ooJGIPfcpYwlEUhOQ2t4Gu4YpBSugLrYGOn/zF/y4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OzGR/V/a7sGLgTdq/4oCR4g+Tp6jrUwlAY8jsx357vfnFzIJuDvY5Ao2b6JmmNEPX BfMMmkeVuL6CYadOjJqa/udD1yzL/0aC1K+xhAEdS1gCQJCmzjGXPzsQyuTOiYlCAP QX1pXpmGB63fyDKqKbBZEEumLMXQAafGyYDB6KrI= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , Thomas Gleixner , Sebastian Andrzej Siewior , "Paul E. McKenney" , Ingo Molnar , Prarit Bhargava , Daniel Bristot de Oliveira , Peter Zijlstra , Valentin Schneider , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH 4.14 85/95] stop_machine: mark helpers __always_inline Date: Mon, 15 Mar 2021 14:57:55 +0100 Message-Id: <20210315135743.075174308@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210315135740.245494252@linuxfoundation.org> References: <20210315135740.245494252@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Greg Kroah-Hartman From: Arnd Bergmann [ Upstream commit cbf78d85079cee662c45749ef4f744d41be85d48 ] With clang-13, some functions only get partially inlined, with a specialized version referring to a global variable. This triggers a harmless build-time check for the intel-rng driver: WARNING: modpost: drivers/char/hw_random/intel-rng.o(.text+0xe): Section mismatch in reference from the function stop_machine() to the function .init.text:intel_rng_hw_init() The function stop_machine() references the function __init intel_rng_hw_init(). This is often because stop_machine lacks a __init annotation or the annotation of intel_rng_hw_init is wrong. In this instance, an easy workaround is to force the stop_machine() function to be inline, along with related interfaces that did not show the same behavior at the moment, but theoretically could. The combination of the two patches listed below triggers the behavior in clang-13, but individually these commits are correct. Link: https://lkml.kernel.org/r/20210225130153.1956990-1-arnd@kernel.org Fixes: fe5595c07400 ("stop_machine: Provide stop_machine_cpuslocked()") Fixes: ee527cd3a20c ("Use stop_machine_run in the Intel RNG driver") Signed-off-by: Arnd Bergmann Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Thomas Gleixner Cc: Sebastian Andrzej Siewior Cc: "Paul E. McKenney" Cc: Ingo Molnar Cc: Prarit Bhargava Cc: Daniel Bristot de Oliveira Cc: Peter Zijlstra Cc: Valentin Schneider Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- include/linux/stop_machine.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) -- 2.30.1 diff --git a/include/linux/stop_machine.h b/include/linux/stop_machine.h index 6d3635c86dbe..ccdaa8fd5657 100644 --- a/include/linux/stop_machine.h +++ b/include/linux/stop_machine.h @@ -138,7 +138,7 @@ int stop_machine_from_inactive_cpu(cpu_stop_fn_t fn, void *data, const struct cpumask *cpus); #else /* CONFIG_SMP || CONFIG_HOTPLUG_CPU */ -static inline int stop_machine_cpuslocked(cpu_stop_fn_t fn, void *data, +static __always_inline int stop_machine_cpuslocked(cpu_stop_fn_t fn, void *data, const struct cpumask *cpus) { unsigned long flags; @@ -149,14 +149,15 @@ static inline int stop_machine_cpuslocked(cpu_stop_fn_t fn, void *data, return ret; } -static inline int stop_machine(cpu_stop_fn_t fn, void *data, - const struct cpumask *cpus) +static __always_inline int +stop_machine(cpu_stop_fn_t fn, void *data, const struct cpumask *cpus) { return stop_machine_cpuslocked(fn, data, cpus); } -static inline int stop_machine_from_inactive_cpu(cpu_stop_fn_t fn, void *data, - const struct cpumask *cpus) +static __always_inline int +stop_machine_from_inactive_cpu(cpu_stop_fn_t fn, void *data, + const struct cpumask *cpus) { return stop_machine(fn, data, cpus); }