From patchwork Wed Mar 10 13:23:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 396724 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp376983jai; Wed, 10 Mar 2021 05:31:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJwSfGNIqTYL5pKNsNnvFh733JyqZ5Z8eoBGrlTM0hkhqlTe/h4hszcMAIWkAmI7/pClhLrh X-Received: by 2002:a05:6402:646:: with SMTP id u6mr3326886edx.250.1615382731556; Wed, 10 Mar 2021 05:25:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615382731; cv=none; d=google.com; s=arc-20160816; b=aUQCubLq16phkORMXfXTvsBSd8VP/GyW7aVkvWNLSxOB9PNE2h/9Yg+zZwxRg8SZeR oNsJWxFipdQy7nUxr6pNmrU+fs+NYo4xABHG5EqM5SMHNsFWN9dboiaeNpCAZqynUqox ZgeveIO/ZOiLDvwioW6Q4hS1l5ZJpN/SPvlRS0Q3aQRpifI6IxGwA9ym/vY5ZnKk3Cqk 2zCl2XnHMZsULixX5vhJAuwi0XmdbLnfQ2wynEYlgN6nzER4cTvkhRrIE8uFFba8WnKv +QVjbzdO5vqXqh2a+QTleiyRTtnZLDA5+LfpGWeYi0kxXfILnKibVu3PzbF6UNLnmOfI MkSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=e3Y0IjNEbRfk6XZMVElN1bt77k9NWZ9scWz0bXExiqg=; b=iKlcshZChv1kUOA34Gm8LJaq0oyY6kgzBJznAIL05badBhes2ynS966M2p95c16td2 cu+gcfibQsAMvrud6k92iunZdmPdZ/flQf7FEdpV4mGNwQ05+49EpM7K1EJE3rBpFjUv wi5HTBqwJvVrbBc6APvqFbpvH1v6KBn6acq0Qe+LiYQ4SrTCADYek3oqXPLmE3i1c8U2 0sXuE/u/rIdjYplLRCnmKmyKFac5ud5DpYmw01p5N8ZMoYpRV3Aeqb88sXS2hbZUhv+D RY2+pwLL0NxPeaGlN3B7jsYcFeAGNmZAF0yMFJXBAr05k3Nv/j6cJY942kBSJBoW4TvM bchA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ze2dN8wH; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b13si12018421edt.436.2021.03.10.05.25.31; Wed, 10 Mar 2021 05:25:31 -0800 (PST) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ze2dN8wH; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233062AbhCJNYu (ORCPT + 12 others); Wed, 10 Mar 2021 08:24:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:45680 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232832AbhCJNYc (ORCPT ); Wed, 10 Mar 2021 08:24:32 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0369D64FEF; Wed, 10 Mar 2021 13:24:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615382672; bh=SrpHNz+9s1NbwOcx1sv9lILKLb86ARnZkK3UFGGccyI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ze2dN8wHr5y9WeVrxl3TCrcEhxoGB4uBTzTFS0G0jGvTs10tD2b9xohnhJ/Se1gfS pekZRWQuLeIasvUy2DNxeePc+X0UMKh9RoCMXFyQTGHv98fafnFyAxXrpyQOqpJxJ4 RSqdwgRbvdvlpQTcce9xR/Ln/H2Znl+wbq3S9nWg= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alex Elder , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 14/49] net: ipa: ignore CHANNEL_NOT_RUNNING errors Date: Wed, 10 Mar 2021 14:23:25 +0100 Message-Id: <20210310132322.413240905@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210310132321.948258062@linuxfoundation.org> References: <20210310132321.948258062@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Greg Kroah-Hartman From: Alex Elder [ Upstream commit f849afcc8c3b27d7b50827e95b60557f24184df0 ] IPA v4.2 has a hardware quirk that requires the AP to allocate GSI channels for the modem to use. It is recommended that these modem channels get stopped (with a HALT generic command) by the AP when its IPA driver gets removed. The AP has no way of knowing the current state of a modem channel. So when the IPA driver issues a HALT command it's possible the channel is not running, and in that case we get an error indication. This error simply means we didn't need to stop the channel, so we can ignore it. This patch adds an explanation for this situation, and arranges for this condition to *not* report an error message. Signed-off-by: Alex Elder Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ipa/gsi.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) -- 2.30.1 Reported-by: Linux Kernel Functional Testing diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c index 2a65efd3e8da..48ee43b89fec 100644 --- a/drivers/net/ipa/gsi.c +++ b/drivers/net/ipa/gsi.c @@ -1052,10 +1052,32 @@ static void gsi_isr_gp_int1(struct gsi *gsi) u32 result; u32 val; + /* This interrupt is used to handle completions of the two GENERIC + * GSI commands. We use these to allocate and halt channels on + * the modem's behalf due to a hardware quirk on IPA v4.2. Once + * allocated, the modem "owns" these channels, and as a result we + * have no way of knowing the channel's state at any given time. + * + * It is recommended that we halt the modem channels we allocated + * when shutting down, but it's possible the channel isn't running + * at the time we issue the HALT command. We'll get an error in + * that case, but it's harmless (the channel is already halted). + * + * For this reason, we silently ignore a CHANNEL_NOT_RUNNING error + * if we receive it. + */ val = ioread32(gsi->virt + GSI_CNTXT_SCRATCH_0_OFFSET); result = u32_get_bits(val, GENERIC_EE_RESULT_FMASK); - if (result != GENERIC_EE_SUCCESS_FVAL) + + switch (result) { + case GENERIC_EE_SUCCESS_FVAL: + case GENERIC_EE_CHANNEL_NOT_RUNNING_FVAL: + break; + + default: dev_err(gsi->dev, "global INT1 generic result %u\n", result); + break; + } complete(&gsi->completion); }