From patchwork Mon Mar 1 16:14:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 388658 Delivered-To: patch@linaro.org Received: by 2002:a02:290e:0:0:0:0:0 with SMTP id p14csp3518106jap; Mon, 1 Mar 2021 09:01:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJwIF6VhubHI7hlT3M7wYtGIH1sdBiRxKHZbVwoeO6Tjgko2HAp5R0iAFBmRITcEk8+SdewM X-Received: by 2002:a17:907:2d93:: with SMTP id gt19mr16644900ejc.246.1614618062677; Mon, 01 Mar 2021 09:01:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614618062; cv=none; d=google.com; s=arc-20160816; b=PRBsqvJ3JpGba0zmvGjq9W/QthNNQ+3rsxtepnvLj44/5yObSN1yGtrldwN03f2Zxp notFfh58N5Vhywtqn9KsVECvd1XSLJuQd0VspkJplJoKk+vubxhYO8SOGlBlR07oeUKr I3NGzwUwHyp1LVAn4jF2K7LrMc0sAFaG16vaCqu5TRwnKWoj30DwNCH1NJZZGiNVBJty 8owVmDzEgQA1ab+f1PUri3Ur7r/fYkVKpiJ0dygpiRHmaeN4gsNJR/LkCr8cM1M+RIQz OzB4WnFCAgY4UUh+yKxctxdFTO73hvyJnW60nbbcDCRfewn68IxBvBR3C6zGh4BNTKGo vVbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EcICfcfPwxH6B4+Bja7Qr18XhbsdAjazlSRmRF7LQ7o=; b=0xAq+uYNKCan8m8x07RXCrZgqPEg8qAShnYCS7kAk90kD7EPkb/rbuhfVbu9vwnTsw cBYaNiea9j++dD+jCs7ckJnquYTXVtY+kEO9ecWPRLthGNNrDWjcgD7PQn/oCRBRR1bW PJvOPlDIYbPXrB4rM09dssnx1wdyflSzP7Pm8idOYr+HMRKtodhH1bNh/FZ00QcS19hc 8omJfcnzbD1t2JZg7dNs7Mu87Hm1om87StnY+a+6CfHuLNllcWt0n4nCUWsTOXG2OpjC LV4o/siM7jWVLydtQ15pAjsf2R1p9VtmBRwwcK+EvHEyKLUQH6umvX6zFVXk37qd7MuU AbQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=w14vIZbA; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t3si11764443eds.511.2021.03.01.09.01.02; Mon, 01 Mar 2021 09:01:02 -0800 (PST) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=w14vIZbA; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236488AbhCARAi (ORCPT + 13 others); Mon, 1 Mar 2021 12:00:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:54174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236404AbhCAQyE (ORCPT ); Mon, 1 Mar 2021 11:54:04 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2824564FC1; Mon, 1 Mar 2021 16:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614616493; bh=qlN6aSjYOdN8CSB3OeHLQN8lVTjIVBG/rzVjxGpX/xw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=w14vIZbAMJ06NqXZpN+iMX0gtKok6EADFas7gVLZC7LPPO7dMoW1uaK8uVi/s1xqJ rpa/mzSo/zvKBWFv4csLFtcRk6mNne9C06apS+o0NOFpgFI6lkSB3kJJZioPIT+V3E oS7f8+LOjTs7QtOegoXPKNsQCaAc2qXqT2OnPr+o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Jason A. Donenfeld" , Harald Welte , "David S. Miller" Subject: [PATCH 4.14 171/176] gtp: use icmp_ndo_send helper Date: Mon, 1 Mar 2021 17:14:04 +0100 Message-Id: <20210301161029.525053029@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210301161020.931630716@linuxfoundation.org> References: <20210301161020.931630716@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jason A. Donenfeld commit e0fce6f945a26d4e953a147fe7ca11410322c9fe upstream. Because gtp is calling icmp from network device context, it should use the ndo helper so that the rate limiting applies correctly. Signed-off-by: Jason A. Donenfeld Cc: Harald Welte Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/gtp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -550,8 +550,8 @@ static int gtp_build_skb_ip4(struct sk_b mtu < ntohs(iph->tot_len)) { netdev_dbg(dev, "packet too big, fragmentation needed\n"); memset(IPCB(skb), 0, sizeof(*IPCB(skb))); - icmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED, - htonl(mtu)); + icmp_ndo_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED, + htonl(mtu)); goto err_rt; }