diff mbox series

[4.4,28/28] NFC: fix possible resource leak

Message ID	20210202132942.311729993@linuxfoundation.org
State	Superseded
Headers	show Return-Path: <stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Pan Bian <bianpan2016@163.com>, Jakub Kicinski <kuba@kernel.org> Subject: [PATCH 4.4 28/28] NFC: fix possible resource leak Date: Tue, 2 Feb 2021 14:38:48 +0100 Message-Id: <20210202132942.311729993@linuxfoundation.org> In-Reply-To: <20210202132941.180062901@linuxfoundation.org> References: <20210202132941.180062901@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	None \| expand [4.4,02/28] wext: fix NULL-ptr-dereference with cfg80211s lack of commit() [4.4,03/28] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family [4.4,04/28] KVM: x86/pmu: Fix HW_REF_CPU_CYCLES event pseudo-encoding in intel_arch_events[] [4.4,05/28] mt7601u: fix kernel crash unplugging the device [4.4,06/28] mt7601u: fix rx buffer refcounting [4.4,07/28] y2038: futex: Move compat implementation into futex.c [4.4,08/28] futex: Move futex exit handling into futex code [4.4,09/28] futex: Replace PF_EXITPIDONE with a state [4.4,10/28] exit/exec: Seperate mm_release() [4.4,11/28] futex: Split futex_mm_release() for exit/exec [4.4,12/28] futex: Set task::futex_state to DEAD right after handling futex exit [4.4,13/28] futex: Mark the begin of futex exit explicitly [4.4,14/28] futex: Sanitize exit state handling [4.4,15/28] futex: Provide state handling for exec() as well [4.4,16/28] futex: Add mutex around futex exit [4.4,17/28] futex: Provide distinct return value when owner is exiting [4.4,18/28] futex: Prevent exit livelock [4.4,19/28] ARM: imx: build suspend-imx6.S with arm instruction set [4.4,20/28] netfilter: nft_dynset: add timeout extension to template [4.4,21/28] xfrm: Fix oops in xfrm_replay_advance_bmp [4.4,22/28] RDMA/cxgb4: Fix the reported max_recv_sge value [4.4,23/28] mac80211: pause TX while changing interface type [4.4,24/28] can: dev: prevent potential information leak in can_fill_info() [4.4,25/28] iommu/vt-d: Gracefully handle DMAR units with no supported address widths [4.4,26/28] iommu/vt-d: Dont dereference iommu_device if IOMMU_API is not built [4.4,27/28] NFC: fix resource leak when target index is invalid [4.4,28/28] NFC: fix possible resource leak

Commit Message

Greg Kroah-Hartman Feb. 2, 2021, 1:38 p.m. UTC

From: Pan Bian <bianpan2016@163.com>

commit d8f923c3ab96dbbb4e3c22d1afc1dc1d3b195cd8 upstream.

Put the device to avoid resource leak on path that the polling flag is
invalid.

Fixes: a831b9132065 ("NFC: Do not return EBUSY when stopping a poll that's already stopped")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Link: https://lore.kernel.org/r/20210121153745.122184-1-bianpan2016@163.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 net/nfc/netlink.c |    1 +
 1 file changed, 1 insertion(+)

diff mbox series

Patch

--- a/net/nfc/netlink.c
+++ b/net/nfc/netlink.c
@@ -850,6 +850,7 @@  static int nfc_genl_stop_poll(struct sk_
 
 	if (!dev->polling) {
 		device_unlock(&dev->dev);
+		nfc_put_device(dev);
 		return -EINVAL;
 	}