From patchwork Fri Jan 15 12:27:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 363611 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp274121jap; Fri, 15 Jan 2021 05:05:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1VvqymHjPWmaM6BZ6CaRirx33up5LoMVF6ymDgUd8XN9sCPv5dawy32NGMkcmFh3SXcDW X-Received: by 2002:a17:906:3a99:: with SMTP id y25mr8526775ejd.349.1610715913359; Fri, 15 Jan 2021 05:05:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610715913; cv=none; d=google.com; s=arc-20160816; b=N+f5m8PFOjmEa0+2oR2ZQ2lVgk0dBnxWBokC1QVbhCcM8kQ9KmtxyVLUVP/TaCD+NE 09MU39efoEQ6bSGi1zmstc7PVoc0wav7XoIwAkMr1HEPFmdDaT2xOnXzmsFRU9alZRLc kWZ8Y9u++u2PGr6eNFlc9svxZsKj020UVsmMlVBGhUZbDPihnGmL3CIhALPHrYR23RRA iqQZGQzrMtJjVforeOD/PbJJxxae++vAsPaLUy6lhdeS+XFvFqeg+jEcAkPIx/9f2Qbz uFx2q6hMBAZiYz3lqDL7gemvCyOwQJFrypV2BKTsQVIpOYWpuQEZdulvQU6MjMJdTZwc I4ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VFgOjYm70R9C4S/gcv43HfZKtShzQURDCdw5EywvmQE=; b=NzaQVH3eKXezKHl0g8WJkvA7x2sWlcaAUX1iO0/2+doVIEYxyOtsqON+epDU9OlIAn S/X2MCTcpZ8mJ1CO2EO5WGC9/xBAEx8ms4PloNatgFnL88GJEAey34i0p9jYj/khWPuS A5KtzavtKr/6eG+AmJMEaEoynW/YOrhh0ekXmCw7l6kHgDIza8U1zm4ldqLkWVvW+FjV y76K6RnLlSbHV2eETQF+CbgWHLb2Cb0Lw1bsXQsPlosj6pdr1INAFfUgRncPuHZsy5KL cTdrn5tQAK6PnRsQZ1tNN0pJBKqKixuAwdtdyBSXWUvsv/L/3B2xQXtAsUc6h0w9OmFf Pw0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aJIWbjFK; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f7si4452979edd.343.2021.01.15.05.05.12; Fri, 15 Jan 2021 05:05:13 -0800 (PST) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aJIWbjFK; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728641AbhAONDq (ORCPT + 13 others); Fri, 15 Jan 2021 08:03:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:36412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732814AbhAOMbr (ORCPT ); Fri, 15 Jan 2021 07:31:47 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B4ED6223E0; Fri, 15 Jan 2021 12:31:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1610713892; bh=ywoUHKCi0smieEK+SvYseF8rMMCIbmHFRL9jbMC+D4M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aJIWbjFKwlDG/dwVJAxsfYiByB6I0wuI4eEogxDSUuHnQnGzn2j8EDSGSwbWzVo4N DRGqW2GyXR7MBy1+HhMgRZQ/cdRGjRjPyJXMcQP/8FMlW6DdO2GcYc6W828tQKtwA2 uZ4GAUJyzroWciNh3lwdWITG36QVkhRsqbgEDhVA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jian Cai , =?utf-8?b?RsSBbmctcnXDrCBTw7JuZw==?= , Nick Desaulniers , Kees Cook , Ingo Molnar , Luis Lozano , Manoj Gupta , linux-arch@vger.kernel.org, Nathan Chancellor Subject: [PATCH 4.14 08/28] vmlinux.lds.h: Add PGO and AutoFDO input sections Date: Fri, 15 Jan 2021 13:27:45 +0100 Message-Id: <20210115121957.158347707@linuxfoundation.org> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210115121956.731354372@linuxfoundation.org> References: <20210115121956.731354372@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Nick Desaulniers commit eff8728fe69880d3f7983bec3fb6cea4c306261f upstream. Basically, consider .text.{hot|unlikely|unknown}.* part of .text, too. When compiling with profiling information (collected via PGO instrumentations or AutoFDO sampling), Clang will separate code into .text.hot, .text.unlikely, or .text.unknown sections based on profiling information. After D79600 (clang-11), these sections will have a trailing `.` suffix, ie. .text.hot., .text.unlikely., .text.unknown.. When using -ffunction-sections together with profiling infomation, either explicitly (FGKASLR) or implicitly (LTO), code may be placed in sections following the convention: .text.hot., .text.unlikely., .text.unknown. where , , and are functions. (This produces one section per function; we generally try to merge these all back via linker script so that we don't have 50k sections). For the above cases, we need to teach our linker scripts that such sections might exist and that we'd explicitly like them grouped together, otherwise we can wind up with code outside of the _stext/_etext boundaries that might not be mapped properly for some architectures, resulting in boot failures. If the linker script is not told about possible input sections, then where the section is placed as output is a heuristic-laiden mess that's non-portable between linkers (ie. BFD and LLD), and has resulted in many hard to debug bugs. Kees Cook is working on cleaning this up by adding --orphan-handling=warn linker flag used in ARCH=powerpc to additional architectures. In the case of linker scripts, borrowing from the Zen of Python: explicit is better than implicit. Also, ld.bfd's internal linker script considers .text.hot AND .text.hot.* to be part of .text, as well as .text.unlikely and .text.unlikely.*. I didn't see support for .text.unknown.*, and didn't see Clang producing such code in our kernel builds, but I see code in LLVM that can produce such section names if profiling information is missing. That may point to a larger issue with generating or collecting profiles, but I would much rather be safe and explicit than have to debug yet another issue related to orphan section placement. Reported-by: Jian Cai Suggested-by: Fāng-ruì Sòng Signed-off-by: Nick Desaulniers Signed-off-by: Kees Cook Signed-off-by: Ingo Molnar Tested-by: Luis Lozano Tested-by: Manoj Gupta Acked-by: Kees Cook Cc: linux-arch@vger.kernel.org Cc: stable@vger.kernel.org Link: https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=add44f8d5c5c05e08b11e033127a744d61c26aee Link: https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=1de778ed23ce7492c523d5850c6c6dbb34152655 Link: https://reviews.llvm.org/D79600 Link: https://bugs.chromium.org/p/chromium/issues/detail?id=1084760 Link: https://lore.kernel.org/r/20200821194310.3089815-7-keescook@chromium.org Debugged-by: Luis Lozano [nc: Resolve small conflict due to lack of NOINSTR_TEXT] Signed-off-by: Nathan Chancellor Signed-off-by: Greg Kroah-Hartman --- include/asm-generic/vmlinux.lds.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -459,7 +459,10 @@ */ #define TEXT_TEXT \ ALIGN_FUNCTION(); \ - *(.text.hot TEXT_MAIN .text.fixup .text.unlikely) \ + *(.text.hot .text.hot.*) \ + *(TEXT_MAIN .text.fixup) \ + *(.text.unlikely .text.unlikely.*) \ + *(.text.unknown .text.unknown.*) \ *(.text..refcount) \ *(.ref.text) \ MEM_KEEP(init.text) \