From patchwork Mon Dec 28 12:43:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 352701 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp9818015jai; Mon, 28 Dec 2020 07:11:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJwXgj4HUbWIE5mNDrqQsGXuGfxPX7Sb6KjVO3jeEp0nW0+nRugsdOflFzA40iknBvvaxfjy X-Received: by 2002:a05:6402:a45:: with SMTP id bt5mr42661134edb.130.1609168208256; Mon, 28 Dec 2020 07:10:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609168208; cv=none; d=google.com; s=arc-20160816; b=QPjou1XPkmx0t3+bpWKVRo+me7hu/teSjbWijAWv0kFPSNKraSZ36gQ0VbYQkpKl3B cHOHTTs7R3vDo83ynczt4fPWicPPZt0nl7JGpOs1FrjYTh6Cwp6f6WZK1032/lB3vFZp mxQzq4/1/le80NMGlAdYjzkQcVTD7L4kPTMEaXAaRrRfKYtPuNTksdc6yhMp5lO/sQco Lw2vTO/7RGYqCfu3quD1BdW0TzzbUrUDcuqdookdUm8/Nm1Xdy3Wa6wNe+P4un8JpCuW eV21Gp5MyzAh50mupiypmD72O81+u9PGQ1RBqMy3Mc2C7MQUsiTe1Xzk7I1EMT64RMZs Xj6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZY0Ul9KPXbYG/mZKF5vgwquX9oP5QqUdWGkH3qwYq80=; b=xa89/0YCjPHjflGOFMXGH7bVyxzeA1xProVWHoKqqulFxIPB1Q2pHIEasBWCJG3Pv5 Slf3b5KwfZxf1M1KGKgJLZw6A+JeAlapQ6X99mJrRwnaIDjKNSjbfXEVsIDyYh/L2bqm 3xIBLw5Vmf3t57r1gTrnKa9B0crLqsExByjewljAAH+vDQ0SxfO8Mb2sGMJjTinJEFoY mKruz9Ia5JTs85tGSoqT9uyEAewmoMbrvlMRJurNq7fSXne5sba/S6UIOP0sYcr7PS5F R0u5I1koIMQUeq6JYHBxIb8B1abvZpdbAR9jyKcu+8vhSlWEsABkkWlUfIaMhqlnuWzC EG3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=e7DXPCQQ; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e20si18577079edr.131.2020.12.28.07.10.08; Mon, 28 Dec 2020 07:10:08 -0800 (PST) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=e7DXPCQQ; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439677AbgL1OLb (ORCPT + 14 others); Mon, 28 Dec 2020 09:11:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:46058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439512AbgL1OL2 (ORCPT ); Mon, 28 Dec 2020 09:11:28 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7B642207A9; Mon, 28 Dec 2020 14:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609164648; bh=J12to/b1ZegGF+C7OgBY73xF6OEWxa02Es72ZyGg+x0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e7DXPCQQeQrNoeOU9A17PFRB5HIatFjfDQnRQA+beIsOki3y5nvYW6EcF2F53ATQx j5quq61pAj+kpKHf8x2NjkJ05pQh0u8MiaFpEAlRfaQPCMFHOUFDuhOqV/IG/0gepA hIVD4CofpOBDC1Gdu4tPMdeTIsBITUDmUzkdBj3E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, kernel test robot , Srinivas Kandagatla , Vinod Koul , Sasha Levin , Randy Dunlap Subject: [PATCH 5.10 208/717] soundwire: qcom: Fix build failure when slimbus is module Date: Mon, 28 Dec 2020 13:43:26 +0100 Message-Id: <20201228125030.945804613@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228125020.963311703@linuxfoundation.org> References: <20201228125020.963311703@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vinod Koul [ Upstream commit 47edc0104c61d609b0898a302267b7269d87a6af ] Commit 5bd773242f75 ("soundwire: qcom: avoid dependency on CONFIG_SLIMBUS") removed hard dependency on Slimbus for qcom driver but it results in build failure when: CONFIG_SOUNDWIRE_QCOM=y CONFIG_SLIMBUS=m drivers/soundwire/qcom.o: In function `qcom_swrm_probe': qcom.c:(.text+0xf44): undefined reference to `slimbus_bus' Fix this by using IS_REACHABLE() in driver which is recommended to be used with imply. Fixes: 5bd773242f75 ("soundwire: qcom: avoid dependency on CONFIG_SLIMBUS") Reported-by: kernel test robot Tested-by: Srinivas Kandagatla Reviewed-by: Srinivas Kandagatla Acked-by: Randy Dunlap # build-tested Link: https://lore.kernel.org/r/20201125055155.GD8403@vkoul-mobl Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/soundwire/qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.27.0 diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index fbca4ebf63e92..6d22df01f3547 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -799,7 +799,7 @@ static int qcom_swrm_probe(struct platform_device *pdev) data = of_device_get_match_data(dev); ctrl->rows_index = sdw_find_row_index(data->default_rows); ctrl->cols_index = sdw_find_col_index(data->default_cols); -#if IS_ENABLED(CONFIG_SLIMBUS) +#if IS_REACHABLE(CONFIG_SLIMBUS) if (dev->parent->bus == &slimbus_bus) { #else if (false) {