From patchwork Mon Dec 28 12:47:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 352637 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp9746739jai; Mon, 28 Dec 2020 05:29:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzWIoMfscBlQZQf2lSCYcFHZaKnbZGZT3gdfZau7F4wYlrQzSWJHf8LReS8OVibDcDyhU+P X-Received: by 2002:aa7:c5d6:: with SMTP id h22mr35863900eds.82.1609162048507; Mon, 28 Dec 2020 05:27:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609162048; cv=none; d=google.com; s=arc-20160816; b=UAWXbSC5Hbod6cjSl8CClbrYEKV45epcLhuVjFfKZTQKalPMkUcbCh1MwySD3TY+k8 t0bgmDq0hz1CoZHvVqloDjf9kVd1X6nOVhwgkbBkSmif2Izjbc2R5rQF+ts1tZF95KK5 iDI3tdWWecAbkh5YwbQkZl7SeMjKoPCZch1hFtOwgI1St6MBw2r8zveil2ryN2b8xG+W 1ajGRenaaYZ1pmOWp/S7cd0pS5vyVN2lVdxkYw+VgLhPJbZOOEeJfJjjbZd7H7SzCDBH 9iZDHiZUKvfuPlos4LiTrR+gtE7FW2182CvFuWzmZMJLyqcsQbMy2FLB32XNS4DJ6pCj VSmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VCrzqiFOM21og/AirNDJOgc237STvzBXtyuw3rDun0s=; b=P/ETIXrKFtzfjDmArtM+MMYNQy3evCkEb1FAHVuqYyECWRbVztupsnYlmBdR+1oFos jKy+S2E2G6Y8DSePOZWLmKEhnHumHQrgexkT/JfqvV0Aakl2VRaeuiAV0utF7QZE7dEj /q+8WwiS0cqbxk1x+4oF+mNSA1FHHrdtoczNXM4ggPqrZcPS2xEm6iV3BFT6wWHzM97+ fa2NFHzd0tUFTWwL4v5mvIf1UKheC8fg1Iv7qyQnNZx7SOQ+Y9EObxxUqjsoQDBBDHfi BrEd7Wpz44hdiAdSc8xLz668xtf7RXpHkKuggEgKSNw7b7Y0/xTY4rNCMTd4HnOh6aQA TbTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rBxtrpaA; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ho39si19307546ejc.745.2020.12.28.05.27.28; Mon, 28 Dec 2020 05:27:28 -0800 (PST) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rBxtrpaA; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388910AbgL1NZa (ORCPT + 14 others); Mon, 28 Dec 2020 08:25:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:54250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388907AbgL1NZ3 (ORCPT ); Mon, 28 Dec 2020 08:25:29 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C78DF22AAD; Mon, 28 Dec 2020 13:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609161888; bh=3cLwZCInZx++IO1sMxfgbSDeKbsAUbmDE/ERF4P4aqE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rBxtrpaAMcmx36lD1JIaO5lRUUp+D4cb5RxynvqUD6JZlJHsaFyDVEkQeOyok0GAs Nl4LvUtVBj8aCn9+PuujjRUUXDJDgLN6NhSIultU+0LgDcDs9e8xukZcqyi9APyaSd +Ej0zlcCwqBFrGZoGynCStwT7XiQqG4xu29dmzt0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Harry Wentland , Arnd Bergmann , Alex Deucher , Sasha Levin Subject: [PATCH 4.19 115/346] drm/amdgpu: fix build_coefficients() argument Date: Mon, 28 Dec 2020 13:47:14 +0100 Message-Id: <20201228124925.349182006@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228124919.745526410@linuxfoundation.org> References: <20201228124919.745526410@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit dbb60031dd0c2b85f10ce4c12ae604c28d3aaca4 ] gcc -Wextra warns about a function taking an enum argument being called with a bool: drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c: In function 'apply_degamma_for_user_regamma': drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c:1617:29: warning: implicit conversion from 'enum ' to 'enum dc_transfer_func_predefined' [-Wenum-conversion] 1617 | build_coefficients(&coeff, true); It appears that a patch was added using the old calling conventions after the type was changed, and the value should actually be 0 (TRANSFER_FUNCTION_SRGB) here instead of 1 (true). Fixes: 55a01d4023ce ("drm/amd/display: Add user_regamma to color module") Reviewed-by: Harry Wentland Signed-off-by: Arnd Bergmann Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.27.0 diff --git a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c index 11ea1a0e629bd..458e82da3c85b 100644 --- a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c +++ b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c @@ -1296,7 +1296,7 @@ static void apply_degamma_for_user_regamma(struct pwl_float_data_ex *rgb_regamma struct pwl_float_data_ex *rgb = rgb_regamma; const struct hw_x_point *coord_x = coordinates_x; - build_coefficients(&coeff, true); + build_coefficients(&coeff, TRANSFER_FUNCTION_SRGB); i = 0; while (i != hw_points_num + 1) {