From patchwork Mon Dec 28 12:49:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 352750 Delivered-To: patch@linaro.org Received: by 2002:a17:906:4755:0:0:0:0 with SMTP id j21csp10024068ejs; Mon, 28 Dec 2020 08:21:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJwu03TriQKm3xHjVyAv8VMWQZ3ZkYz2TJxdCdx7elIyOXdegR2UY6gaFErpymz+nzMm9Sez X-Received: by 2002:a50:fc8b:: with SMTP id f11mr43059768edq.11.1609172511888; Mon, 28 Dec 2020 08:21:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609172511; cv=none; d=google.com; s=arc-20160816; b=pXOKyehbdSw+txkjZtT8GrY69tqEefdUOe3BGwtPHXvK1weyh99X4XStv3WWcWeMth x2Dbyz5uA3qKNoar29Zvjzg6ZuWDtVQFxK+Spbgb+J4SvbOzlJdEoq7p1WGS+83sK7ka DxWTONaRdH8KLtFFGV4tGqMMAUuuyMnFpyJYzKVbTe8ybwW+qOO4qGIuphjnlXDVfklv L1PJWCalXnSGKg/zvQnx+x+szzAbFj2rf3jahouA1JXVitCaUtesEIa7v8yQ6QAdL5IX 4gu8KIvJzhH/a2cLfKf2YBCgceNsFbzZ9nXU7aQNbQJ3Uy9nkqlALbrFmtmbwk33G+ZL iUeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=g7NicWkqOfkZ4eh5jKxQwZNlJT64QlBGiEd6WkHK88A=; b=Ou/SYoDB5C+yf3amf9Zo8FQOVrpaGXFicu67QkgzNNbbDdR0YQwJL+4V3NQMhp2r/E /jg7eNDSm1JP5swYYkrzgOSMnTszq8mS5sa1DWLRvF9GcGk/dSvzFic7yNqY3q5FouTQ QoOyTVV9h/1aY8JuCSKfVFiv2fbuwVOfAX/xFnOVxBapKtbUfNUlzr3/QDuEDedfvSPF NeifUOzzeMN1bTq90bOXCpudj9jnu2UyToHgk9dZwQACJ4mWnhv1VwUcRpkmdIYItfCd 0/OOppR/UVBf2vS3EV83Fb4wNLtHcA6HPG9vVjyPsaO++kWDa6nMUBFH5IKQ3rMxkRSb Dmkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kiJUsWQX; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v25si19960384edt.63.2020.12.28.08.21.51; Mon, 28 Dec 2020 08:21:51 -0800 (PST) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kiJUsWQX; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732393AbgL1NOG (ORCPT + 14 others); Mon, 28 Dec 2020 08:14:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:41930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732388AbgL1NOF (ORCPT ); Mon, 28 Dec 2020 08:14:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5F8CA2076D; Mon, 28 Dec 2020 13:13:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609161230; bh=9/u1tfMPEVt67nmI4SkUXtwtNr5voLRc4WjZV+Ess7c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kiJUsWQX0tp3ZvmGFiQrKwec0YSwMBWay15ASTF+zIrdGNOI0iSb6FrjK+utTgyO4 pSk7aO/cld3bOewI0+X0XcHZawqsnubh7dJ9mlxrSlRljLB5efZuukGNLWR1QafAlL zjdGMU8ETt1uHrhAecSBjlPKF3nooggJ2fZPp9yI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Cezary Rojewski , Arnd Bergmann , "Steven Rostedt (VMware)" , Sasha Levin Subject: [PATCH 4.14 146/242] seq_buf: Avoid type mismatch for seq_buf_init Date: Mon, 28 Dec 2020 13:49:11 +0100 Message-Id: <20201228124911.891869411@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228124904.654293249@linuxfoundation.org> References: <20201228124904.654293249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit d9a9280a0d0ae51dc1d4142138b99242b7ec8ac6 ] Building with W=2 prints a number of warnings for one function that has a pointer type mismatch: linux/seq_buf.h: In function 'seq_buf_init': linux/seq_buf.h:35:12: warning: pointer targets in assignment from 'unsigned char *' to 'char *' differ in signedness [-Wpointer-sign] Change the type in the function prototype according to the type in the structure. Link: https://lkml.kernel.org/r/20201026161108.3707783-1-arnd@kernel.org Fixes: 9a7777935c34 ("tracing: Convert seq_buf fields to be like seq_file fields") Reviewed-by: Cezary Rojewski Signed-off-by: Arnd Bergmann Signed-off-by: Steven Rostedt (VMware) Signed-off-by: Sasha Levin --- include/linux/seq_buf.h | 2 +- include/linux/trace_seq.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.27.0 diff --git a/include/linux/seq_buf.h b/include/linux/seq_buf.h index aa5deb041c25d..7cc952282e8be 100644 --- a/include/linux/seq_buf.h +++ b/include/linux/seq_buf.h @@ -30,7 +30,7 @@ static inline void seq_buf_clear(struct seq_buf *s) } static inline void -seq_buf_init(struct seq_buf *s, unsigned char *buf, unsigned int size) +seq_buf_init(struct seq_buf *s, char *buf, unsigned int size) { s->buffer = buf; s->size = size; diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h index 6609b39a72326..6db257466af68 100644 --- a/include/linux/trace_seq.h +++ b/include/linux/trace_seq.h @@ -12,7 +12,7 @@ */ struct trace_seq { - unsigned char buffer[PAGE_SIZE]; + char buffer[PAGE_SIZE]; struct seq_buf seq; int full; }; @@ -51,7 +51,7 @@ static inline int trace_seq_used(struct trace_seq *s) * that is about to be written to and then return the result * of that write. */ -static inline unsigned char * +static inline char * trace_seq_buffer_ptr(struct trace_seq *s) { return s->buffer + seq_buf_used(&s->seq);