From patchwork Mon Dec 28 12:49:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 352769 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp9882380jai; Mon, 28 Dec 2020 08:47:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwineRom1wIAyLRX4qv0yx3D6tO1en9OwrR2dCMVKYUOd5HSSiwR+n0ty1SGqsJsHV6JyWG X-Received: by 2002:a17:906:ae0c:: with SMTP id le12mr42635440ejb.283.1609174043842; Mon, 28 Dec 2020 08:47:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609174043; cv=none; d=google.com; s=arc-20160816; b=DeMB1zwrMDm4/Y6mVol09sv0qsi5vOTss9YtjDLpV/rxDSsIT3BnNnyIkGwLYJFb+u eo+GYJmrrPYH+O7nbmlOkKZ5N1V6OmPuF+12I5GfVc4ebfDIwIxjoGv2x96cozXk2JcE +poqnB/r3CRUsCIcSsE3ZP+fHWQBaDWj2ypZZEf/abp15V9/0vFWMvfIh2po9R/MH+93 T6howwhdJGxVk+scvGA3GgXeVq3UBQ1Bu7SSIku7klFtb+o0NLY+r5hbN7dD/biBz/C1 1CViGrJlSsCf87ZQxufDagSGF7jTmQEAFQF28ZK1nB2zNHlzrRd9vjFWSJjaLhvhydTq Y4FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=uucUfe2zCjocnN+wbSFCnhAlDVc71tqPEXLgwaeltH0=; b=TWjQeisenxTyewEazwLCxcA4oNgp0edm78LX42ZPsz4JFwahIMdZKilCPuQJvUHsoa sCPiOkTanulz2Iwxi2Udft79KBHOGbNC72g//jsvYEK6EtzFIj0kIBjD/3CKGIhLuZ4a YLxLKqMk0aEmhvXeEEFODPriE24wzTurGT527YIUI3NRRoXxIlGDZw0ci5FAMIiTaKP7 24Bqx5JvZpjAjSzT2nyZSZvjUrYUPqRHsnMAevC9RNICC2yRh0LSGusTIoCZucxgSPz8 rz30mMAS2BGCa5FIYj1tiGc1+V4vYVXLXqxVUOg3WL3mNHiF3nTxvI2Hrm1KWyyc4/kW TGoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aorKFlC3; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j24si19009964ejd.743.2020.12.28.08.47.23; Mon, 28 Dec 2020 08:47:23 -0800 (PST) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aorKFlC3; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728038AbgL1M4r (ORCPT + 14 others); Mon, 28 Dec 2020 07:56:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:52930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728165AbgL1M4q (ORCPT ); Mon, 28 Dec 2020 07:56:46 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4F18F22AAA; Mon, 28 Dec 2020 12:56:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609160191; bh=JevaJKgB0OQZVfFrtoZeKjvd2DOI6bStpsdjPtf2Kkk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aorKFlC3gdGDU+8lDPIuVE20lBOCaoRzf3fXl/+PxnY4pbWFafcjHF/YIzRDItUb3 RUoyIlCy+Um23HevUJ+7o0T/09eZT36TEDCe+uwP/eBFDu4B68Z3pfrk2SvRcJfM8i /4eepnWpJggCxcbt8I0OQdZWeRKS8ZLrLhFWpAhg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Dmitry Torokhov Subject: [PATCH 4.4 100/132] Input: cyapa_gen6 - fix out-of-bounds stack access Date: Mon, 28 Dec 2020 13:49:44 +0100 Message-Id: <20201228124851.248026763@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228124846.409999325@linuxfoundation.org> References: <20201228124846.409999325@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann commit f051ae4f6c732c231046945b36234e977f8467c6 upstream. gcc -Warray-bounds warns about a serious bug in cyapa_pip_retrieve_data_structure: drivers/input/mouse/cyapa_gen6.c: In function 'cyapa_pip_retrieve_data_structure.constprop': include/linux/unaligned/access_ok.h:40:17: warning: array subscript -1 is outside array bounds of 'struct retrieve_data_struct_cmd[1]' [-Warray-bounds] 40 | *((__le16 *)p) = cpu_to_le16(val); drivers/input/mouse/cyapa_gen6.c:569:13: note: while referencing 'cmd' 569 | } __packed cmd; | ^~~ Apparently the '-2' was added to the pointer instead of the value, writing garbage into the stack next to this variable. Fixes: c2c06c41f700 ("Input: cyapa - add gen6 device module support") Signed-off-by: Arnd Bergmann Link: https://lore.kernel.org/r/20201026161332.3708389-1-arnd@kernel.org Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/mouse/cyapa_gen6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/input/mouse/cyapa_gen6.c +++ b/drivers/input/mouse/cyapa_gen6.c @@ -573,7 +573,7 @@ static int cyapa_pip_retrieve_data_struc memset(&cmd, 0, sizeof(cmd)); put_unaligned_le16(PIP_OUTPUT_REPORT_ADDR, &cmd.head.addr); - put_unaligned_le16(sizeof(cmd), &cmd.head.length - 2); + put_unaligned_le16(sizeof(cmd) - 2, &cmd.head.length); cmd.head.report_id = PIP_APP_CMD_REPORT_ID; cmd.head.cmd_code = PIP_RETRIEVE_DATA_STRUCTURE; put_unaligned_le16(read_offset, &cmd.read_offset);