From patchwork Mon Dec 28 12:49:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 352617 Delivered-To: patch@linaro.org Received: by 2002:a17:906:4755:0:0:0:0 with SMTP id j21csp9875549ejs; Mon, 28 Dec 2020 04:56:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJyV1DGaMQT3Tqjg2zq6ZFzIipQBqZBpnODzdXY7bic3VufpWFJnRoyX1uUTOaEmBNwkVLuM X-Received: by 2002:a17:907:41e3:: with SMTP id nb3mr42200818ejb.378.1609160188478; Mon, 28 Dec 2020 04:56:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609160188; cv=none; d=google.com; s=arc-20160816; b=VD9SQGGD2CZHGDvpUvSYSQ5ILFwFh0j1leiqT6EQFnSh0R58VAo6H5ejH7c0fCgJ/W MP6lbRIlQGaGAiqxN9O0sZR45YZr7GEawx1bSdxqjJptFxEtW3NCeuKw1wyZS28+8fdw VAX+Gnfh/Q6o/ftySUIwBQnKfaMuG1zS/BxlnXppDqIMFlf/ta7N9Snu6+hdLmh6v3xa Qkt5MpnK5AH1mXyLan8Wotgsd9M1FmwQMdAekdJ3lijZ2w4t8cbrR/oBdLhTMIkN0yRt 8ncNCui0sJ5TAM3uxqqWacaq2QjAuRVlj6GTpHoUan5bUFi8wwzlGhpYmdyChmRDOe8l HJSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0jdoakZwgQv3SqTLPeDXt5uELCcsbiqIS6q8lAGNSlc=; b=nu0x56Y9XHCTG5BUqVVGGG9o3ATCs4rAF9Nfgje0i8wgOat6krlSRel+0TfSFx+48T yeWBhHTEbZpU38wGCK8JvSePP55u0v96O70UupxTYlUAhY3MFrC530HNgBVTRCT5fMic k3jxyr87vyY4gG34URi6vMtzgrLuKd1uVc70PhU76bITdjOxO/+Vle/YKXyn+BTjFrot YwqHewtpQCmMse6OH8cQ39PvoX7DLKJj+QroNIEX5XcDENFNrpEVQ2TAMH56bMzQpODs nS2NmK0fWP5tKLYcuiMdHugwLB+vDNYNBWpDMOEBtdFmzEPV/UI2IaSNeFHG3Yy1qyUo /G/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mVWJj6G9; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s15si19629413edw.158.2020.12.28.04.56.28; Mon, 28 Dec 2020 04:56:28 -0800 (PST) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mVWJj6G9; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728543AbgL1Mz2 (ORCPT + 14 others); Mon, 28 Dec 2020 07:55:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:51758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728535AbgL1Mz1 (ORCPT ); Mon, 28 Dec 2020 07:55:27 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0352A22573; Mon, 28 Dec 2020 12:55:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609160111; bh=ZDLuezUecvvZpYdnsZTEvnhf/rHrjafxsKalCchwpfU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mVWJj6G9qviJSfznKDuOvig00pEG/M4MpfrmjOSKoQgNmn5GGNDH/5U3ImwlYc+jv SkKMO4hyusZHt2pbk9A6dEksGjUSj7udhw+1tN0J3QDqR4pg14WsnnRN3P6UzCtI1Y dXSJKuzyKPUjbH5LJpCy8Dti66Q80Ypx18xHj8tg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Cezary Rojewski , Arnd Bergmann , "Steven Rostedt (VMware)" , Sasha Levin Subject: [PATCH 4.4 073/132] seq_buf: Avoid type mismatch for seq_buf_init Date: Mon, 28 Dec 2020 13:49:17 +0100 Message-Id: <20201228124849.968406302@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201228124846.409999325@linuxfoundation.org> References: <20201228124846.409999325@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit d9a9280a0d0ae51dc1d4142138b99242b7ec8ac6 ] Building with W=2 prints a number of warnings for one function that has a pointer type mismatch: linux/seq_buf.h: In function 'seq_buf_init': linux/seq_buf.h:35:12: warning: pointer targets in assignment from 'unsigned char *' to 'char *' differ in signedness [-Wpointer-sign] Change the type in the function prototype according to the type in the structure. Link: https://lkml.kernel.org/r/20201026161108.3707783-1-arnd@kernel.org Fixes: 9a7777935c34 ("tracing: Convert seq_buf fields to be like seq_file fields") Reviewed-by: Cezary Rojewski Signed-off-by: Arnd Bergmann Signed-off-by: Steven Rostedt (VMware) Signed-off-by: Sasha Levin --- include/linux/seq_buf.h | 2 +- include/linux/trace_seq.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.27.0 diff --git a/include/linux/seq_buf.h b/include/linux/seq_buf.h index fb7eb9ccb1cd4..d4c3c9bab5826 100644 --- a/include/linux/seq_buf.h +++ b/include/linux/seq_buf.h @@ -29,7 +29,7 @@ static inline void seq_buf_clear(struct seq_buf *s) } static inline void -seq_buf_init(struct seq_buf *s, unsigned char *buf, unsigned int size) +seq_buf_init(struct seq_buf *s, char *buf, unsigned int size) { s->buffer = buf; s->size = size; diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h index cfaf5a1d4bad7..f5be2716b01c6 100644 --- a/include/linux/trace_seq.h +++ b/include/linux/trace_seq.h @@ -11,7 +11,7 @@ */ struct trace_seq { - unsigned char buffer[PAGE_SIZE]; + char buffer[PAGE_SIZE]; struct seq_buf seq; int full; }; @@ -50,7 +50,7 @@ static inline int trace_seq_used(struct trace_seq *s) * that is about to be written to and then return the result * of that write. */ -static inline unsigned char * +static inline char * trace_seq_buffer_ptr(struct trace_seq *s) { return s->buffer + seq_buf_used(&s->seq);