From patchwork Fri Dec 11 21:36:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 341984 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp933157jai; Fri, 11 Dec 2020 13:39:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJwnoDy7T/0LQyx6GScQSTf8v5Sejfn4fHqUf1soTyepwd2chbjMSWIGEY5CEQ+UH9cFbq7a X-Received: by 2002:a17:906:ca47:: with SMTP id jx7mr13253705ejb.237.1607722750789; Fri, 11 Dec 2020 13:39:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607722750; cv=none; d=google.com; s=arc-20160816; b=DZY6EXxeosih65aCPih43e6+uIQmfZldZ4LR4XYlbE08uFBNGAIXXXD482sZbvqRhq bQFjVdUKseB6bHPb0kYKu70CJ7KxvgeeOz1kQSEc0HZ1wIOR1XAK9TbbNwTuSgzlRF14 hfNCpsAEqfN/ahCPDW1VUstAwTxYSHaZYaU/qhEQthRA3mYK4J4ua4qCVrQMpyZiXoEn ZulVqSWmOohz8OeGCE1SrVqxFBLTQdNAknzft8D5DaebGwFwKwi7FXfROqHlPVd/aj1m 7MP4/1UG6KCO3Gqr30HoF/sGO33zfaMRvXhdt22IxemVzEjTa6+7lz7Q5gKOAL+kXQkp Atew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:message-id:subject:to :from:dkim-signature:date; bh=6YUGoPk5cZ+t4ZpVHMJ61WzmiyMolzVKQDU1UFthmTE=; b=BVYiBJJ2ecjkUJTAjleeGUg6lRXsgibEiRQ88bcP0D3H3PqTA9vjCPWElWjU0Lava7 Mq8xJGyGve3q+IDXlOCHciK2PGHKK394fP0ZL/ZD1J3QAXXuzccYd1U/+fg4w7oq2u+I yaR1RdJyCOVEYxpoCqmcVVWvcACH8SXHgLBNE35TbLIFhUCBvDOLyV3nw2OxGcMwrR8J XcXOtsJKEBlFyrRcVgVPC2SfQkYZRTMiy8zFj16uRm2xdoVlb2bm/R1iIiOZ4OlnApOP 0iNJzZfaDB/JmSodbpb4Be4gFG6QV4B6LgqV6U+pdLO3Wux8LKbI2xbiWXYI4wqvEJ9N LhVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=CJ66+UyG; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dc22si6015112ejb.568.2020.12.11.13.39.10; Fri, 11 Dec 2020 13:39:10 -0800 (PST) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=CJ66+UyG; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405729AbgLKVh0 (ORCPT + 14 others); Fri, 11 Dec 2020 16:37:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:60904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391347AbgLKVhU (ORCPT ); Fri, 11 Dec 2020 16:37:20 -0500 Date: Fri, 11 Dec 2020 13:36:38 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1607722599; bh=Vql5KOdLOKsBXzP2w5ZiC+qjVWkaxgNf8DRqZZ8o81Q=; h=From:To:Subject:In-Reply-To:From; b=CJ66+UyGOg3XzYy/gi1PKYit4+7U8A9Ty8YTE88QtD19cNGEJQAZ6tBj7lG0yqbKx BO05d7uToJukoTHenflTliJi242O+cNJ6DqdqByntwtUwN6Zy/GyAyG0Mc3gGw4QY5 U2tDS9xpDFc4ec17q8hclOP785sl89Q4cYhWv47s= From: Andrew Morton To: akpm@linux-foundation.org, ardb@kernel.org, arnd@arndb.de, elver@google.com, keescook@chromium.org, linux-mm@kvack.org, masahiroy@kernel.org, michal.lkml@markovi.net, mm-commits@vger.kernel.org, rikard.falkeborn@gmail.com, stable@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 4/8] kbuild: avoid static_assert for genksyms Message-ID: <20201211213638.89W7IFB2b%akpm@linux-foundation.org> In-Reply-To: <20201211133555.88407977f082963499ed343c@linux-foundation.org> User-Agent: s-nail v14.8.16 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann Subject: kbuild: avoid static_assert for genksyms genksyms does not know or care about the _Static_assert() built-in, and sometimes falls back to ignoring the later symbols, which causes undefined behavior such as WARNING: modpost: EXPORT symbol "ethtool_set_ethtool_phy_ops" [vmlinux] version generation failed, symbol will not be versioned. ld: net/ethtool/common.o: relocation R_AARCH64_ABS32 against `__crc_ethtool_set_ethtool_phy_ops' can not be used when making a shared object net/ethtool/common.o:(_ftrace_annotated_branch+0x0): dangerous relocation: unsupported relocation Redefine static_assert for genksyms to avoid that. Link: https://lkml.kernel.org/r/20201203230955.1482058-1-arnd@kernel.org Signed-off-by: Arnd Bergmann Suggested-by: Ard Biesheuvel Cc: Masahiro Yamada Cc: Michal Marek Cc: Kees Cook Cc: Rikard Falkeborn Cc: Marco Elver Cc: Signed-off-by: Andrew Morton --- include/linux/build_bug.h | 5 +++++ 1 file changed, 5 insertions(+) --- a/include/linux/build_bug.h~kbuild-avoid-static_assert-for-genksyms +++ a/include/linux/build_bug.h @@ -77,4 +77,9 @@ #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr) #define __static_assert(expr, msg, ...) _Static_assert(expr, msg) +#ifdef __GENKSYMS__ +/* genksyms gets confused by _Static_assert */ +#define _Static_assert(expr, ...) +#endif + #endif /* _LINUX_BUILD_BUG_H */