From patchwork Mon Nov 23 12:22:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 330667 Delivered-To: patch@linaro.org Received: by 2002:a92:cc8a:0:0:0:0:0 with SMTP id x10csp3524386ilo; Mon, 23 Nov 2020 05:30:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJxMlNzRAm8qyUe7u7xmKkCPOwDzCMnJCb2OZYu8rBx02lJj+i7NY0Y8QipQHSCuovnFuaee X-Received: by 2002:a17:906:1159:: with SMTP id i25mr41322026eja.398.1606138220668; Mon, 23 Nov 2020 05:30:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606138220; cv=none; d=google.com; s=arc-20160816; b=SKMKEfD5Fk1+bRZRwZu+73ipI9H5IpT1abH0chTQdLJJ7DN+NWud48AZQVRFtXj6Ib Ejflx2ah5bnXaGcyLnOAbdndcz2C+1rvkm3xqTCwu9bgrwCgaHBU8irjywIvDnR0UuDg 5HNuU1oFZl6RHqUlQ39GUGbwry0U/EhXAGDJNRv8v0/l7A4EhPkzdnpk159fZj8otEdV GCXpw+729k+hkCeluypsyDW42uA2d7zUitLutE9+54QJNI5ciMDcWuehG8et6Z9vABtw rrsDDpItl5RDpDpv6EAeTo8dUbLZDftPSgKK+RpnGx8a+SAHTE7yhxjtqjymdV2Yee3X 4keQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=z810r4Hunwp9YSR8JFljdAKlR2GuuSVg04kUNbxDqWk=; b=FeY/rVd52CsPq5PMTDaP45Zi04BgO+2cyIzc0JjJkJX/Vy9p2efvsZIMwPK9E2/KTj O/WjrDnhfsIzalKHrg/OxSMWpcyt8D2mTRPflZHJIOmpo0hZwwA7bnm3cwRWv3lXVu/a 6KrPPzFY179kqgXzqAw2hiQyCNKMboOq4qX13fBydbLIKfUSEh5k26ncWSbJk1mZzzM+ TNdbNPdMYeFnuIM8L9bs+qenz6I7zOOzPlCzjfZnbEZxPGknsyma2uM42vGMRS6Yov7G vDyNKPJzzpuPtnNFxMP7NUoooDM+qMQID3sl8z1lc3O4eFYKdvrNBrvtvPJ1FVCIYWh8 9fyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mgpgwgyQ; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si4048174edt.371.2020.11.23.05.30.20; Mon, 23 Nov 2020 05:30:20 -0800 (PST) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mgpgwgyQ; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731176AbgKWN3b (ORCPT + 14 others); Mon, 23 Nov 2020 08:29:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:39576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730557AbgKWM3M (ORCPT ); Mon, 23 Nov 2020 07:29:12 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3824F20857; Mon, 23 Nov 2020 12:29:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1606134550; bh=9C04t6td35PERnm+wuWhRwmCe/SiCseSv+mLoF888oo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mgpgwgyQN3rNhJzx4EWbtQs51ecHye/r0QjUNfgtVCfNmVodsXywASJzwBgCXdZ5f UJUHzKyoLMAXzdeVKPoNUoetgDsdFxeVjKdyF0rLzDGf9M5XxccI5Ufk2y0UXd7S1W EgZo8qwEu72g0kZ5jHN9AQc/WObB6VKT6eTzfzzY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Joel Stanley , Jakub Kicinski Subject: [PATCH 4.14 20/60] net: ftgmac100: Fix crash when removing driver Date: Mon, 23 Nov 2020 13:22:02 +0100 Message-Id: <20201123121805.999528690@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201123121805.028396732@linuxfoundation.org> References: <20201123121805.028396732@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Joel Stanley [ Upstream commit 3d5179458d22dc0b4fdc724e4bed4231a655112a ] When removing the driver we would hit BUG_ON(!list_empty(&dev->ptype_specific)) in net/core/dev.c due to still having the NC-SI packet handler registered. # echo 1e660000.ethernet > /sys/bus/platform/drivers/ftgmac100/unbind ------------[ cut here ]------------ kernel BUG at net/core/dev.c:10254! Internal error: Oops - BUG: 0 [#1] SMP ARM CPU: 0 PID: 115 Comm: sh Not tainted 5.10.0-rc3-next-20201111-00007-g02e0365710c4 #46 Hardware name: Generic DT based system PC is at netdev_run_todo+0x314/0x394 LR is at cpumask_next+0x20/0x24 pc : [<806f5830>] lr : [<80863cb0>] psr: 80000153 sp : 855bbd58 ip : 00000001 fp : 855bbdac r10: 80c03d00 r9 : 80c06228 r8 : 81158c54 r7 : 00000000 r6 : 80c05dec r5 : 80c05d18 r4 : 813b9280 r3 : 813b9054 r2 : 8122c470 r1 : 00000002 r0 : 00000002 Flags: Nzcv IRQs on FIQs off Mode SVC_32 ISA ARM Segment none Control: 00c5387d Table: 85514008 DAC: 00000051 Process sh (pid: 115, stack limit = 0x7cb5703d) ... Backtrace: [<806f551c>] (netdev_run_todo) from [<80707eec>] (rtnl_unlock+0x18/0x1c) r10:00000051 r9:854ed710 r8:81158c54 r7:80c76bb0 r6:81158c10 r5:8115b410 r4:813b9000 [<80707ed4>] (rtnl_unlock) from [<806f5db8>] (unregister_netdev+0x2c/0x30) [<806f5d8c>] (unregister_netdev) from [<805a8180>] (ftgmac100_remove+0x20/0xa8) r5:8115b410 r4:813b9000 [<805a8160>] (ftgmac100_remove) from [<805355e4>] (platform_drv_remove+0x34/0x4c) Fixes: bd466c3fb5a4 ("net/faraday: Support NCSI mode") Signed-off-by: Joel Stanley Link: https://lore.kernel.org/r/20201117024448.1170761-1-joel@jms.id.au Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/faraday/ftgmac100.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/net/ethernet/faraday/ftgmac100.c +++ b/drivers/net/ethernet/faraday/ftgmac100.c @@ -1860,6 +1860,8 @@ static int ftgmac100_probe(struct platfo return 0; err_ncsi_dev: + if (priv->ndev) + ncsi_unregister_dev(priv->ndev); err_register_netdev: ftgmac100_destroy_mdio(netdev); err_setup_mdio: @@ -1880,6 +1882,8 @@ static int ftgmac100_remove(struct platf netdev = platform_get_drvdata(pdev); priv = netdev_priv(netdev); + if (priv->ndev) + ncsi_unregister_dev(priv->ndev); unregister_netdev(netdev); /* There's a small chance the reset task will have been re-queued,