From patchwork Sat Oct 31 11:36:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 317348 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D0EBC4742C for ; Sat, 31 Oct 2020 11:50:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63A012065D for ; Sat, 31 Oct 2020 11:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604145030; bh=/eWSMNuw7hAI76MfM3ORRrqREp2ulmo2HGI74xNA2bA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wuWHl5/CNSreR3AbYGJT36BU6A9/EjyJu9ZHz7AeEx6nkyuOU/Lu78fnA/87l+LI3 XDY7CexM+aSGuKAofO0MsMY40jYQ9XKJ5ApT+F5WiL5UV/eoFYnJlSIaEruID85BM3 Exf157arKGaAqf4bAcLd32CBKWn3LuEyf4Dl8GoY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727265AbgJaLuR (ORCPT ); Sat, 31 Oct 2020 07:50:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:40528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727673AbgJaLl1 (ORCPT ); Sat, 31 Oct 2020 07:41:27 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 36E6420719; Sat, 31 Oct 2020 11:41:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604144486; bh=/eWSMNuw7hAI76MfM3ORRrqREp2ulmo2HGI74xNA2bA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BZ+JSfaUO4scb5OkHNMmygMhVNZlnNZQS1eM9M1il2RmyNr7KGP58YzqUFvgSaNyf dytWpGkDXHzBb4EQ6t3ZZhHz7OvzulOmtKSHDBFrAe/M9AKUyL2roa/ZCVer58oJ5V r7IGCXoa38WbZA9dY8it4sIkWwOvLbDPMXIGVRF8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michal Suchanek , Thomas Bogendoerfer , Jakub Kicinski Subject: [PATCH 5.8 37/70] ibmveth: Fix use of ibmveth in a bridge. Date: Sat, 31 Oct 2020 12:36:09 +0100 Message-Id: <20201031113501.274418934@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201031113459.481803250@linuxfoundation.org> References: <20201031113459.481803250@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Thomas Bogendoerfer [ Upstream commit 2ac8af0967aaa2b67cb382727e784900d2f4d0da ] The check for src mac address in ibmveth_is_packet_unsupported is wrong. Commit 6f2275433a2f wanted to shut down messages for loopback packets, but now suppresses bridged frames, which are accepted by the hypervisor otherwise bridging won't work at all. Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor") Signed-off-by: Michal Suchanek Signed-off-by: Thomas Bogendoerfer Link: https://lore.kernel.org/r/20201026104221.26570-1-msuchanek@suse.de Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/ibm/ibmveth.c | 6 ------ 1 file changed, 6 deletions(-) --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -1031,12 +1031,6 @@ static int ibmveth_is_packet_unsupported ret = -EOPNOTSUPP; } - if (!ether_addr_equal(ether_header->h_source, netdev->dev_addr)) { - netdev_dbg(netdev, "source packet MAC address does not match veth device's, dropping packet.\n"); - netdev->stats.tx_dropped++; - ret = -EOPNOTSUPP; - } - return ret; }