From patchwork Tue Oct 27 13:51:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 312504 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80E4BC55179 for ; Tue, 27 Oct 2020 15:47:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3576922282 for ; Tue, 27 Oct 2020 15:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603813646; bh=UiB4JC8Yo1+jgzneIrZUh6Hd5It3hCCQLqThrF9KF+k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=UePBVc2RkdosuWOvsRGuLl3HsAOLYCNs1kRCwOlUvpMfyYvJdaosL3TgTtcdrXCbz 2viFM8hphFQaoQKKEqV0Ge3+oZTKFHqdbbrs/Sk+i0cW+iXlNh2Kr7ik4ez6vhrzyQ cO+B17qY2YiE/HVMOoC2UFZxPUg36YbNj/8lrstA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1802088AbgJ0Ppe (ORCPT ); Tue, 27 Oct 2020 11:45:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:57648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1801063AbgJ0PiW (ORCPT ); Tue, 27 Oct 2020 11:38:22 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4186D207C4; Tue, 27 Oct 2020 15:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603813100; bh=UiB4JC8Yo1+jgzneIrZUh6Hd5It3hCCQLqThrF9KF+k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2jRxV5FMLmAYIlLGGzYuK3ja1svsiwD5oyosieVqCUfBJzyBjoEIve/k2Dw8zn5B8 VGa7x8O3mcrWW0L9Q7jr4KdUmZgu929ybv+VM54WxXs1TSvG4AlLjs5CODzrsDho/Y hCVBzGX440VCHhHoDKYjlDpM+EtxU9upc6mmDm84= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michal Kalderon , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.9 436/757] RDMA/qedr: Fix use of uninitialized field Date: Tue, 27 Oct 2020 14:51:26 +0100 Message-Id: <20201027135510.996019563@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135450.497324313@linuxfoundation.org> References: <20201027135450.497324313@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Michal Kalderon [ Upstream commit a379ad54e55a12618cae7f6333fd1b3071de9606 ] dev->attr.page_size_caps was used uninitialized when setting device attributes Fixes: ec72fce401c6 ("qedr: Add support for RoCE HW init") Link: https://lore.kernel.org/r/20200902165741.8355-4-michal.kalderon@marvell.com Signed-off-by: Michal Kalderon Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/qedr/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c index d85f992bac299..8e1365951fb6a 100644 --- a/drivers/infiniband/hw/qedr/main.c +++ b/drivers/infiniband/hw/qedr/main.c @@ -602,7 +602,7 @@ static int qedr_set_device_attr(struct qedr_dev *dev) qed_attr = dev->ops->rdma_query_device(dev->rdma_ctx); /* Part 2 - check capabilities */ - page_size = ~dev->attr.page_size_caps + 1; + page_size = ~qed_attr->page_size_caps + 1; if (page_size > PAGE_SIZE) { DP_ERR(dev, "Kernel PAGE_SIZE is %ld which is smaller than minimum page size (%d) required by qedr\n",