From patchwork Tue Oct 27 13:52:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 312879 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C259C55178 for ; Tue, 27 Oct 2020 14:40:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA71D207BB for ; Tue, 27 Oct 2020 14:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603809658; bh=sGaL95rRbM6Xb0b0k4a0ZZs9+QinxU6WgZWQsL7BSOM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=a0wriaNnH1YHMgi9lAXXsXq+Hs4x/hYt38DVuGZ+kMiKLmbF5zGQVxXFmgeqIwFnB UmM1YUN9mtAVf+3LJ6B6nuUJRXfQuEWSEp2WSv2Kzpelu6ztdQy/WTsoiAnjHLfAuc 9pOvjrxDCrbT0QbC3XMvEUVNx8HGM6Kt2pI+t0Eg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750055AbgJ0Okr (ORCPT ); Tue, 27 Oct 2020 10:40:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:39200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761524AbgJ0Oj5 (ORCPT ); Tue, 27 Oct 2020 10:39:57 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AA47D207BB; Tue, 27 Oct 2020 14:39:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603809597; bh=sGaL95rRbM6Xb0b0k4a0ZZs9+QinxU6WgZWQsL7BSOM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RpxA9v9sdnDFznSsrnUweKKMMefY33yiXlixEsEzfMl5OfjEDGHUHY/2c6ktALDM+ zHkIS++akXCWN/F1NUX9j5Tb8zs0T+aaV9HUsUXckUDZaUzSUbySMPBUvu6UPmSA8X V5GaCxAtUhDnMqTQZoiPf+4WR3mnAVrMa+X4RRXs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Darrick J. Wong" , Christoph Hellwig , Chandan Babu R , Sasha Levin Subject: [PATCH 5.4 213/408] xfs: limit entries returned when counting fsmap records Date: Tue, 27 Oct 2020 14:52:31 +0100 Message-Id: <20201027135504.973339803@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135455.027547757@linuxfoundation.org> References: <20201027135455.027547757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Darrick J. Wong [ Upstream commit acd1ac3aa22fd58803a12d26b1ab7f70232f8d8d ] If userspace asked fsmap to count the number of entries, we cannot return more than UINT_MAX entries because fmh_entries is u32. Therefore, stop counting if we hit this limit or else we will waste time to return truncated results. Fixes: e89c041338ed ("xfs: implement the GETFSMAP ioctl") Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Reviewed-by: Chandan Babu R Signed-off-by: Sasha Levin --- fs/xfs/xfs_fsmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/xfs/xfs_fsmap.c b/fs/xfs/xfs_fsmap.c index c13754e119be1..5b864985bc648 100644 --- a/fs/xfs/xfs_fsmap.c +++ b/fs/xfs/xfs_fsmap.c @@ -255,6 +255,9 @@ xfs_getfsmap_helper( /* Are we just counting mappings? */ if (info->head->fmh_count == 0) { + if (info->head->fmh_entries == UINT_MAX) + return -ECANCELED; + if (rec_daddr > info->next_daddr) info->head->fmh_entries++;