From patchwork Tue Oct 27 13:49:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 307050 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E7C3C388F9 for ; Tue, 27 Oct 2020 17:43:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4181206DD for ; Tue, 27 Oct 2020 17:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603820609; bh=c8wDAXu4cH/SVSFcKyJJjTYM7/BaI6/wMP+Z9tPj/Fw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pZJeKp0a+M1JnQVSZscCZfkXbKk5IfWGXbOMByHVnNzrO9iGCgFonqCZV6ndkAids KpI53Qx0mREirRZayunM64usqrN4nri9u3gwyRoHVYyJO6SWKOqAywn5Gf4sq7QmTs 0ZwsgrIAI8W2G4WVg5DAtykTeapbFBYSEAu9qsFM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1821403AbgJ0Rn1 (ORCPT ); Tue, 27 Oct 2020 13:43:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:58812 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2902281AbgJ0OcA (ORCPT ); Tue, 27 Oct 2020 10:32:00 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 87C2820754; Tue, 27 Oct 2020 14:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603809120; bh=c8wDAXu4cH/SVSFcKyJJjTYM7/BaI6/wMP+Z9tPj/Fw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1KUX6+fFyVwrmDtkIy9r/WF0UTe0H/vHbdwM8GlfSzEGNCgYJgh2B3x1xd4q1kTY0 h0qe7NX0HQGRKpeUUORKsUjkrZbDIHXBm5p7BYcPFgi1x8/xPHhPsEHWYFBAmUfWG4 SlIuPxDBq8msfAjiJodkHMz/tlCXuTTV9gZyB53s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Roberto Sassu , Mimi Zohar Subject: [PATCH 5.4 052/408] ima: Dont ignore errors from crypto_shash_update() Date: Tue, 27 Oct 2020 14:49:50 +0100 Message-Id: <20201027135457.485388717@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135455.027547757@linuxfoundation.org> References: <20201027135455.027547757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Roberto Sassu commit 60386b854008adc951c470067f90a2d85b5d520f upstream. Errors returned by crypto_shash_update() are not checked in ima_calc_boot_aggregate_tfm() and thus can be overwritten at the next iteration of the loop. This patch adds a check after calling crypto_shash_update() and returns immediately if the result is not zero. Cc: stable@vger.kernel.org Fixes: 3323eec921efd ("integrity: IMA as an integrity service provider") Signed-off-by: Roberto Sassu Signed-off-by: Mimi Zohar Signed-off-by: Greg Kroah-Hartman --- security/integrity/ima/ima_crypto.c | 2 ++ 1 file changed, 2 insertions(+) --- a/security/integrity/ima/ima_crypto.c +++ b/security/integrity/ima/ima_crypto.c @@ -688,6 +688,8 @@ static int ima_calc_boot_aggregate_tfm(c /* now accumulate with current aggregate */ rc = crypto_shash_update(shash, d.digest, crypto_shash_digestsize(tfm)); + if (rc != 0) + return rc; } if (!rc) crypto_shash_final(shash, digest);