From patchwork Tue Oct 27 13:52:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 306972 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C276C63697 for ; Tue, 27 Oct 2020 18:01:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE2A7222E9 for ; Tue, 27 Oct 2020 18:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603821659; bh=tYpM5KsiTqaEvdIsqyoojda8mhpHB/V5C8mGYe07Lw0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HKjbWkkdrffp7MdC6zmgMqBf9RRe4rybI3y5r8nqTJTI/Z6Jqc+uAOtEzgmF+NTjK irkPt2JmQqhQC0r147ACwcLaKc46+vdZPUy8Fu7YJ8hGOqMPNst391ON2vLDYKLltB mXD1BN6jIfrmwi/Pvi9as2hYXfLFodNEoW5rT/Mk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1823017AbgJ0R4u (ORCPT ); Tue, 27 Oct 2020 13:56:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:45694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S460365AbgJ0OVZ (ORCPT ); Tue, 27 Oct 2020 10:21:25 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BBC11222D9; Tue, 27 Oct 2020 14:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603808485; bh=tYpM5KsiTqaEvdIsqyoojda8mhpHB/V5C8mGYe07Lw0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rMgqPaNngU8t1uSYhIRMabJkOrgC8c6IdcpsF728Lkjb8SyEMjWcDsbVm3QWZAPIL A5fOm/GcFQn6lJsQZIJE/jNctTwC+a/t7uSVHkxtIJ3dH7lBbUJlMERAKNK2x2yA/G VPZeZ2AsX97n4eSCTg9NskEXn+kq5eSq4J24FPno= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Srinivas Kandagatla , Sasha Levin Subject: [PATCH 4.19 108/264] slimbus: core: do not enter to clock pause mode in core Date: Tue, 27 Oct 2020 14:52:46 +0100 Message-Id: <20201027135435.755645718@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135430.632029009@linuxfoundation.org> References: <20201027135430.632029009@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Srinivas Kandagatla [ Upstream commit df2c471c4ae07e18a0396db670dca2ef867c5153 ] Let the controller logic decide when to enter into clock pause mode! Entering in to pause mode during unregistration does not really make sense as the controller is totally going down at that point in time. Fixes: 4b14e62ad3c9e ("slimbus: Add support for 'clock-pause' feature") Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20200925095520.27316-3-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/slimbus/core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 6e690aaacad1e..3e63e4ce45b04 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -255,8 +255,6 @@ int slim_unregister_controller(struct slim_controller *ctrl) { /* Remove all clients */ device_for_each_child(ctrl->dev, NULL, slim_ctrl_remove_device); - /* Enter Clock Pause */ - slim_ctrl_clk_pause(ctrl, false, 0); ida_simple_remove(&ctrl_ida, ctrl->id); return 0;