From patchwork Tue Oct 27 13:49:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 311800 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55C2EC4363A for ; Tue, 27 Oct 2020 18:09:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0953020723 for ; Tue, 27 Oct 2020 18:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603822174; bh=OCj/8NsSojQ0BxbpC31Yz318JM50e/36vBJazaoYzYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=UFozrekK2ZHVIqX8ldAZsXQv1NoIJg2TaqT71mPOl2yf+Anx5epwedyFcTfJuhpkf H63+Hwex8XYtz3CvayDcJdk6Ito/Trt2HwQqfC9oxDnQU2FFrXAtnFCK958FCx6Lku Lm4Wfz9TSeyK7l1CsYjXPvle3tm/i2Lv5H3TTzeY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1825143AbgJ0SJd (ORCPT ); Tue, 27 Oct 2020 14:09:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:37270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2508489AbgJ0OP0 (ORCPT ); Tue, 27 Oct 2020 10:15:26 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B24B8206F7; Tue, 27 Oct 2020 14:15:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603808125; bh=OCj/8NsSojQ0BxbpC31Yz318JM50e/36vBJazaoYzYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Os6SbSZ53t+ar2a24KJnxg91pPJr7qHKOj9NtS1zha9L29Vs7/V+98+586hw2Ny7T cACDGkDr4u+0SlGfpJ0GzWpKKVy0gC+QzMmtEGvEtojnOpjFE4N6LKvmmEJQVNahQi 6r42Y1vaewspFb2tD+TKMy7FfYqOKklTsErFKLPw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+998261c2ae5932458f6c@syzkaller.appspotmail.com, Oliver Neukum , Sean Young , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 138/191] media: ati_remote: sanity check for both endpoints Date: Tue, 27 Oct 2020 14:49:53 +0100 Message-Id: <20201027134916.346698319@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027134909.701581493@linuxfoundation.org> References: <20201027134909.701581493@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Oliver Neukum [ Upstream commit a8be80053ea74bd9c3f9a3810e93b802236d6498 ] If you do sanity checks, you should do them for both endpoints. Hence introduce checking for endpoint type for the output endpoint, too. Reported-by: syzbot+998261c2ae5932458f6c@syzkaller.appspotmail.com Signed-off-by: Oliver Neukum Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/rc/ati_remote.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/rc/ati_remote.c b/drivers/media/rc/ati_remote.c index d0871d60a7231..8e3af398a6c4e 100644 --- a/drivers/media/rc/ati_remote.c +++ b/drivers/media/rc/ati_remote.c @@ -845,6 +845,10 @@ static int ati_remote_probe(struct usb_interface *interface, err("%s: endpoint_in message size==0? \n", __func__); return -ENODEV; } + if (!usb_endpoint_is_int_out(endpoint_out)) { + err("%s: Unexpected endpoint_out\n", __func__); + return -ENODEV; + } ati_remote = kzalloc(sizeof (struct ati_remote), GFP_KERNEL); rc_dev = rc_allocate_device(RC_DRIVER_SCANCODE);