From patchwork Tue Oct 27 13:49:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 306932 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF474C4363A for ; Tue, 27 Oct 2020 18:13:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5AEC422202 for ; Tue, 27 Oct 2020 18:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603822416; bh=iZg1V3NDOlvTjIe2MqAcQePSQynr7q9fc+cbf3+vKUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=iShgVFq7rDH1lvfqxqcOKD5+fEKGS6bdxfT2kC2xXuP1TkyX86yQRXWcJjEaeCayM AOnBB7HUPpimrnOK8+YMbTjiqiubqgSuMvEPvhf9DYuCDlKwwcMOcKGS/fOQ545u8u Bf+fbUcYQ9GO8bdtxhP2bVpofQLDZM0A1RFwxDMI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756565AbgJ0OON (ORCPT ); Tue, 27 Oct 2020 10:14:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:35684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756560AbgJ0OOL (ORCPT ); Tue, 27 Oct 2020 10:14:11 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB3B3206F7; Tue, 27 Oct 2020 14:14:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603808051; bh=iZg1V3NDOlvTjIe2MqAcQePSQynr7q9fc+cbf3+vKUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EFgBMJnHKzSgln0HnziWp0zBZ/E1WpgzW1hPLiaaoQ1CTl6AfMN9Az8I35Wyhd8ve ge4haHKpTYP8DPr8ZsDBAkylXvZOA7C/mLOCNebB4ikeZGqsUvG4dn0yPOoA1xxSSd MKmK+71NwAiMDnCnZIQ+OYXUuP/O0/3/44XMoflA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tobias Jordan , Andrew Morton , Krzysztof Kozlowski , Jonathan Corbet , Mauro Carvalho Chehab , Linus Torvalds , Sasha Levin Subject: [PATCH 4.14 107/191] lib/crc32.c: fix trivial typo in preprocessor condition Date: Tue, 27 Oct 2020 14:49:22 +0100 Message-Id: <20201027134914.844295810@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027134909.701581493@linuxfoundation.org> References: <20201027134909.701581493@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tobias Jordan [ Upstream commit 904542dc56524f921a6bab0639ff6249c01e775f ] Whether crc32_be needs a lookup table is chosen based on CRC_LE_BITS. Obviously, the _be function should be governed by the _BE_ define. This probably never pops up as it's hard to come up with a configuration where CRC_BE_BITS isn't the same as CRC_LE_BITS and as nobody is using bitwise CRC anyway. Fixes: 46c5801eaf86 ("crc32: bolt on crc32c") Signed-off-by: Tobias Jordan Signed-off-by: Andrew Morton Cc: Krzysztof Kozlowski Cc: Jonathan Corbet Cc: Mauro Carvalho Chehab Link: https://lkml.kernel.org/r/20200923182122.GA3338@agrajag.zerfleddert.de Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- lib/crc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/crc32.c b/lib/crc32.c index 6ddc92bc14609..a1ccb4a8a9950 100644 --- a/lib/crc32.c +++ b/lib/crc32.c @@ -327,7 +327,7 @@ static inline u32 __pure crc32_be_generic(u32 crc, unsigned char const *p, return crc; } -#if CRC_LE_BITS == 1 +#if CRC_BE_BITS == 1 u32 __pure crc32_be(u32 crc, unsigned char const *p, size_t len) { return crc32_be_generic(crc, p, len, NULL, CRCPOLY_BE);