From patchwork Tue Oct 27 13:48:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 306919 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCBB2C4363A for ; Tue, 27 Oct 2020 18:15:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FCF6207E8 for ; Tue, 27 Oct 2020 18:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603822544; bh=vrrp1g/fcF4z5Qn14TN4QwzJcq2Iguk/mQAsVXevETw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=g9t0DUxSZmEi+vf0Ca1WGw0Der8EsoMiuBVYWXCm+po4Sfwr8jxgN4MOo9SA6x2CZ PxsL8i36xHKg8seRJkaQ/pqgVcxms0ix0OWyDd/+ETKhDhciHOtAIJF3LTLOCBTAsF rZ9Q+qYlUeNJb5XDQA/MdUaqFYk9f/PKuNKYEDN0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756307AbgJ0OMb (ORCPT ); Tue, 27 Oct 2020 10:12:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:59608 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755825AbgJ0OKs (ORCPT ); Tue, 27 Oct 2020 10:10:48 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E62EE2072D; Tue, 27 Oct 2020 14:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603807848; bh=vrrp1g/fcF4z5Qn14TN4QwzJcq2Iguk/mQAsVXevETw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cWcgqP0rg6Si1HEfHvLo5hVyq/H39AgXBbPvquXVczwhDuP/ETdNZy+8fdCn5bJkn uFxWC9D3+TDvad6pu1uXC+FhbhRE+nPBtdMjI6iBHPjqShi+pVCFkZWfKmP4o/EUau k+aeZfZU8XEWHOB7+HHuWeKotlhMu+7nNl3YK5EE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tom Rix , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 036/191] media: tc358743: initialize variable Date: Tue, 27 Oct 2020 14:48:11 +0100 Message-Id: <20201027134911.479583000@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027134909.701581493@linuxfoundation.org> References: <20201027134909.701581493@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tom Rix [ Upstream commit 274cf92d5dff5c2fec1a518078542ffe70d07646 ] clang static analysis flags this error tc358743.c:1468:9: warning: Branch condition evaluates to a garbage value return handled ? IRQ_HANDLED : IRQ_NONE; ^~~~~~~ handled should be initialized to false. Fixes: d747b806abf4 ("[media] tc358743: add direct interrupt handling") Signed-off-by: Tom Rix Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/tc358743.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index c9647e24a4a3a..f74c4f6814ebb 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1318,7 +1318,7 @@ static int tc358743_isr(struct v4l2_subdev *sd, u32 status, bool *handled) static irqreturn_t tc358743_irq_handler(int irq, void *dev_id) { struct tc358743_state *state = dev_id; - bool handled; + bool handled = false; tc358743_isr(&state->sd, 0, &handled);