From patchwork Tue Oct 27 13:48:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 306871 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C62BDC388F9 for ; Tue, 27 Oct 2020 18:26:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82C7F21D42 for ; Tue, 27 Oct 2020 18:26:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603823198; bh=dAJMI8Hy7BiyNF2k4KdevLKqTsUTOgFjIgLg4+ZK72U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1B/WXrP9O3vdqJVVtdUcXiCO1N0jSpbRiH1yEdaOheK8wZnngpBXjzrYQbUJ+mq/2 mpmlziWoRV8UfibRjOZ54lEPGeuzvvAeyXX9E4FX7KPDlCxPki1tDcSWSG/ocWt3pQ gMEG8yB6d2AwPuBznyOhxJQ79JT7BizoF1KPcQf4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1827130AbgJ0SVl (ORCPT ); Tue, 27 Oct 2020 14:21:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:50426 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2411821AbgJ0OCd (ORCPT ); Tue, 27 Oct 2020 10:02:33 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C37A221F8; Tue, 27 Oct 2020 14:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603807353; bh=dAJMI8Hy7BiyNF2k4KdevLKqTsUTOgFjIgLg4+ZK72U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XzKXxl6/iKFZ7VfvBU3+2acJmwl6xBbr0cHi+6yg5UZVbiDLNM2hdSrFphupz3XlX fJTlcFdPVjkT0Xb7Kw9/zNrYXqG+MQm2vdl8OoC8nbty2o7RmnyyYPI/F43wz0dm2U KGzACflf9XqDmECkdqJUwZ+Gji5GdknLvu803ylI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tom Rix , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.9 021/139] media: tc358743: initialize variable Date: Tue, 27 Oct 2020 14:48:35 +0100 Message-Id: <20201027134903.140092895@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027134902.130312227@linuxfoundation.org> References: <20201027134902.130312227@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tom Rix [ Upstream commit 274cf92d5dff5c2fec1a518078542ffe70d07646 ] clang static analysis flags this error tc358743.c:1468:9: warning: Branch condition evaluates to a garbage value return handled ? IRQ_HANDLED : IRQ_NONE; ^~~~~~~ handled should be initialized to false. Fixes: d747b806abf4 ("[media] tc358743: add direct interrupt handling") Signed-off-by: Tom Rix Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/tc358743.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 7ebcb9473956e..3e47b432d0f4e 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1321,7 +1321,7 @@ static int tc358743_isr(struct v4l2_subdev *sd, u32 status, bool *handled) static irqreturn_t tc358743_irq_handler(int irq, void *dev_id) { struct tc358743_state *state = dev_id; - bool handled; + bool handled = false; tc358743_isr(&state->sd, 0, &handled);