From patchwork Mon Oct 12 13:26:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 317639 Delivered-To: patch@linaro.org Received: by 2002:a92:d603:0:0:0:0:0 with SMTP id w3csp4627819ilm; Mon, 12 Oct 2020 06:33:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYd7ZfvcnBD3n/IrDiLDVp+7bFbSj4qRoGDeDFP5MZR5ONL77Hueswmn5BF47VP7vBpNpC X-Received: by 2002:a17:906:791:: with SMTP id l17mr27013352ejc.361.1602509587152; Mon, 12 Oct 2020 06:33:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602509587; cv=none; d=google.com; s=arc-20160816; b=zMm4JOafL9m5bU5Fa2pICxR/C8v1Sd7Q3jHoefJ7NS/cTEUp3tEK93iySYtYT6qQ/2 5xCFpCpbMdKPyzjOJo6MZJvMzHdWUkxPRLH7bvExk4M4whFSYv07AM7nw3VH3l6Vh3F/ ELPM4j/27ZEXU9hrDL50KA8nBfSRz228szkZ15YBk8qrmUZdee08c3vQdNYjenzdPQnl YAPmMVzoFO0QHUE+fS17urkD7QhIx0BQTMXcRRVct1ypfJq1NFZedzMFSAQbEzhpiF/7 +olyPDjkeMDaxNowbXhaaf+BfPwGBZY/8GH1BcAm8fLW6GA60UlYRJno/Ekb8CmIu69r sywA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9TStdt0P1+rr/5pJjeLyv3X0xh2cKVno/Cgk8k8eNiM=; b=k1PglcfQGsBufjF4Aw8EG23uOC6tt/JW23IIVMZ7iOuBd5dT56NKFWtp+uAMYbxZ+L t6Inl4SOY3bHN79EKNPj2IFIH38/1xlHjWxuTQU8r1Lxi1lhYeMdJbQBYpvr5xQR8Pof h/CFQkJIenQhju54DpgCf7jmGJ/dYe6elBjGRa37k2wy91nBKgLxsGuJ/s/E73m3GnG3 EBceg6CmonmT6pH+ai6l/AMCjCMF77wBl2Im1DupmqHBM5ms6C8tKqb78kcrylymZmkN iucsSCJhfKH8LqvyGLAsVkspZD5XufwyQS9w0b42eeHOehBsmzwnyCXaIPkSl8pM4aJD i7Dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=051hEvlO; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r17si1089638edo.383.2020.10.12.06.33.06; Mon, 12 Oct 2020 06:33:07 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=051hEvlO; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388798AbgJLNdF (ORCPT + 15 others); Mon, 12 Oct 2020 09:33:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:34328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388543AbgJLNc3 (ORCPT ); Mon, 12 Oct 2020 09:32:29 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CD2112076E; Mon, 12 Oct 2020 13:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602509549; bh=C/Ge/qyXNDwS3BWaxLVKeCmxSaHKd3So69PPv/hPRso=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=051hEvlOV9prbDeSEDFM2vZiAYRPPgojnaUYzd2vPQSxpZR9RqgQ15WWgeIiHvG4K lI36D50rvsx27HewCoeL1VW3SttatJ7HjCwvDOQVqKt2NTmVVHVdEO2bKXOrko1EA/ c6misoxLXTbAJu1zPQed+WpFX5c9ABdbjFp9uZYM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Szyprowski , Krzysztof Kozlowski , Sylwester Nawrocki , Stephen Boyd , Sasha Levin Subject: [PATCH 4.4 09/39] clk: samsung: exynos4: mark chipid clock as CLK_IGNORE_UNUSED Date: Mon, 12 Oct 2020 15:26:39 +0200 Message-Id: <20201012132628.593731666@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201012132628.130632267@linuxfoundation.org> References: <20201012132628.130632267@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marek Szyprowski [ Upstream commit f3bb0f796f5ffe32f0fbdce5b1b12eb85511158f ] The ChipID IO region has it's own clock, which is being disabled while scanning for unused clocks. It turned out that some CPU hotplug, CPU idle or even SOC firmware code depends on the reads from that area. Fix the mysterious hang caused by entering deep CPU idle state by ignoring the 'chipid' clock during unused clocks scan, as there are no direct clients for it which will keep it enabled. Fixes: e062b571777f ("clk: exynos4: register clocks using common clock framework") Signed-off-by: Marek Szyprowski Link: https://lore.kernel.org/r/20200922124046.10496-1-m.szyprowski@samsung.com Reviewed-by: Krzysztof Kozlowski Acked-by: Sylwester Nawrocki Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/samsung/clk-exynos4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-exynos4.c index 6c8e45e007c84..8edbb20ccff5e 100644 --- a/drivers/clk/samsung/clk-exynos4.c +++ b/drivers/clk/samsung/clk-exynos4.c @@ -1059,7 +1059,7 @@ static struct samsung_gate_clock exynos4210_gate_clks[] __initdata = { GATE(CLK_PCIE, "pcie", "aclk133", GATE_IP_FSYS, 14, 0, 0), GATE(CLK_SMMU_PCIE, "smmu_pcie", "aclk133", GATE_IP_FSYS, 18, 0, 0), GATE(CLK_MODEMIF, "modemif", "aclk100", GATE_IP_PERIL, 28, 0, 0), - GATE(CLK_CHIPID, "chipid", "aclk100", E4210_GATE_IP_PERIR, 0, 0, 0), + GATE(CLK_CHIPID, "chipid", "aclk100", E4210_GATE_IP_PERIR, 0, CLK_IGNORE_UNUSED, 0), GATE(CLK_SYSREG, "sysreg", "aclk100", E4210_GATE_IP_PERIR, 0, CLK_IGNORE_UNUSED, 0), GATE(CLK_HDMI_CEC, "hdmi_cec", "aclk100", E4210_GATE_IP_PERIR, 11, 0, @@ -1100,7 +1100,7 @@ static struct samsung_gate_clock exynos4x12_gate_clks[] __initdata = { 0), GATE(CLK_TSADC, "tsadc", "aclk133", E4X12_GATE_BUS_FSYS1, 16, 0, 0), GATE(CLK_MIPI_HSI, "mipi_hsi", "aclk133", GATE_IP_FSYS, 10, 0, 0), - GATE(CLK_CHIPID, "chipid", "aclk100", E4X12_GATE_IP_PERIR, 0, 0, 0), + GATE(CLK_CHIPID, "chipid", "aclk100", E4X12_GATE_IP_PERIR, 0, CLK_IGNORE_UNUSED, 0), GATE(CLK_SYSREG, "sysreg", "aclk100", E4X12_GATE_IP_PERIR, 1, CLK_IGNORE_UNUSED, 0), GATE(CLK_HDMI_CEC, "hdmi_cec", "aclk100", E4X12_GATE_IP_PERIR, 11, 0,