From patchwork Tue Sep 29 10:55:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 290883 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94DFBC47425 for ; Tue, 29 Sep 2020 12:18:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4387C20773 for ; Tue, 29 Sep 2020 12:18:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601381906; bh=i8udMsq7B91YRlinCGJcAolZi31wX66Zkhx3F3Z/lnA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=sBxHRmBa2ByrIZboEaaIcTRxLITuLOZnxbLqQISUFQle1uejwcZUcryp0gTto8HKd tlfYFqEbIAwPAyE9N0BpYhQTKQEP3ClBF2+ffaicezHih/3zjtBBf6M3uYwL4Q74bh 111Ik31iCinzANM0hjUV89Na6KyD8xhfg9LCFgJA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730135AbgI2MSH (ORCPT ); Tue, 29 Sep 2020 08:18:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:54450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729901AbgI2Lgv (ORCPT ); Tue, 29 Sep 2020 07:36:51 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 65BE623A6C; Tue, 29 Sep 2020 11:31:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601379101; bh=i8udMsq7B91YRlinCGJcAolZi31wX66Zkhx3F3Z/lnA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BL958McyL7WvUd2nL3LZ8LVBn9PZMJx5xOamPlLklUglj/wNuUGklln18FNh6GAQk dZAHvbzXF7ZZhwOcX927BnehaxxyJ8f2d9ygFAqN9gMuWMYbSwENI8Dd5UKUSPqgz1 Kl7teJqXrqV3FWwAxDLLDtVLFfYBInHN3QkHb3Xg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Fuqian Huang , Geert Uytterhoeven , Sasha Levin Subject: [PATCH 5.4 015/388] m68k: q40: Fix info-leak in rtc_ioctl Date: Tue, 29 Sep 2020 12:55:46 +0200 Message-Id: <20200929110011.220784133@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929110010.467764689@linuxfoundation.org> References: <20200929110010.467764689@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Fuqian Huang [ Upstream commit 7cf78b6b12fd5550545e4b73b35dca18bd46b44c ] When the option is RTC_PLL_GET, pll will be copied to userland via copy_to_user. pll is initialized using mach_get_rtc_pll indirect call and mach_get_rtc_pll is only assigned with function q40_get_rtc_pll in arch/m68k/q40/config.c. In function q40_get_rtc_pll, the field pll_ctrl is not initialized. This will leak uninitialized stack content to userland. Fix this by zeroing the uninitialized field. Signed-off-by: Fuqian Huang Link: https://lore.kernel.org/r/20190927121544.7650-1-huangfq.daxian@gmail.com Signed-off-by: Geert Uytterhoeven Signed-off-by: Sasha Levin --- arch/m68k/q40/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/m68k/q40/config.c b/arch/m68k/q40/config.c index e63eb5f069995..f31890078197e 100644 --- a/arch/m68k/q40/config.c +++ b/arch/m68k/q40/config.c @@ -264,6 +264,7 @@ static int q40_get_rtc_pll(struct rtc_pll_info *pll) { int tmp = Q40_RTC_CTRL; + pll->pll_ctrl = 0; pll->pll_value = tmp & Q40_RTC_PLL_MASK; if (tmp & Q40_RTC_PLL_SIGN) pll->pll_value = -pll->pll_value;