From patchwork Tue Sep 29 11:01:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 263209 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85049C4741F for ; Tue, 29 Sep 2020 11:52:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41268206CA for ; Tue, 29 Sep 2020 11:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601380354; bh=a+cN+gIUhdPZcV3j3N5s51FPo3tZbR21cGfXS6VKWhc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=q4yuZEhnlRgA/9bQfqalfpYEvV9teEHAZDbcZBK4gXpP/VLBkF3c0E33TRd3ZLB1k 5fsdP5hkON5K5XQJnhN2fzbaaQcevaLo/8wSIp3+SdVuziRVJZNbMwE5OOodKiQyON 6XUujaXupUxzJ6fXazPTgKtGJpLd9L6Cz/yZ3zvk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731002AbgI2Lw3 (ORCPT ); Tue, 29 Sep 2020 07:52:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:49362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731082AbgI2Lri (ORCPT ); Tue, 29 Sep 2020 07:47:38 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B668120702; Tue, 29 Sep 2020 11:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601380058; bh=a+cN+gIUhdPZcV3j3N5s51FPo3tZbR21cGfXS6VKWhc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z8JVY/kRNNFkR0I3njNV+5RhGXQyXshO+VKzX+CsgE5ElM5HN1c1mLAKMIOZw500A dl5izuLbupC7/8b3Oa4lGgxk2gjVGRJiQin9NTUGwVHHyD4/6NhRS1VNNSMsYmuh/N 0ATPO3NVCz21+LPj4J020n1SB3Jis87UUBpG3r9I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Necip Fazil Yildiran , Sagi Grimberg , Christoph Hellwig , Sasha Levin Subject: [PATCH 5.8 48/99] nvme-tcp: fix kconfig dependency warning when !CRYPTO Date: Tue, 29 Sep 2020 13:01:31 +0200 Message-Id: <20200929105932.092189273@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929105929.719230296@linuxfoundation.org> References: <20200929105929.719230296@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Necip Fazil Yildiran [ Upstream commit af5ad17854f96a6d3c9775e776bd01ab262672a1 ] When NVME_TCP is enabled and CRYPTO is disabled, it results in the following Kbuild warning: WARNING: unmet direct dependencies detected for CRYPTO_CRC32C Depends on [n]: CRYPTO [=n] Selected by [y]: - NVME_TCP [=y] && INET [=y] && BLK_DEV_NVME [=y] The reason is that NVME_TCP selects CRYPTO_CRC32C without depending on or selecting CRYPTO while CRYPTO_CRC32C is subordinate to CRYPTO. Honor the kconfig menu hierarchy to remove kconfig dependency warnings. Fixes: 79fd751d61aa ("nvme: tcp: selects CRYPTO_CRC32C for nvme-tcp") Signed-off-by: Necip Fazil Yildiran Reviewed-by: Sagi Grimberg Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- drivers/nvme/host/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig index 3ed9786b88d8e..a44d49d63968a 100644 --- a/drivers/nvme/host/Kconfig +++ b/drivers/nvme/host/Kconfig @@ -73,6 +73,7 @@ config NVME_TCP depends on INET depends on BLK_DEV_NVME select NVME_FABRICS + select CRYPTO select CRYPTO_CRC32C help This provides support for the NVMe over Fabrics protocol using