From patchwork Mon Sep 21 16:30:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "gregkh@linuxfoundation.org" X-Patchwork-Id: 263667 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9404C43468 for ; Mon, 21 Sep 2020 16:48:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F295238A1 for ; Mon, 21 Sep 2020 16:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600706890; bh=UKno+OfoKWcMw03cOeLGzo/sZOEDnGfMcq5uX14k7HI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2aNZFoBg26rUBA8FyMZOGdV8N2Yj+NjAdysK4ZQI9TjICifFN1UCgj0V+FLVFeykn rDjEyCXr+Z/Tlc8I5PpAgGgsH+lH1QhWtCIYOS40cDMx16BS1+RgMV5+32zgfwA9oO av61EqfGGk+JBmGR4lz2OpcqT5o2eKogluUIfR5g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729644AbgIUQsJ (ORCPT ); Mon, 21 Sep 2020 12:48:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:55442 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729813AbgIUQsI (ORCPT ); Mon, 21 Sep 2020 12:48:08 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70250238D7; Mon, 21 Sep 2020 16:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600706887; bh=UKno+OfoKWcMw03cOeLGzo/sZOEDnGfMcq5uX14k7HI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ed3NiTz/k4pR+cuGt2ZISKj2eJEQ4StNouQeDOOxiDNBvJlgE7ib8QqhHUO2U2NET o01IeCRiN48uHPmhHhR3z3rsuNFrzeG7FBRUTeE7m6LIMbph6RHvmePP+JrNKi6UfF YINt25u1PpPVN/hrTGLjZd/WnowIUmnuDIQZaqH8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Laurent Pinchart , Randy Dunlap , Sasha Levin Subject: [PATCH 5.4 16/72] rapidio: Replace select DMAENGINES with depends on Date: Mon, 21 Sep 2020 18:30:55 +0200 Message-Id: <20200921163122.647738250@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200921163121.870386357@linuxfoundation.org> References: <20200921163121.870386357@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Laurent Pinchart [ Upstream commit d2b86100245080cfdf1e95e9e07477474c1be2bd ] Enabling a whole subsystem from a single driver 'select' is frowned upon and won't be accepted in new drivers, that need to use 'depends on' instead. Existing selection of DMAENGINES will then cause circular dependencies. Replace them with a dependency. Signed-off-by: Laurent Pinchart Acked-by: Randy Dunlap Signed-off-by: Sasha Levin --- drivers/rapidio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig index 677d1aff61b7f..788e7830771be 100644 --- a/drivers/rapidio/Kconfig +++ b/drivers/rapidio/Kconfig @@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS config RAPIDIO_DMA_ENGINE bool "DMA Engine support for RapidIO" depends on RAPIDIO - select DMADEVICES + depends on DMADEVICES select DMA_ENGINE help Say Y here if you want to use DMA Engine frameork for RapidIO data