From patchwork Tue Sep 1 15:10:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 248920 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp4358413ilg; Tue, 1 Sep 2020 08:44:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3S4TbSgUfpJQDjRvwK4tpkpIY7KaSos5p5IKuJqra7Xe4H38eh1/pZ9LGm9rLqH0Zy4a/ X-Received: by 2002:a17:906:d050:: with SMTP id bo16mr2116513ejb.367.1598975056089; Tue, 01 Sep 2020 08:44:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598975056; cv=none; d=google.com; s=arc-20160816; b=0UxhSyOp4O/t5fXOXp+36p8qwGPp7kY9UptO3A+lTXZqjDJ+KPxbefo2wjf2sFLX58 juP9imhc7r/FN046KvaOwBfA6F5JlnpPeyGrqc2L3fFLLlGwfgPoj+glzIQ7u2jhwKvZ AbD6oPInzfbJJ1aXKJ+NH+XiQ7mg2EjUy74aOHfY+WBNuN6QSnlJv0TzDvcSMqpgYuU7 0LB/r2WlfApEosZ0+PQNAd700IuGDWGBjiFywXPLPwAxI/vFQIPnT+jSwbH4HGJKSl26 LuqfFzaF1XTk+a8MtVbtS6S9NzPF+Ly2NBieDxZGf1ke9JnSmfia+pW4JFw9e6ewm90W 7GOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WjhhbT972vcVMVOzVa2I0rSmGacYpTYbK108yQ1ZS4s=; b=OSQeUDpeDgqJGSKufVNrSdkNa+Grf6G511mOL/nMtB9cbhHpLqpfz6Drxjzre+0pq2 vwflc9nCdNyjV7Ik5nBNpOuQBX9uqMbeCGYIplra4foqAJOpwGIdFy6L75YnV6WqfMwv Xvn2uXA8DBY1ZhSScqxm3SJxy74U+ItTFcsR4pUnAgpLfVKz/zMffLJ4LEyPtjNGtART mJzfZz5rfBEHruy1ZtZvV2tKvbTgV1TSPmHtwkFs6NAlXdXr3wKdMHJts97vDzhHt6H2 mYrh1I5sB73J3hYMK1XfJqWG3QsRcmPSeymjqMsC8f+h6ZA4lghyxEtBzs6MH6XqVvQL v/xQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TUUWJHHX; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d11si742486edo.252.2020.09.01.08.44.15; Tue, 01 Sep 2020 08:44:16 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TUUWJHHX; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731729AbgIAPoO (ORCPT + 15 others); Tue, 1 Sep 2020 11:44:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:59326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731738AbgIAPoM (ORCPT ); Tue, 1 Sep 2020 11:44:12 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7AF01208CA; Tue, 1 Sep 2020 15:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598975052; bh=lAj3qZgHlA9VpgwQn7Vfkt8qFHZHHDRIsHCNYvGNVeA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TUUWJHHX0C9tZn4neLNFG8y4kgedE30f/GoEl4xw8Ig2AOgrD+KiWpopvvrx7zMB8 Qtd0pv2I7Kw4xNkHFmjfLAllRf4SkbBch3e+sERyyAN+NLTV48IkFsxQENUD6/OxZR g1gNvvZ7Zsjf0W0ZhzVPR2yEl7bAalJMjzANbeVE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vinod Koul Subject: [PATCH 5.8 191/255] usb: renesas-xhci: remove version check Date: Tue, 1 Sep 2020 17:10:47 +0200 Message-Id: <20200901151009.842792325@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200901151000.800754757@linuxfoundation.org> References: <20200901151000.800754757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vinod Koul commit d66a57be2f9a315fc10d0f524f670fec903e0fb4 upstream. Some devices in wild are reporting bunch of firmware versions, so remove the check for versions in driver Reported by: Anastasios Vacharakis Reported by: Glen Journeay Fixes: 2478be82de44 ("usb: renesas-xhci: Add ROM loader for uPD720201") Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=208911 Signed-off-by: Vinod Koul Cc: stable Link: https://lore.kernel.org/r/20200818071739.789720-1-vkoul@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/xhci-pci-renesas.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) --- a/drivers/usb/host/xhci-pci-renesas.c +++ b/drivers/usb/host/xhci-pci-renesas.c @@ -50,20 +50,6 @@ #define RENESAS_RETRY 10000 #define RENESAS_DELAY 10 -#define ROM_VALID_01 0x2013 -#define ROM_VALID_02 0x2026 - -static int renesas_verify_fw_version(struct pci_dev *pdev, u32 version) -{ - switch (version) { - case ROM_VALID_01: - case ROM_VALID_02: - return 0; - } - dev_err(&pdev->dev, "FW has invalid version :%d\n", version); - return -EINVAL; -} - static int renesas_fw_download_image(struct pci_dev *dev, const u32 *fw, size_t step, bool rom) { @@ -202,10 +188,7 @@ static int renesas_check_rom_state(struc version &= RENESAS_FW_VERSION_FIELD; version = version >> RENESAS_FW_VERSION_OFFSET; - - err = renesas_verify_fw_version(pdev, version); - if (err) - return err; + dev_dbg(&pdev->dev, "Found ROM version: %x\n", version); /* * Test if ROM is present and loaded, if so we can skip everything