From patchwork Tue Sep 1 15:08:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 248934 Delivered-To: patch@linaro.org Received: by 2002:a17:906:6447:0:0:0:0 with SMTP id l7csp3719246ejn; Tue, 1 Sep 2020 09:10:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpmedPo4XzvToPB/FQClcx3ZVavQ70KDE2WGK/9uZPFVtUHBBYl11Ml3Mfn0tMfOPNYlTR X-Received: by 2002:a17:906:b082:: with SMTP id x2mr2241827ejy.349.1598976616257; Tue, 01 Sep 2020 09:10:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598976616; cv=none; d=google.com; s=arc-20160816; b=tSh3WGSFEN12OhH2wc6DQtpEB1SRZGrFiRN6MPccFWOQViQkHgWkBpanHL/WFrqe+8 YOsBnjMNq+dHzRTGJH5XHGrwIGpFbK8IqcNqJvip4Q8E8ZpCzLUVMePz3B+7q2uNbchM /tHCaXo59irGa+FJkCV13BKERa9CsJ8naMoG9YSszFFhTgP2Y1Db3Mron20EYNAxxTts dKOrPGdY+Sd1NqJArMaxvf8b8JiiOdQXFU3Z9uLinG5CR3kzZAmp+Hoo+jmLmXR3lFVa f50Pc4BoVaBt9N3/8jbR20UeTEirIzjatJcCDUqCn2bhVTCQkdKvvutCwI6Ah3pICxy9 fDjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+WKVlhNAD5/kM9niqgyNB/xx/6PrfweqD0lnFhiHzWA=; b=E0YoOIoQtCnvoMvvMWlspp7gzhK1Uh6FruHgFwMb11j+x4N+VrjM49vCoFvl0muQZn aVlz/1mxdo/UEa1eukgmnrXN1F+0VsN0KEXa74X4KdGFc563kAPbVdtYJfuHxY7c2joy QiDR/7coS7jCT5qUCKXdJxNbFMzshZUEu/jFD63uTvug+uJUfU6bXYb0eiiVm3Ya69jC 0jUC5BpciWiw+H26CwgmhvIbAGthT2hBuNQ8cSdofl19ee9YN7VyU1nsUitIP/HfmrS8 PwoMPzLmREPl4b9zdls97cxpowsU/CZI8v/zpz1OWLQPLjwPzJL4ROoqz40DSBPOIA2J rAEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QJ3A18BU; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v11si813804eju.488.2020.09.01.09.10.16; Tue, 01 Sep 2020 09:10:16 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QJ3A18BU; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728811AbgIAQKO (ORCPT + 15 others); Tue, 1 Sep 2020 12:10:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:47638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729968AbgIAPia (ORCPT ); Tue, 1 Sep 2020 11:38:30 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F4A421534; Tue, 1 Sep 2020 15:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598974710; bh=f8pxtx+OyrES5Ep2lPtPO/PT39Gfc/bkyv0MwzHa3LY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QJ3A18BU7pSeHzcBgyjhurEQI3X4MxQ3qeUbKR8qXUMAk4belvyF1ommuj9+K/flW +oovJnNgIsevl2ESdczRlyHgfFeh8QOB1qRHYD6y1vlTROp49CoErLN4Y/nInQ0pR6 FT6FemsrBswkXeMAxoqZi4V+BJHt0Es0DQgA8feg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrey Konovalov , Manivannan Sadhasivam , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.8 065/255] media: i2c: imx290: fix reset GPIO pin handling Date: Tue, 1 Sep 2020 17:08:41 +0200 Message-Id: <20200901151003.842944928@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200901151000.800754757@linuxfoundation.org> References: <20200901151000.800754757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Andrey Konovalov [ Upstream commit 3909a92d7df622b41b9ceeeea694e641cad7667b ] According to https://www.kernel.org/doc/Documentation/gpio/consumer.txt, - all of the gpiod_set_value_xxx() functions operate with the *logical* value. So in imx290_power_on() the reset signal should be cleared (de-asserted) with gpiod_set_value_cansleep(imx290->rst_gpio, 0), and in imx290_power_off() the value of 1 must be used to apply/assert the reset to the sensor. In the device tree the reset pin is described as GPIO_ACTIVE_LOW, and gpiod_set_value_xxx() functions take this into account, - when devm_gpiod_get_optional() is called with GPIOD_ASIS, the GPIO is not initialized, and the direction must be set later; using a GPIO without setting its direction first is illegal and will result in undefined behavior. Fix this by using GPIOD_OUT_HIGH instead of GPIOD_ASIS (this asserts the reset signal to the sensor initially). Signed-off-by: Andrey Konovalov Reviewed-by: Manivannan Sadhasivam Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/imx290.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index f7678e5a5d879..157a0ed0a8856 100644 --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -628,7 +628,7 @@ static int imx290_power_on(struct device *dev) } usleep_range(1, 2); - gpiod_set_value_cansleep(imx290->rst_gpio, 1); + gpiod_set_value_cansleep(imx290->rst_gpio, 0); usleep_range(30000, 31000); return 0; @@ -641,7 +641,7 @@ static int imx290_power_off(struct device *dev) struct imx290 *imx290 = to_imx290(sd); clk_disable_unprepare(imx290->xclk); - gpiod_set_value_cansleep(imx290->rst_gpio, 0); + gpiod_set_value_cansleep(imx290->rst_gpio, 1); regulator_bulk_disable(IMX290_NUM_SUPPLIES, imx290->supplies); return 0; @@ -760,7 +760,8 @@ static int imx290_probe(struct i2c_client *client) goto free_err; } - imx290->rst_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_ASIS); + imx290->rst_gpio = devm_gpiod_get_optional(dev, "reset", + GPIOD_OUT_HIGH); if (IS_ERR(imx290->rst_gpio)) { dev_err(dev, "Cannot get reset gpio\n"); ret = PTR_ERR(imx290->rst_gpio);