From patchwork Tue Sep 1 15:11:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 248935 Delivered-To: patch@linaro.org Received: by 2002:a17:906:6447:0:0:0:0 with SMTP id l7csp3723334ejn; Tue, 1 Sep 2020 09:14:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx74FQtMutAsJsItHyGm/Af80P6fs13ZvpWJRBz4oRji76QuHyaux4zh2e3BeK2ThHN+9uN X-Received: by 2002:a50:fd87:: with SMTP id o7mr2331388edt.180.1598976868036; Tue, 01 Sep 2020 09:14:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598976868; cv=none; d=google.com; s=arc-20160816; b=Pr6GQKt1X/rjh02P2/h1W0cnsm0Mq4FCIv28ez65s7LecNTDb1pCLgp6bwZYqw91ST w18Ud7ERAvcbCpIeHrCfZxnhO2xIP+5HudNHdMF5pUgBG8+LmjMm8uHt42XAAM2qWExF H3YChXknTvihWYfwdCDDjs/xkVOD20R4y9ktZdE/9f2F2X4SZuASoyfQ2Yv7Tp7nUnUX wzRBMUMeTjtTaRimDsDeh5XwlLvq5UZsk2G+5vhN8X36lOdYKZ/BIFwciQvjcAtaSb4g izWaiDKBo5CHegsFdM7p0Kz3zqEaRReQIdfUMXk5UPN3/46uyUfczW+gWzh189Vw0/OB WPzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DGkHfo46tB2+fho7QbEj9D9j4ReNF8hFt0+h2fJva/4=; b=cnzUV38aBQpAsCKrYniMVFpl3VRNQqYjodXLBG7zILBdh+/uXQj4h188JIUfAnmf7O KKK557xR5IR2y7J5jI5xS+2Kylzqu224ZVhA8DSBC5x6UGBAs4dgBq+g5XYlXOPXaVax j/nDnkuZsa/o2XAU13SMkAu/InsWsWCgqtYgP26PYVMHWeMVg/n5AxTT+8Hu2B+5h5GY jGNBL93ya51eJyANeUMIUUotNHjTZKWX8Sr7Fb8WP4csMIe6+/70YzfZvkclxxOrQ6FJ L4rCF+YMDsCLH7Wji4sHGMVDn87bBbFzT2waz1CmjPsTbINHWxOpfjFmnoUlzepTNO4H 9oLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f0bVnkKB; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b7si1023042edz.404.2020.09.01.09.14.27; Tue, 01 Sep 2020 09:14:28 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f0bVnkKB; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731195AbgIAPfY (ORCPT + 15 others); Tue, 1 Sep 2020 11:35:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:41070 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731182AbgIAPfV (ORCPT ); Tue, 1 Sep 2020 11:35:21 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CAEEA20866; Tue, 1 Sep 2020 15:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598974521; bh=bvWFV2a4Kqn7UBOT2pn4bMdej+uDUFfTkyG2Rh/G8RM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f0bVnkKBs/gsH08lcKSh2U2do/uqs4Z1c6zcEfK6jwAuW1Y+W+JlVnIuuMrfcUiqY TBiszAR8jlEQY0p1dhdaGHaRksBVnk1H1zkX3u4ER/RwvdZDPRFDgI1V6bEHvxKDnf PB0NmyNne59vqdvBTu+i3gUNFhJeJhhWwQhsbPIU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Masahiro Yamada , Matthias Maennich Subject: [PATCH 5.4 209/214] kheaders: explain why include/config/autoconf.h is excluded from md5sum Date: Tue, 1 Sep 2020 17:11:29 +0200 Message-Id: <20200901151002.938717565@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200901150952.963606936@linuxfoundation.org> References: <20200901150952.963606936@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Masahiro Yamada commit f276031b4e2f4c961ed6d8a42f0f0124ccac2e09 upstream. This comment block explains why include/generated/compile.h is omitted, but nothing about include/generated/autoconf.h, which might be more difficult to understand. Add more comments. Signed-off-by: Masahiro Yamada Signed-off-by: Matthias Maennich Signed-off-by: Greg Kroah-Hartman --- kernel/gen_kheaders.sh | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) --- a/kernel/gen_kheaders.sh +++ b/kernel/gen_kheaders.sh @@ -32,8 +32,15 @@ fi all_dirs="$all_dirs $dir_list" # include/generated/compile.h is ignored because it is touched even when none -# of the source files changed. This causes pointless regeneration, so let us -# ignore them for md5 calculation. +# of the source files changed. +# +# When Kconfig regenerates include/generated/autoconf.h, its timestamp is +# updated, but the contents might be still the same. When any CONFIG option is +# changed, Kconfig touches the corresponding timestamp file include/config/*.h. +# Hence, the md5sum detects the configuration change anyway. We do not need to +# check include/generated/autoconf.h explicitly. +# +# Ignore them for md5 calculation to avoid pointless regeneration. headers_md5="$(find $all_dirs -name "*.h" | grep -v "include/generated/compile.h" | grep -v "include/generated/autoconf.h" |