From patchwork Tue Sep 1 15:09:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 264575 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BC03C433E2 for ; Tue, 1 Sep 2020 16:34:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E423E2065F for ; Tue, 1 Sep 2020 16:34:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598978061; bh=ZoDP69SRJjxZrcKtbRjhAlNdFM1J6kH8Mc4Sl3yWmO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=IaOnocz9MSEd0dhmjmr3c1AwWVUWCDf1rSoxMZvx9a+lYdt/Cm+TXg68zScuTiJaN ipxn1V7K86wCxyenkaSDdl/hsx5C6LJvwDJDDIjBmpTTUNbiy4WL4LKxSC/uQUziio beggKhxGVLWwOXT+k3FZwU8UbazQToevOUYK5BFM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730688AbgIAPbR (ORCPT ); Tue, 1 Sep 2020 11:31:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:34128 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730196AbgIAPbQ (ORCPT ); Tue, 1 Sep 2020 11:31:16 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8455B2078B; Tue, 1 Sep 2020 15:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598974276; bh=ZoDP69SRJjxZrcKtbRjhAlNdFM1J6kH8Mc4Sl3yWmO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XWxnFosqvO1YPUW8WNBYw+cdCus4nl80E+8SJC4sCG/KLES5/6aBbtYK25oHlsAn9 aaUUGysJ+Sf05YGhbXiONL+l2RHUVE5mnFL3SRvTrTt1e150pm3Jiu27gdjZ+nNmQV bdaocLSQ4D3FbjjeLgvxOF/YUjJBVCH35Jb1m3Dk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tobias Schramm , Mark Brown , Sasha Levin Subject: [PATCH 5.4 113/214] spi: stm32: clear only asserted irq flags on interrupt Date: Tue, 1 Sep 2020 17:09:53 +0200 Message-Id: <20200901150958.399129506@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200901150952.963606936@linuxfoundation.org> References: <20200901150952.963606936@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tobias Schramm [ Upstream commit ae1ba50f1e706dfd7ce402ac52c1f1f10becad68 ] Previously the stm32h7 interrupt thread cleared all non-masked interrupts. If an interrupt was to occur during the handling of another interrupt its flag would be unset, resulting in a lost interrupt. This patches fixes the issue by clearing only the currently set interrupt flags. Signed-off-by: Tobias Schramm Link: https://lore.kernel.org/r/20200804195136.1485392-1-t.schramm@manjaro.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index 7e92ab0cc9920..dc6334f67e6ae 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -962,7 +962,7 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) if (!spi->cur_usedma && (spi->rx_buf && (spi->rx_len > 0))) stm32h7_spi_read_rxfifo(spi, false); - writel_relaxed(mask, spi->base + STM32H7_SPI_IFCR); + writel_relaxed(sr & mask, spi->base + STM32H7_SPI_IFCR); spin_unlock_irqrestore(&spi->lock, flags);