From patchwork Tue Sep 1 15:10:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 264475 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC7F3C43461 for ; Tue, 1 Sep 2020 17:05:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE6872064B for ; Tue, 1 Sep 2020 17:05:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598979934; bh=TYjF/d9WBP43ddUwwnSLpu0HAYO2mzl+WAcXHBP3BZw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=O4i1Zna85w3qmf5nwgvNIrUWdFpI5fIEU+rKckuJlmIXZis000QyxRyfw2LWLLTAZ E9t8EiV4oNYIoFU0kWcSriuhU46bGERbIhw3Noo0UJdzMCCTxaNvNRVp8XAgs3l55x xAFD6OHt5xCu1WplUX/1lbZ9Hl2foTKevCbSQY/M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728947AbgIARFd (ORCPT ); Tue, 1 Sep 2020 13:05:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:37984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729017AbgIAPTK (ORCPT ); Tue, 1 Sep 2020 11:19:10 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 526AE20767; Tue, 1 Sep 2020 15:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598973549; bh=TYjF/d9WBP43ddUwwnSLpu0HAYO2mzl+WAcXHBP3BZw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=irbG+MO0EL3YdPdrxS2JxoM6Lz2obT3Wm49/zhEbOHC9T3BR+CV5amd1outRj4jtD xtARWhZr/9Yts3fSHsh/UT/v26HLlUD1j0DmbX1Wrf16+Ir+hWQFOAZ3gfoKDZPWS6 LbOKgvXvZGQ3/HgmDLZD9mT2x8XXNZNH9ON1ka+M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hou Pu , Jens Axboe , Sasha Levin Subject: [PATCH 4.14 44/91] null_blk: fix passing of REQ_FUA flag in null_handle_rq Date: Tue, 1 Sep 2020 17:10:18 +0200 Message-Id: <20200901150930.328415489@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200901150928.096174795@linuxfoundation.org> References: <20200901150928.096174795@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Hou Pu [ Upstream commit 2d62e6b038e729c3e4bfbfcfbd44800ef0883680 ] REQ_FUA should be checked using rq->cmd_flags instead of req_op(). Fixes: deb78b419dfda ("nullb: emulate cache") Signed-off-by: Hou Pu Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/null_blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c index b12e373aa956a..ec670a1b7e02f 100644 --- a/drivers/block/null_blk.c +++ b/drivers/block/null_blk.c @@ -1135,7 +1135,7 @@ static int null_handle_rq(struct nullb_cmd *cmd) len = bvec.bv_len; err = null_transfer(nullb, bvec.bv_page, len, bvec.bv_offset, op_is_write(req_op(rq)), sector, - req_op(rq) & REQ_FUA); + rq->cmd_flags & REQ_FUA); if (err) { spin_unlock_irq(&nullb->lock); return err;