From patchwork Tue Sep 1 15:10:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 264434 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB31FC433E6 for ; Tue, 1 Sep 2020 17:19:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A24332078B for ; Tue, 1 Sep 2020 17:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598980746; bh=mXVF9uRqoTaQC0cctmJegqY31LEmnQYv/Pi506+XALI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=iu0Cldts42EZKr7L9wnIoAy5AxZQAj8cUNha0E9h3MyP+q89yRFVYMAP+CzFy538C RPlCCN4GgJI7BTOphtOIKZ7wZXf31TPE1wsdpSvRuMu9rez5a7cSAcvY6Oqp07PeQ7 H/GjzdUr6gKPAxm7SKjwJ4Je5fDo2kVqBdQhhMtU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732463AbgIARTF (ORCPT ); Tue, 1 Sep 2020 13:19:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:57182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728965AbgIAPNt (ORCPT ); Tue, 1 Sep 2020 11:13:49 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D90E9206EB; Tue, 1 Sep 2020 15:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598973229; bh=mXVF9uRqoTaQC0cctmJegqY31LEmnQYv/Pi506+XALI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SNUf/ONAgxmFMtMM3JjkxuqvJr5w7ErBK0/Mge32d4eJ1ZxS4gBXiIEJ1op+EWvUV NFBA+gm/lhAjtn2mtTdTKLiA/GhiRmGkzMBnipnPnuSL+KngFOwhjzop9XEfzT5U7J ZsI+3yh+DsaFlzo+/YdZ8mpxJsZ85EEszOwOAyGg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Evgeny Novikov , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.4 29/62] media: davinci: vpif_capture: fix potential double free Date: Tue, 1 Sep 2020 17:10:12 +0200 Message-Id: <20200901150922.185436441@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200901150920.697676718@linuxfoundation.org> References: <20200901150920.697676718@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Evgeny Novikov [ Upstream commit 602649eadaa0c977e362e641f51ec306bc1d365d ] In case of errors vpif_probe_complete() releases memory for vpif_obj.sd and unregisters the V4L2 device. But then this is done again by vpif_probe() itself. The patch removes the cleaning from vpif_probe_complete(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/davinci/vpif_capture.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index c1e573b7cc6fb..50122ac2ac028 100644 --- a/drivers/media/platform/davinci/vpif_capture.c +++ b/drivers/media/platform/davinci/vpif_capture.c @@ -1417,8 +1417,6 @@ probe_out: /* Unregister video device */ video_unregister_device(&ch->video_dev); } - kfree(vpif_obj.sd); - v4l2_device_unregister(&vpif_obj.v4l2_dev); return err; }