From patchwork Mon Aug 24 08:31:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 248163 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp2375491ils; Mon, 24 Aug 2020 02:05:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2USPPvBxfZBTQ5P2r6n0u+aFFQmgpg5yiIEs2vncgwrn6QmZ3f6vh+DjWgIYs5MGZ8KMj X-Received: by 2002:a17:906:1483:: with SMTP id x3mr4839254ejc.318.1598259900154; Mon, 24 Aug 2020 02:05:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598259900; cv=none; d=google.com; s=arc-20160816; b=ds4Jn8y5Y/7jYq6YIb6wFKP5ubBeeXEzfabzCiadv2mZku59WnkjlaMVBZSJsCSxXR avJDAB0FP2wea+fjyCUEzfbskusgd910SHZf/9WZ6WQa0RPaXJV7JzLW5sDCWXzKv8NW ptkzsK50nwrSiQRGQV0JjdcA6GMyjLkxrl+/mNnrj+AwBEEq22zvD3+MK3JvPLWMHppL 0v9UFKuycZ99ZJTBb4pdA+U3ekOiOPZSfNFRTifQgmbYwYsSsT2re0/hEG/S7TcCrX8e qaPFEuLEarNJD/dO/LQPq1Ev/ibnKzsrOUGwFzj7fT24PqJ14vbhZgb26Gzl95NL8P7m ZZuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6qVNh6efz1WfIGGC7aIn32E3SWd6uRfqkZznNkG1JiY=; b=E8xott5guJZHtKPXwBTrcQQ93ql3mVL2kGeYCH+zMcfColYm77vsLLNU9U6Q/0kADZ C9RaYik/trg0DOPYNHZqzQnqVGyWQJhrrY23KUnRqcFlCi9O0E9tvtGRuArcFNcRz9+6 aWXVNp0QAV1L5MKmhol84PiCylveZQ1Xlnae5DuV0Wqiuduh3DgNFlnwFAEpGaSawZ7B iJk2dMKCTSL9JcBW/8aDtCpnvTSa95pvnnS0n6/ZmUP1NP/b8KuGxekg5eo5vMRfTrOa yXU1Zubqm1D0FSyiHvvbtyBv4TnZXvzK4gFwtVoJp1baYt+jXZUHfZQb7I6dgQsF5zhR jGXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=khPcGEHE; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u13si6286720ejg.0.2020.08.24.02.04.59; Mon, 24 Aug 2020 02:05:00 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=khPcGEHE; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730011AbgHXJEA (ORCPT + 15 others); Mon, 24 Aug 2020 05:04:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:41892 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730560AbgHXI4d (ORCPT ); Mon, 24 Aug 2020 04:56:33 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DDAE1207DF; Mon, 24 Aug 2020 08:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598259392; bh=Ys87Lof4nlIwJI1DRGTlm7+7kotLyXnT2dUplrWM5vU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=khPcGEHEZxzp8PMr7zZQIHjAFlh4BfEs3pWOFpiSYzsLzHYpAlYkCklsXUVViaH0+ b8UcufUE4JbgtMcFiHYtJH/YlCSvJgysHdakBUSIMkSV4oLwli8mVuSpQ/DdLjQRLc 1CLVr/JZJIfGeewrDwUXV/wlcEl3H6jCl+6LOpeA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, John Stultz , Srinivas Kandagatla , Mark Brown , Sasha Levin Subject: [PATCH 4.19 41/71] ASoC: q6routing: add dummy register read/write function Date: Mon, 24 Aug 2020 10:31:32 +0200 Message-Id: <20200824082357.943890893@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200824082355.848475917@linuxfoundation.org> References: <20200824082355.848475917@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Srinivas Kandagatla [ Upstream commit 796a58fe2b8c9b6668db00d92512ec84be663027 ] Most of the DAPM widgets for DSP ASoC components reuse reg field of the widgets for its internal calculations, however these are not real registers. So read/writes to these numbers are not really valid. However ASoC core will read these registers to get default state during startup. With recent changes to ASoC core, every register read/write failures are reported very verbosely. Prior to this fails to reads are totally ignored, so we never saw any error messages. To fix this add dummy read/write function to return default value. Fixes: e3a33673e845 ("ASoC: qdsp6: q6routing: Add q6routing driver") Reported-by: John Stultz Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20200811120205.21805-2-srinivas.kandagatla@linaro.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/qcom/qdsp6/q6routing.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) -- 2.25.1 diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c index c6b51571be945..44eee18c658ae 100644 --- a/sound/soc/qcom/qdsp6/q6routing.c +++ b/sound/soc/qcom/qdsp6/q6routing.c @@ -968,6 +968,20 @@ static int msm_routing_probe(struct snd_soc_component *c) return 0; } +static unsigned int q6routing_reg_read(struct snd_soc_component *component, + unsigned int reg) +{ + /* default value */ + return 0; +} + +static int q6routing_reg_write(struct snd_soc_component *component, + unsigned int reg, unsigned int val) +{ + /* dummy */ + return 0; +} + static const struct snd_soc_component_driver msm_soc_routing_component = { .ops = &q6pcm_routing_ops, .probe = msm_routing_probe, @@ -976,6 +990,8 @@ static const struct snd_soc_component_driver msm_soc_routing_component = { .num_dapm_widgets = ARRAY_SIZE(msm_qdsp6_widgets), .dapm_routes = intercon, .num_dapm_routes = ARRAY_SIZE(intercon), + .read = q6routing_reg_read, + .write = q6routing_reg_write, }; static int q6pcm_routing_probe(struct platform_device *pdev)