From patchwork Thu Aug 20 09:22:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 248017 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp1219755ils; Thu, 20 Aug 2020 03:20:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpbKlaBwwFXUUYBtsBKuc8HmiqjIaoeSVSe4Txh4dzqlaHXDACnpZ1M+A+OF/P0XJn9F9h X-Received: by 2002:a17:906:8587:: with SMTP id v7mr929148ejx.268.1597918837485; Thu, 20 Aug 2020 03:20:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597918837; cv=none; d=google.com; s=arc-20160816; b=H8a1kwsKC35LOeoT9q04vWdssF7O6a6steEQ8Lkvva9dM/Fco0ESKUPCekigxywqqt Z0pP44eNGgcYI/iA8L8R1+CxsjYuQAyow5FZFwMyKq9p912/a1e0BlVW0Q72Jx5V8OWa W7iadf+3EMfQsk0Ju+npDYsTWIlbr1msz5Z71Y3cg8yLeLL5GyekZxi0VH4mW/igUsY5 wiJFUMYdeZz7Og1+DVLohL6EEqHahAw5uP/f4KUZ7Z5qspLwlafKFyAvh0zVxO6TsUgT /q+All2hFV5NraLqfB60OphRGiQu3VgRcFqeiyd1mKKXBeWRmaIMaJNfNmG5ji0dxJRP +bDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BY4jMNrWB1HFixfudmJ6QhqKuvocFJ6So1J2aEsWoOM=; b=giey7MFy2bveFJg+8yNBCY5EQSW7W5b5XjlNc5jSs6iSpsgEMTgsWxAv9WED50vGvu N/Yyx6oWyzyhkx+1irsPIDdi/VBUjdQTBYx+6REH9IxZo2Yvsxq1oD+0VMxdJ+IcVHPx sG/jUSJXTDMB/V838l8uoEIjlzcgNdGD1aZelAWRKk+whGeVXSJB+IP3GykG2uN15tAj nT8CEkK3OXENRadxGRvJIgo9TKEX4ULJLq/XEP1SWu37leXr6wUqqNoLrxBfcZotwOYf HRipKyX0FiskOcss/5nNIcNzBKb65WgZOqig9mXuAbcRhd/OyOK9IlwL9tCT/B3bQwWV Pd0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rI6r8Rbp; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p22si1175171eds.169.2020.08.20.03.20.37; Thu, 20 Aug 2020 03:20:37 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rI6r8Rbp; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731462AbgHTKUc (ORCPT + 15 others); Thu, 20 Aug 2020 06:20:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:45290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731468AbgHTKU0 (ORCPT ); Thu, 20 Aug 2020 06:20:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B64962067C; Thu, 20 Aug 2020 10:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597918826; bh=xm8dGOL3MbBbXctBckHxO53cRD7TlCl9qAdlABiPdy0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rI6r8Rbphy8JBZDuOi8+frtXrvaERauhdhlz0Ihi0i81eHZRJGBDlFpy/zS3Lkxxx YRpOyek2+WDf5trRyspo/i5nC0iKBvB9lQqMwHEE5fweiiScsioY4/AGjYcem9heAv S9WFLMArNFkoRsqr3ICIDQTNEUIpYygXf51lGiZg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Pavel Machek , Sasha Levin Subject: [PATCH 4.4 081/149] leds: lm355x: avoid enum conversion warning Date: Thu, 20 Aug 2020 11:22:38 +0200 Message-Id: <20200820092129.649983396@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200820092125.688850368@linuxfoundation.org> References: <20200820092125.688850368@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 985b1f596f9ed56f42b8c2280005f943e1434c06 ] clang points out that doing arithmetic between diffent enums is usually a mistake: drivers/leds/leds-lm355x.c:167:28: warning: bitwise operation between different enumeration types ('enum lm355x_tx2' and 'enum lm355x_ntc') [-Wenum-enum-conversion] reg_val = pdata->pin_tx2 | pdata->ntc_pin; ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ drivers/leds/leds-lm355x.c:178:28: warning: bitwise operation between different enumeration types ('enum lm355x_tx2' and 'enum lm355x_ntc') [-Wenum-enum-conversion] reg_val = pdata->pin_tx2 | pdata->ntc_pin | pdata->pass_mode; ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ In this driver, it is intentional, so add a cast to hide the false-positive warning. It appears to be the only instance of this warning at the moment. Fixes: b98d13c72592 ("leds: Add new LED driver for lm355x chips") Signed-off-by: Arnd Bergmann Signed-off-by: Pavel Machek Signed-off-by: Sasha Levin --- drivers/leds/leds-lm355x.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/leds/leds-lm355x.c b/drivers/leds/leds-lm355x.c index 48872997d6b4b..533b255c27cd6 100644 --- a/drivers/leds/leds-lm355x.c +++ b/drivers/leds/leds-lm355x.c @@ -177,18 +177,19 @@ static int lm355x_chip_init(struct lm355x_chip_data *chip) /* input and output pins configuration */ switch (chip->type) { case CHIP_LM3554: - reg_val = pdata->pin_tx2 | pdata->ntc_pin; + reg_val = (u32)pdata->pin_tx2 | (u32)pdata->ntc_pin; ret = regmap_update_bits(chip->regmap, 0xE0, 0x28, reg_val); if (ret < 0) goto out; - reg_val = pdata->pass_mode; + reg_val = (u32)pdata->pass_mode; ret = regmap_update_bits(chip->regmap, 0xA0, 0x04, reg_val); if (ret < 0) goto out; break; case CHIP_LM3556: - reg_val = pdata->pin_tx2 | pdata->ntc_pin | pdata->pass_mode; + reg_val = (u32)pdata->pin_tx2 | (u32)pdata->ntc_pin | + (u32)pdata->pass_mode; ret = regmap_update_bits(chip->regmap, 0x0A, 0xC4, reg_val); if (ret < 0) goto out;