From patchwork Thu Aug 20 09:19:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 248039 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp1376560ils; Thu, 20 Aug 2020 06:48:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdenjQHp1DV1Rj5mSv0ithc/V7xWyb68Pmz83bsb+osL8ks16AHK0DGqRT1uefuvKwAgGP X-Received: by 2002:a17:906:300b:: with SMTP id 11mr3299405ejz.270.1597931319187; Thu, 20 Aug 2020 06:48:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597931319; cv=none; d=google.com; s=arc-20160816; b=AF8uDHMJmYFCd/E4tKSwCIxHJFXVGQ2Wuc8uk6T7IPP3EJpZlzWVvlTrVYMkdQ5pJA lQoggi4xTZJH4HyY6KABVjm71Kq2UniRWbbNpxs42C90ebhor+QTf9MWjlbo24AK9nOF 4JfKq2UNgaNH2NygEMhNozKPfFGqQPvvm6xf5onozmI/N3pZ02OSrlfIP8GboFlUt635 j+Ba9sScd4+EMvRclMJLcNUpTOSpSrGqRdZAmrxyY/EgO5Iv6oUnDjZSaNc1R2Lg76w6 JGujyzKpF6tn2FUTRfEt9Cl4ZMkDxcPp6Fu39epI1XHedDRA0HIIAxmzOf02OEFAX4i/ gwkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LxxPLqPs7h8vRZ2paK/ShFH5DsG8RRYd/mZl5ttzZ2Q=; b=ama5qjfzz5auersufnHZBY+WY+7twOs1Jde3YCnHdsByf5Y3uAw2+R8ddv24g3NNOr cZW6W/dw89Az/JbTy97jdctMwQINArF4MVVcPDEW0OIMIx677P0LfXiXG6dzQO7YwJoY 1j8mgjY5Wd6vOj2lOoSbz0iRnvCL5R08EtnUJpBmfQkAyJAVkRF7CZ66H9I9i5Mq70Pz xXa3stKnEBV1wyTP3sJwsico31oXWXc6B+mUU2wOujgs5zg0iBMwD734tgr8iFYErvZj TDq8ZlMFo1da8oH0yWP+0Fl2Luz/7yUY90fup1X98K2ycKpfzdMU5oKaC4a/GGccWSF2 O9Hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=02h011X0; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kq26si1296766ejb.102.2020.08.20.06.48.38; Thu, 20 Aug 2020 06:48:39 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=02h011X0; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728033AbgHTNjp (ORCPT + 15 others); Thu, 20 Aug 2020 09:39:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:40204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728124AbgHTJaU (ORCPT ); Thu, 20 Aug 2020 05:30:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23D8322BEB; Thu, 20 Aug 2020 09:30:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597915818; bh=nibtvUdmYlYfzAmksvOuc+YpD990OolnyT4nsyqRArQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=02h011X0haOlRI72Nbs7oianmCMazDs3/HWravs2JnIm78fABiQV3geV9KBhr5Mdt Ut96Rcysar2YN6w3F+1mlDmBreI+s3sv/FewMyrTP8tg/Wbht+dvTESasqxiT0BnnH 9pIR60IRkgGb86Kjev3bGr7nxpWW0s2OvbBeBjiA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sudeep Holla , Alexandre Belloni , Valentin Schneider , Linus Walleij , Sasha Levin Subject: [PATCH 5.8 144/232] rtc: pl031: fix set_alarm by adding back call to alarm_irq_enable Date: Thu, 20 Aug 2020 11:19:55 +0200 Message-Id: <20200820091619.798300902@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200820091612.692383444@linuxfoundation.org> References: <20200820091612.692383444@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Sudeep Holla [ Upstream commit 4df2ef85f0efe44505f511ca5e4455585f53a2da ] Commit c8ff5841a90b ("rtc: pl031: switch to rtc_time64_to_tm/rtc_tm_to_time64") seemed to have accidentally removed the call to pl031_alarm_irq_enable from pl031_set_alarm while switching to 64-bit apis. Let us add back the same to get the set alarm functionality back. Fixes: c8ff5841a90b ("rtc: pl031: switch to rtc_time64_to_tm/rtc_tm_to_time64") Signed-off-by: Sudeep Holla Signed-off-by: Alexandre Belloni Tested-by: Valentin Schneider Cc: Linus Walleij Cc: Alexandre Belloni Link: https://lore.kernel.org/r/20200714124556.20294-1-sudeep.holla@arm.com Signed-off-by: Sasha Levin --- drivers/rtc/rtc-pl031.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c index 40d7450a1ce49..c6b89273feba8 100644 --- a/drivers/rtc/rtc-pl031.c +++ b/drivers/rtc/rtc-pl031.c @@ -275,6 +275,7 @@ static int pl031_set_alarm(struct device *dev, struct rtc_wkalrm *alarm) struct pl031_local *ldata = dev_get_drvdata(dev); writel(rtc_tm_to_time64(&alarm->time), ldata->base + RTC_MR); + pl031_alarm_irq_enable(dev, alarm->enabled); return 0; }