From patchwork Thu Aug 20 09:22:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 265607 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F7EC433E1 for ; Thu, 20 Aug 2020 11:04:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9707A2072D for ; Thu, 20 Aug 2020 11:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597921457; bh=2RFugXFY8l1TNplHohrCPXjqVwzZuu0ou9TwaVKZXu4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=VFCz7YGtH5WG2Ei5G+DduVeJt4PDpRB3oXpDaqV2mIdQxNW7QkK3ihqrgebQxlbZj xtmL9G+gaM20Riga5oupc2L6xhrZrgXEv38lYJCFyCUagXhigqNtv2qfDwRT22THDC K23dK/7wHwVLLTurDVxp0SE2hu61C/LCpPf4SvZY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730362AbgHTK7K (ORCPT ); Thu, 20 Aug 2020 06:59:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:59280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730723AbgHTKNu (ORCPT ); Thu, 20 Aug 2020 06:13:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 476C620724; Thu, 20 Aug 2020 10:13:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597918429; bh=2RFugXFY8l1TNplHohrCPXjqVwzZuu0ou9TwaVKZXu4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c+BWlx6FRVdeacT9DSFFuQVVW2iSRCgMcCgmEqGGkEIZBOoL5UrchwlwW8BRsYz9w JsNS4HunoensxhbrF/UqyQp6ItPQpAj1Usn4BzwRr8t2l5TdfBR9A4Tr3zdr6kfXIw iLliOrQwsta9aS5Yt/2gwK/VkKSIQLppp9wmS0Og= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Steve French Subject: [PATCH 4.14 167/228] smb3: warn on confusing error scenario with sec=krb5 Date: Thu, 20 Aug 2020 11:22:22 +0200 Message-Id: <20200820091615.920071635@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200820091607.532711107@linuxfoundation.org> References: <20200820091607.532711107@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Steve French commit 0a018944eee913962bce8ffebbb121960d5125d9 upstream. When mounting with Kerberos, users have been confused about the default error returned in scenarios in which either keyutils is not installed or the user did not properly acquire a krb5 ticket. Log a warning message in the case that "ENOKEY" is returned from the get_spnego_key upcall so that users can better understand why mount failed in those two cases. CC: Stable Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- fs/cifs/smb2pdu.c | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -942,6 +942,8 @@ SMB2_auth_kerberos(struct SMB2_sess_data spnego_key = cifs_get_spnego_key(ses); if (IS_ERR(spnego_key)) { rc = PTR_ERR(spnego_key); + if (rc == -ENOKEY) + cifs_dbg(VFS, "Verify user has a krb5 ticket and keyutils is installed\n"); spnego_key = NULL; goto out; }