From patchwork Mon Aug 17 15:09:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 247877 Delivered-To: patch@linaro.org Received: by 2002:a54:3b12:0:0:0:0:0 with SMTP id j18csp2600045ect; Mon, 17 Aug 2020 12:50:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRvceqf+V0xLVONrJh3zekLR/Lwmu3bIfwp4V341Oqfm66Rh2NjvwrUf2FGKvYw3E2RkG9 X-Received: by 2002:a50:d74b:: with SMTP id i11mr17324681edj.136.1597693807812; Mon, 17 Aug 2020 12:50:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597693807; cv=none; d=google.com; s=arc-20160816; b=E9qWdaaWeFPtINGwvb0qmBJ4nFlzeiSvIIQoS+scWVZsmdUYu/HiF6RB3zbQxcZWdp mTiNo9VaQkFfSB1RLddwhlBgI3pdObllhpEv2Ppwc8dhLWc400VZ1CuJ/fle1VLMTPib hOWX+BoQod8gusAe2pMP7KVGhYRc3r9uoldHg3SCLnqpmtPHfkSheRi83KhBrhLqghlz BY4W6ZLBJGWv+J7HCbm1kQI5jgVsWHPwvQbDhbGh5tKJxmmqXE4G/2WlNnfPS83zw+O5 jJXFAWQlWvQBmDn6ZAWJKWBf2CYfvwKvOaWbQxvhiZ8KLc9Zx8qXNvboNs7Uj4llo+yT 6tGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=z5yPICT8IGIO4KJpKgwvUAjr8rGuye9x45WE6ilofhE=; b=UwT4Ln+SVx1Rhy2Pp0aedbHeg+26ZnaP5Kz7V5F0efplbIVM6g/Q9LQCGpJ8iQF24U KSAQWehWyCOmbkkyuQM8ul1REWpUflxOmpV+gG9Tz/b+Km/XnU0VOI4vMHE51x5vjT1T Fuj2kwpPvJGET6+nUVw8WrHHV503O5aO280Dv5s0r6NKDy9vA3SGKXrbHUMCOLUaJ+aB E2u8c1e8kZSNjGZqUo3p6m+D8VxXWMnMlr0gDouWizrc6vyfGgM3RhEIRktDCMWtBmgb yZIUDqigXlVbmwFbClfLTb3xGB7chsrieIcW7ggR3OqIr8f5zPjx8nwcIJQFGYF/GrKg cQIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rEgcM+IO; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qw15si12222900ejb.481.2020.08.17.12.50.07; Mon, 17 Aug 2020 12:50:07 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rEgcM+IO; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732632AbgHQTtm (ORCPT + 15 others); Mon, 17 Aug 2020 15:49:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:41682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729242AbgHQPUD (ORCPT ); Mon, 17 Aug 2020 11:20:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C2C0207D3; Mon, 17 Aug 2020 15:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597677600; bh=CD3HPUADLYe44TSi72mJmigB4TKXwZYje3mQ+Tm1oJA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rEgcM+IOxLhdwTu1eZSQPbNBLOJVuyny+ibp9Th6v+/IkfZV6tMtg77KTMCOrUEoZ KiFpJsLCt03DPCVE0qAP7+qzPkpHsG1KafxvRlXNeQh9Q1byhn/1YvFDiNE0OokHi6 wM7J4gFiQJ81vEoSR9sDahq77jHrBU8H2O6NNvxw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Willy Wolff , Marek Szyprowski , Krzysztof Kozlowski , Sasha Levin Subject: [PATCH 5.8 040/464] ARM: dts: exynos: Disable frequency scaling for FSYS bus on Odroid XU3 family Date: Mon, 17 Aug 2020 17:09:53 +0200 Message-Id: <20200817143835.674186075@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200817143833.737102804@linuxfoundation.org> References: <20200817143833.737102804@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marek Szyprowski [ Upstream commit 9ff416cf45a08f28167b75045222c762a0347930 ] Commit 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the values correct for Exynos5422 Odroids") changed the parameters of the OPPs for the FSYS bus. Besides the frequency adjustments, it also removed the 'shared-opp' property from the OPP table used for FSYS_APB and FSYS busses. This revealed that in fact the FSYS bus frequency scaling never worked. When one OPP table is marked as 'opp-shared', only the first bus which selects the OPP sets the rate of its clock. Then OPP core assumes that the other busses have been changed to that OPP and no change to their clock rates are needed. Thus when FSYS_APB bus, which was registered first, set the rate for its clock, the OPP core did not change the FSYS bus clock later. The mentioned commit removed that behavior, what introduced a regression on some Odroid XU3 boards. Frequency scaling of the FSYS bus causes instability of the USB host operation, what can be observed as network hangs. To restore old behavior, simply disable frequency scaling for the FSYS bus. Reported-by: Willy Wolff Fixes: 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the values correct for Exynos5422 Odroids") Signed-off-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski Signed-off-by: Sasha Levin --- arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 6 ------ 1 file changed, 6 deletions(-) -- 2.25.1 diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi index ab27ff8bc3dca..afe090578e8fa 100644 --- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi @@ -411,12 +411,6 @@ &bus_fsys_apb { status = "okay"; }; -&bus_fsys { - operating-points-v2 = <&bus_fsys2_opp_table>; - devfreq = <&bus_wcore>; - status = "okay"; -}; - &bus_fsys2 { operating-points-v2 = <&bus_fsys2_opp_table>; devfreq = <&bus_wcore>;