From patchwork Mon Aug 17 15:11:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 247809 Delivered-To: patch@linaro.org Received: by 2002:a92:cc90:0:0:0:0:0 with SMTP id x16csp2741843ilo; Mon, 17 Aug 2020 08:43:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz86D+/q4JDjTPdxzYSAksgi42LdKcJKczQrb4CnwLlH+1QPKtmYwqz/3Uo0dlYCL1Xdkib X-Received: by 2002:a05:6402:2285:: with SMTP id cw5mr15228840edb.242.1597679017783; Mon, 17 Aug 2020 08:43:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597679017; cv=none; d=google.com; s=arc-20160816; b=f+CJwN4P/9HQTLGKGqaGWeAvc2LD2IKo8yMKdROBGruoognO4S/gEgs5m7ykkNYICQ eFtkw0biFzZzt5AtxpguTRyHFgPEc/yCT8qQH/CSDylDkq8x8AcdyPxPV3wdVAYJ9gMZ W1a0kDqT2B3ACZOnPdrdasA/zvFF3VmOfGOsi01sG3qOLzf5zBvQ2uWr+LwcHmhCoJka uwEkGUozgzJ19UEcjb/00InFEFm8cGRyisr3rR6IM8Y8dmgky88u3sM5FWSBxqS0M7cy wjZRSaVGgrwfr5rzlYP5dpfsfTpVEW3S3DQoH8YYxLIUoUs2wIi8p77+/PtQVpNN2Kcy 6rVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YHfxuUMis9eElGWDQdsnspq8YiR0wZV9i8ttJ420p9A=; b=d0c1k4kOt/T5rcp3HznSXdI+lns05JNRmTORCkkB3RWtf2Y30CGyBGT427nM0oPfaw J1e8uF8CF2bD53hpsQoeeqeLv1N1VZooC0Q9wIfJG2YxN/BPQOEzbAfNRg7Z7i4rdfdW HC9HKLpe5ejylwISP3m0tXAx7ITtGTucI4SCvMcR3109oGUX3/fFRAcvTxD7KC7PgKW9 UqtP7iKUtNUw7Ol3SovWq0kqfMM2Toxhm3X7P2NNMJYxgDvMyjm7ATkYPuXHCSkHj2k6 pNTo02F0z/E8JzMoUPfxo9G8sfySFyu5dsWjiqj7vA6+vbyr4fT4OsACfVBMwl8ZGsf1 xr+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YMKk2K8c; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p22si11293463eds.169.2020.08.17.08.43.37; Mon, 17 Aug 2020 08:43:37 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YMKk2K8c; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387655AbgHQPnf (ORCPT + 15 others); Mon, 17 Aug 2020 11:43:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:53928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387646AbgHQPnb (ORCPT ); Mon, 17 Aug 2020 11:43:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE8AA2075B; Mon, 17 Aug 2020 15:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597679010; bh=AILpoJFYFqqiQwh8J5OFU9tSJgZo+/G+qh3xcX/ibdE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YMKk2K8cXqzf8rtivTcf7LpDnriOUPY0pYeMw27HCb8wY4vK/maoQCOubya49zmP3 ML575GbbUyADwku12rvKrcUR+UIIZVrifZ1qqXgMlbUm8rW5GYQrXqm8t0pmgzJZ+y 3+1QH3HnxQH+LoC7Km9+CTC1n23UTPI2qNt+84Vo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "kernelci.org bot" , Guillaume Tucker , Krzysztof Kozlowski , Sasha Levin Subject: [PATCH 5.7 066/393] ARM: exynos: clear L310_AUX_CTRL_FULL_LINE_ZERO in default l2c_aux_val Date: Mon, 17 Aug 2020 17:11:56 +0200 Message-Id: <20200817143822.825152303@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200817143819.579311991@linuxfoundation.org> References: <20200817143819.579311991@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Guillaume Tucker [ Upstream commit 5b17a04addc29201dc142c8d2c077eb7745d2e35 ] This "alert" error message can be seen on exynos4412-odroidx2: L2C: platform modifies aux control register: 0x02070000 -> 0x3e470001 L2C: platform provided aux values permit register corruption. Followed by this plain error message: L2C-310: enabling full line of zeros but not enabled in Cortex-A9 To fix it, don't set the L310_AUX_CTRL_FULL_LINE_ZERO flag (bit 0) in the default value of l2c_aux_val. It may instead be enabled when applicable by the logic in l2c310_enable() if the attribute "arm,full-line-zero-disable" was set in the device tree. The initial commit that introduced this default value was in v2.6.38 commit 1cf0eb799759 ("ARM: S5PV310: Add L2 cache init function in cpu.c"). However, the code to set the L310_AUX_CTRL_FULL_LINE_ZERO flag and manage that feature was added much later and the default value was not updated then. So this seems to have been a subtle oversight especially since enabling it only in the cache and not in the A9 core doesn't actually prevent the platform from running. According to the TRM, the opposite would be a real issue, if the feature was enabled in the A9 core but not in the cache controller. Reported-by: "kernelci.org bot" Signed-off-by: Guillaume Tucker Signed-off-by: Krzysztof Kozlowski Signed-off-by: Sasha Levin --- arch/arm/mach-exynos/exynos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index 7a8d1555db404..36c37444485a8 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -193,7 +193,7 @@ static void __init exynos_dt_fixup(void) } DT_MACHINE_START(EXYNOS_DT, "Samsung Exynos (Flattened Device Tree)") - .l2c_aux_val = 0x3c400001, + .l2c_aux_val = 0x3c400000, .l2c_aux_mask = 0xc20fffff, .smp = smp_ops(exynos_smp_ops), .map_io = exynos_init_io,