From patchwork Mon Aug 17 15:11:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 247806 Delivered-To: patch@linaro.org Received: by 2002:a92:cc90:0:0:0:0:0 with SMTP id x16csp2740805ilo; Mon, 17 Aug 2020 08:42:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAReHf8EsaUCuVUUNx/BxzszF9FWeGZVPJFjxi/MSpmkXSExxjqY5HqMF5g4eD6ujyyQ5T X-Received: by 2002:a17:906:d92:: with SMTP id m18mr16292067eji.428.1597678935440; Mon, 17 Aug 2020 08:42:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597678935; cv=none; d=google.com; s=arc-20160816; b=NN21Ky35HJfYgQU4ZaZzcLwVNWBIgmrihBPZcCO5zA71uE9e1/IbUUTtWlI9tllxHI XycxijB+KB5fAkshSgsDTnn/xJZg0LQFznsK3VaAXlNJVYkFeSt1jcJ8UkcBoYj0CCBq j7N7NK6cFmKxAPWRr0BmW49WD1X2Nu24ZoJeOgn/a+fnJ2XucdaNWlXRsV3eqTxUTKgo Tvcr+ew5uH0X7F+bkc+tWNDIyeIQ3bylmCfJTzLJiqb3VhGP/Jif+06jj9bfXgbzJbaF Ya1c4tlhXDzBNWj1DhofeVVtHq93PsbwrKRW3QWqEmql+euRavJGH0WUZwMARXyzNv3B ILPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=z5yPICT8IGIO4KJpKgwvUAjr8rGuye9x45WE6ilofhE=; b=NpjuNMhI13SOOuop7TTokjpb+n7P9zHn5QLiqwV7vJfi1STfSEeMx2wYaF4gnp4jWo MxvwcP4JJFcYoCE8zpwG++bLZhCObd4prrB/XwDDFIXw3MfgSR3pK0vZXnmC3nFrWkSD ZAu5fhXOh9BzXQwdx58z15P7AwViReyXR2w0RLMV4dK9mKZeNaFO3ieoVU4x4G2sX5uW 7FQgNzdxsvrj76G88GPKK90kkm9DFpwikC8Re0cWaBzqHJ3tHyTFcHNABnnLpRgdaiSO /Uf3alx0AwbhEBC1zO32M+x7k7gmV/DF3Xv4ugBxNclGz/nyWuG8oLg0q6MG/k/tHSfy FDsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=v83lhnPY; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x2si11858916edj.273.2020.08.17.08.42.15; Mon, 17 Aug 2020 08:42:15 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=v83lhnPY; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387500AbgHQPmM (ORCPT + 15 others); Mon, 17 Aug 2020 11:42:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:51940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387495AbgHQPmF (ORCPT ); Mon, 17 Aug 2020 11:42:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3E68520760; Mon, 17 Aug 2020 15:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597678924; bh=CD3HPUADLYe44TSi72mJmigB4TKXwZYje3mQ+Tm1oJA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=v83lhnPY1j6HLNuyItSKz5YU5ixvLYt7sQmQjat2ehKC5P7hwEw6tBW2BNzde+eJP mcrHsGl5CUKa26scHToMZc+3vhzDVuLU9JGOg+2ip2DvgjE5JZy7ZOA44Mv9Z2eHQT FCUlBQFZRYjyikQS4xFWS8b5T1dbI4XTmOKM11Qw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Willy Wolff , Marek Szyprowski , Krzysztof Kozlowski , Sasha Levin Subject: [PATCH 5.7 037/393] ARM: dts: exynos: Disable frequency scaling for FSYS bus on Odroid XU3 family Date: Mon, 17 Aug 2020 17:11:27 +0200 Message-Id: <20200817143821.406953057@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200817143819.579311991@linuxfoundation.org> References: <20200817143819.579311991@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marek Szyprowski [ Upstream commit 9ff416cf45a08f28167b75045222c762a0347930 ] Commit 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the values correct for Exynos5422 Odroids") changed the parameters of the OPPs for the FSYS bus. Besides the frequency adjustments, it also removed the 'shared-opp' property from the OPP table used for FSYS_APB and FSYS busses. This revealed that in fact the FSYS bus frequency scaling never worked. When one OPP table is marked as 'opp-shared', only the first bus which selects the OPP sets the rate of its clock. Then OPP core assumes that the other busses have been changed to that OPP and no change to their clock rates are needed. Thus when FSYS_APB bus, which was registered first, set the rate for its clock, the OPP core did not change the FSYS bus clock later. The mentioned commit removed that behavior, what introduced a regression on some Odroid XU3 boards. Frequency scaling of the FSYS bus causes instability of the USB host operation, what can be observed as network hangs. To restore old behavior, simply disable frequency scaling for the FSYS bus. Reported-by: Willy Wolff Fixes: 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the values correct for Exynos5422 Odroids") Signed-off-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski Signed-off-by: Sasha Levin --- arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 6 ------ 1 file changed, 6 deletions(-) -- 2.25.1 diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi index ab27ff8bc3dca..afe090578e8fa 100644 --- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi @@ -411,12 +411,6 @@ &bus_fsys_apb { status = "okay"; }; -&bus_fsys { - operating-points-v2 = <&bus_fsys2_opp_table>; - devfreq = <&bus_wcore>; - status = "okay"; -}; - &bus_fsys2 { operating-points-v2 = <&bus_fsys2_opp_table>; devfreq = <&bus_wcore>;