From patchwork Mon Aug 17 15:15:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 247842 Delivered-To: patch@linaro.org Received: by 2002:a92:cc90:0:0:0:0:0 with SMTP id x16csp2858962ilo; Mon, 17 Aug 2020 11:21:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDVS3nlohVxdaVx66N91tFalaHbJAat1ZgaOHbyDZXtg2QEboYJzeKHP/ZyUUAa2B3BwQR X-Received: by 2002:aa7:c45a:: with SMTP id n26mr16386726edr.45.1597688496995; Mon, 17 Aug 2020 11:21:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597688496; cv=none; d=google.com; s=arc-20160816; b=akBQs2OdmPMCb6CtAOoN2ojNDBA2ZL4zG5ApASNembpfDtVwixdhdkChKA+P3vHUdW JSKcKm14+R0xi3Wa0TUcDyDCPbyIfzHqfwMPjMGG42tFLWdJyNe9/aBwcdmowKBvX7U2 H2A2ZE3KjonvvzbBkK7ml3u1AHAPVPlFBx32w0cf+GqpCq82UvAF/sEaAV2QKyNotQRv qhiP2Iv1mwOgLSwnwRL2H6FWLCC1REA4IIZB5QfhbmACGYELQAhIfptFHTLdW8W1/aZ3 9cz4eWLzAObyE6XEOM4qjwUtQRtIey98jljC65yA9OwdmkT8mmqJJebqiy/wNuo1stGe QILw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wiCTK/pPHYxOLbrPIKaCqHJ2c33JMoaRuXDgV36Gnng=; b=no1n+V4rYtSyGT9FRF4lYjTfJ8ilXY9bVjzooium1sZSsiu6pVDiX/Z4XS7wMwcnuD 4Eo1Kfa6VE07jLhFsPFEvII1N/jMV3DmnFGkKLyPvHpY/vk5m/uOAVrdATzLN4WoSTUL msXlnfvWKgeU9SCmQ2n3Ntv2dmFqZ43YKuKaRJBxqN1f2HqHhGUeOYOXnNWAQbILnGts wL17UHsO/jsgrFbrqvgPQy3XVNURnECXg9feyT5PifAKPsMVYKljQeF9K7cqQdsOHvLZ W2+ZCZUr6+NtrHXkP0T57t9AshSu93qET44JLRAZ/GNQclnHBOi9byblOIC6LdTZjtXw blcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ho+x2yrY; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si10563894edz.371.2020.08.17.11.21.36; Mon, 17 Aug 2020 11:21:36 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ho+x2yrY; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390864AbgHQSVS (ORCPT + 15 others); Mon, 17 Aug 2020 14:21:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:51714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388275AbgHQQEB (ORCPT ); Mon, 17 Aug 2020 12:04:01 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D836206FA; Mon, 17 Aug 2020 16:04:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597680240; bh=7CMovI0zAwuBI0lGbchrtjjutgyxnMT1+5oXz6Mpy1Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ho+x2yrYcQDy2seh4X06B4CNu7Fhvd/775/4kVEqiUoK0HB2QHXoZmmdkNEPevn5c MYP9k0Z0EzemEtFcu81SvfYHNoysmRHCbYeT2PPPtbc3UqKxGvZoDIvPW+xtd/wrE3 PKubifdqDbM8ZVH9rVa0qMIr6Z68D8VLzBn0p5KQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Sean Young , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.4 108/270] media: cxusb-analog: fix V4L2 dependency Date: Mon, 17 Aug 2020 17:15:09 +0200 Message-Id: <20200817143801.156854294@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200817143755.807583758@linuxfoundation.org> References: <20200817143755.807583758@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 1a55caf010c46d4f2073f9e92e97ef65358c16bf ] CONFIG_DVB_USB_CXUSB_ANALOG is a 'bool' symbol with a dependency on the tristate CONFIG_VIDEO_V4L2, which means it can be enabled as =y even when its dependency is =m. This leads to a link failure: drivers/media/usb/dvb-usb/cxusb-analog.o: In function `cxusb_medion_analog_init': cxusb-analog.c:(.text+0x92): undefined reference to `v4l2_subdev_call_wrappers' drivers/media/usb/dvb-usb/cxusb-analog.o: In function `cxusb_medion_register_analog': cxusb-analog.c:(.text+0x466): undefined reference to `v4l2_device_register' cxusb-analog.c:(.text+0x4c3): undefined reference to `v4l2_i2c_new_subdev' cxusb-analog.c:(.text+0x4fb): undefined reference to `v4l2_subdev_call_wrappers' ... Change the dependency only disallow the analog portion of the driver in that configuration. Fixes: e478d4054054 ("media: cxusb: add analog mode support for Medion MD95700") Signed-off-by: Arnd Bergmann Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/dvb-usb/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/drivers/media/usb/dvb-usb/Kconfig b/drivers/media/usb/dvb-usb/Kconfig index 1a3e5f965ae40..2d7a5c1c84af6 100644 --- a/drivers/media/usb/dvb-usb/Kconfig +++ b/drivers/media/usb/dvb-usb/Kconfig @@ -150,6 +150,7 @@ config DVB_USB_CXUSB config DVB_USB_CXUSB_ANALOG bool "Analog support for the Conexant USB2.0 hybrid reference design" depends on DVB_USB_CXUSB && VIDEO_V4L2 + depends on VIDEO_V4L2=y || VIDEO_V4L2=DVB_USB_CXUSB select VIDEO_CX25840 select VIDEOBUF2_VMALLOC help