From patchwork Mon Aug 17 15:17:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 247824 Delivered-To: patch@linaro.org Received: by 2002:a54:3b12:0:0:0:0:0 with SMTP id j18csp2471809ect; Mon, 17 Aug 2020 09:15:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMNf0w0YtKTcnaw2Ry1gLbdi6BOn3VyCl41JNqRZ3HFOzLEtXOKDKSk+yvACQ0RGfpRkPh X-Received: by 2002:a17:907:444c:: with SMTP id on20mr16809541ejb.77.1597680959088; Mon, 17 Aug 2020 09:15:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597680959; cv=none; d=google.com; s=arc-20160816; b=jsxkj6fShjl9s9m9bLEQpMF/rMvc/YXYzMh3vRMIQ4qz9FWPVlaEvXPqMo/GckV9rS Wd2Sv/MChl2Rl9GuFETZ4jWu8mWiynIzauHF+47hMUe6I+mj0m6B0e4r08CKl0hR9yjN yqANZsIGV4SwyT5ZY8cdEB8ywt1fuIQj735R3TKuuLulF9vcw0xc38crT1YmdGRHt0uW tdEcNM0AEzKFwc5BLiMdUOHApWduMaYe7nYAYHtVEHg4lnft3U7IR5GTUbP31eDcbAxg 34Y/rEHH3fq3AamnYG/A6crqcH7z+U59HZhY5k5FLwWrFoBCtv7017NIaVoDSgQYJfNK kx0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jIToABscP/wn2lnAvYiws7Pu0uhsqx8lGAEDVLrtHcU=; b=eAd+B7kBXjCYQw3jR3ao+rJdAPJZZ4zqhTXqnKF3CSfzGsbZZYsN6bru2fBxKwyXc6 BXJa5fK1/8jZtnn/WtTSS4ErWUtR1pkLYwx2uP0cAh960cWDEnpJYzTJWEO2JSQP8Ojy 4f7nGCjr1e6mXowZb51N7I6rsFCqp+gmNCt7LjfrEtGbsOaXmiOqdPqGHExWpI6JQr8K GqmatPVRIgHxpjs2Ad7ghv3h3mHPmKMMPvqhmRiINE/QZSS8mGJt2Q6LyfudIJsABZBF TeYzA8S2eZ8tM9xwkQn60S9GwP0OP8uGCoqAcP6Fv7xmn2qfKw2WJdDMx0IrWVHuhnZi uBXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jxJWSdIb; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q22si11136809ejn.410.2020.08.17.09.15.58; Mon, 17 Aug 2020 09:15:59 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jxJWSdIb; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731089AbgHQQPr (ORCPT + 15 others); Mon, 17 Aug 2020 12:15:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:54148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729495AbgHQQP1 (ORCPT ); Mon, 17 Aug 2020 12:15:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA8A722B4E; Mon, 17 Aug 2020 16:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597680924; bh=Asd07owELHLcVJSCB7XcF6eSEPdZsLwxYMqKCmtZ44g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jxJWSdIbSn4dFB3DhbffFGHH01IvneyhwU6RWZ3y7/DncC53/Q0cdssDAgKajzKuC 5o3Eku0X+W7csKLhamYg6YKSOqNxCkiR8YjP7S58DjliVjU3mzFCvvTopnecV0VteF xzX1imtwx1gsjw1MGafLRX4n4WmlXZAl2mcLIHJE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jerome Brunet , Mark Brown , Sasha Levin Subject: [PATCH 4.19 113/168] ASoC: meson: axg-tdm-interface: fix link fmt setup Date: Mon, 17 Aug 2020 17:17:24 +0200 Message-Id: <20200817143739.332370053@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200817143733.692105228@linuxfoundation.org> References: <20200817143733.692105228@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jerome Brunet [ Upstream commit 6878ba91ce84f7a07887a0615af70f969508839f ] The .set_fmt() callback of the axg tdm interface incorrectly test the content of SND_SOC_DAIFMT_MASTER_MASK as if it was a bitfield, which it is not. Implement the test correctly. Fixes: d60e4f1e4be5 ("ASoC: meson: add tdm interface driver") Signed-off-by: Jerome Brunet Link: https://lore.kernel.org/r/20200729154456.1983396-2-jbrunet@baylibre.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/meson/axg-tdm-interface.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) -- 2.25.1 diff --git a/sound/soc/meson/axg-tdm-interface.c b/sound/soc/meson/axg-tdm-interface.c index 7b8baf46d9689..5c055d8de8c7d 100644 --- a/sound/soc/meson/axg-tdm-interface.c +++ b/sound/soc/meson/axg-tdm-interface.c @@ -111,18 +111,25 @@ static int axg_tdm_iface_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) { struct axg_tdm_iface *iface = snd_soc_dai_get_drvdata(dai); - /* These modes are not supported */ - if (fmt & (SND_SOC_DAIFMT_CBS_CFM | SND_SOC_DAIFMT_CBM_CFS)) { + switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { + case SND_SOC_DAIFMT_CBS_CFS: + if (!iface->mclk) { + dev_err(dai->dev, "cpu clock master: mclk missing\n"); + return -ENODEV; + } + break; + + case SND_SOC_DAIFMT_CBM_CFM: + break; + + case SND_SOC_DAIFMT_CBS_CFM: + case SND_SOC_DAIFMT_CBM_CFS: dev_err(dai->dev, "only CBS_CFS and CBM_CFM are supported\n"); + /* Fall-through */ + default: return -EINVAL; } - /* If the TDM interface is the clock master, it requires mclk */ - if (!iface->mclk && (fmt & SND_SOC_DAIFMT_CBS_CFS)) { - dev_err(dai->dev, "cpu clock master: mclk missing\n"); - return -ENODEV; - } - iface->fmt = fmt; return 0; } @@ -311,7 +318,8 @@ static int axg_tdm_iface_hw_params(struct snd_pcm_substream *substream, if (ret) return ret; - if (iface->fmt & SND_SOC_DAIFMT_CBS_CFS) { + if ((iface->fmt & SND_SOC_DAIFMT_MASTER_MASK) == + SND_SOC_DAIFMT_CBS_CFS) { ret = axg_tdm_iface_set_sclk(dai, params); if (ret) return ret;